From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v2 1/4] drm/i915: add warning for unidle GPU Date: Sun, 25 Sep 2011 12:15:18 +0100 Message-ID: References: <1316902987-24774-1-git-send-email-ben@bwidawsk.net> <1316902987-24774-2-git-send-email-ben@bwidawsk.net> <20110925101636.GB2852@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B9A39EBD3 for ; Sun, 25 Sep 2011 04:15:37 -0700 (PDT) In-Reply-To: <20110925101636.GB2852@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, 25 Sep 2011 12:16:36 +0200, Daniel Vetter wrote: > Also it looks like this causes us to no properly idle the gpu on > suspend/resume. Might fix issues especially on gen2/3 where we put an > MI_WAIT in front of the flip, hence enlarging the window to up to 20 ms. This I happen to disagree with as there is an existing bug with not properly quiescing the GPU (on all gen) when disabling pipes that would also be hit in this case. -Chris -- Chris Wilson, Intel Open Source Technology Centre