From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: Force sync command ordering Date: Tue, 11 Oct 2011 20:16:55 +0100 Message-ID: References: <1318357916-12661-1-git-send-email-ben@bwidawsk.net> <1318357916-12661-4-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 74054A0985 for ; Tue, 11 Oct 2011 12:16:57 -0700 (PDT) In-Reply-To: <1318357916-12661-4-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, 11 Oct 2011 11:31:56 -0700, Ben Widawsky wrote: > This will strongly order synchronization commands with respect to 3d > state and 3d primitive commands. AFAIK, this shouldn't impact anything > as these sync commands are all for privileged (or ppgtt) batches only, > so user space should not be relying on this, and the kernel wouldn't be > relying on 3d state or primitive commands. > > This will help when we enable PPGTT, and perhaps this synchronization is > currently useful and I just don't realize it. > > This was found through doc inspection by Ken and applies to Gen6+; > > Reported-by: Kenneth Graunke > Signed-off-by: Ben Widawsky Ok, that bit does look quite important..., and the code also looks correct! Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre