From: Chris Wilson <chris@chris-wilson.co.uk>
To: przanoni@gmail.com, intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 2/3] drm/i915: Rename HDMI register field definitions
Date: Fri, 14 Oct 2011 22:39:08 +0100 [thread overview]
Message-ID: <e39f63$2akjtm@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1318627029-10311-1-git-send-email-przanoni@gmail.com>
On Fri, 14 Oct 2011 18:17:09 -0300, przanoni@gmail.com wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Also making the differences between HDMI{B,C,D} and SDVO registers for
> non-PCH, IBX and CPT more explicit.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
I'm a little more dubious over the value of this patch. The extra
information is nice, but the patch doesn't impact much upon the
readibility of the code. It seems like this should have the potential to
clarify quite a bit of the logic and make it more consistent, yet that
is not addressed here. Do you have plans to make use of the cleanup?
Does it catch any bugs?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-10-14 21:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 12:49 [PATCH] drm/i915: set the right SDVO transcoder for CPT przanoni
2011-10-13 13:38 ` Adam Jackson
2011-10-13 13:51 ` Chris Wilson
2011-10-13 17:41 ` przanoni
2011-10-13 20:39 ` Chris Wilson
2011-10-14 21:16 ` [PATCH 1/3] " przanoni
2011-10-14 21:30 ` Chris Wilson
2011-10-24 19:34 ` Paulo Zanoni
2011-10-14 21:17 ` [PATCH 2/3] drm/i915: Rename HDMI register field definitions przanoni
2011-10-14 21:39 ` Chris Wilson [this message]
2011-10-17 19:04 ` Paulo Zanoni
2011-10-14 21:17 ` [PATCH 3/3] drm/i915: add PCH info to i915_capabilities przanoni
2011-10-14 21:34 ` Chris Wilson
2011-10-24 19:44 ` Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$2akjtm@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.