From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 08/43] drm/i915: drop register special-casing in forcewake Date: Wed, 14 Dec 2011 15:05:11 +0000 Message-ID: References: <1323867460-5486-1-git-send-email-daniel.vetter@ffwll.ch> <1323867460-5486-8-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CB2A9EB03 for ; Wed, 14 Dec 2011 07:05:33 -0800 (PST) In-Reply-To: <1323867460-5486-8-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, 14 Dec 2011 13:57:05 +0100, Daniel Vetter wrote: > We currently have 3 register for which we must not grab forcewake for: > FORCEWAKE, FROCEWAKE_MT and ECOBUS. > - FORCEWAKE is excluded in the NEEDS_FORCE_WAKE macro and accessed > with _NOTRACE. > - FORCEWAKE_MT is just accessed with _NOTRACE. > - ECOBUS is only excluded in the macro. > > In fear of an ever-growing list of special cases and to cut down the > confusion, just access all of them with the _NOTRACE variants. Instead you build in future confusion by making us guess wtf is this using *_NOTRACE. The NOTRACE macro needs a bit of explanation as it now is more than simply skipping the tracepoints, and why certain registers must be accessed through the macro. Also add that warning to the register define. -Chris -- Chris Wilson, Intel Open Source Technology Centre