From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 27/43] drm/i915: flush overlay regfile writes Date: Wed, 14 Dec 2011 15:24:49 +0000 Message-ID: References: <1323867460-5486-1-git-send-email-daniel.vetter@ffwll.ch> <1323867460-5486-27-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 354169E8AF for ; Wed, 14 Dec 2011 07:25:11 -0800 (PST) In-Reply-To: <1323867460-5486-27-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, 14 Dec 2011 13:57:24 +0100, Daniel Vetter wrote: > Better be paranoid. The wmb should flush the wc writes, and > the chipset_flush hopefully flushes any mch buffers. There've been a > few overlay hangs I've never really diagnosed, unfortunately all the > reporters disappeared. At which point we should just put the darn wmb into i830_chipset_flush() and make snark remarks about wbinvd. -Chris -- Chris Wilson, Intel Open Source Technology Centre