From: Chris Wilson <chris@chris-wilson.co.uk>
To: Sascha Hauer <s.hauer@pengutronix.de>, dri-devel@lists.freedesktop.org
Cc: kernel@pengutronix.de
Subject: Re: [PATCH 14/20] drm: add convenience function to create an enum property
Date: Wed, 01 Feb 2012 11:48:53 +0000 [thread overview]
Message-ID: <e39f63$3hhgph@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1328092718-28951-15-git-send-email-s.hauer@pengutronix.de>
On Wed, 1 Feb 2012 11:38:32 +0100, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> Creating an enum property is a common pattern, so create
> a convenience function for this and use it where appropriate.
Similar naming comments apply as for drm_property_create_range. However,
I did spot something anomalous...
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 8d593ad..cdbbb40 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -394,7 +394,7 @@ struct drm_crtc {
> s64 framedur_ns, linedur_ns, pixeldur_ns;
>
> /* if you are using the helper */
> - void *helper_private;
> + struct drm_crtc_helper_funcs *helper_private;
> };
>
>
> @@ -481,7 +481,7 @@ struct drm_encoder {
>
> struct drm_crtc *crtc;
> const struct drm_encoder_funcs *funcs;
> - void *helper_private;
> + struct drm_encoder_helper_funcs *helper_private;
> };
>
> enum drm_connector_force {
> @@ -573,7 +573,7 @@ struct drm_connector {
> /* requested DPMS state */
> int dpms;
>
> - void *helper_private;
> + struct drm_connector_helper_funcs *helper_private;
>
> /* forced on connector */
> enum drm_connector_force force;
This is a separate chunk.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-01 11:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 10:38 [PATCH] drm cleanup patches Sascha Hauer
2012-02-01 10:38 ` [PATCH 01/20] drm crtc: use drm_mode_destroy instead of kfree in drm_mode_remove Sascha Hauer
2012-02-01 10:38 ` [PATCH 02/20] drm crtc: add forgotten idr cleanup functions Sascha Hauer
2012-02-01 10:38 ` [PATCH 03/20] drm drm_edit: drm modes have to be free with drm_mode_destroy Sascha Hauer
2012-02-01 10:38 ` [PATCH 04/20] drm drm_fb_helper: destroy modes Sascha Hauer
2012-02-01 10:38 ` [PATCH 05/20] drm: add proper return value for drm_mode_crtc_set_gamma_size Sascha Hauer
2012-02-01 10:38 ` [PATCH 06/20] drm fb helper: use drm_helper_connector_dpms to do dpms Sascha Hauer
2012-02-01 10:38 ` [PATCH 07/20] drm fb helper: remove unused variable conn_limit Sascha Hauer
2012-02-01 10:38 ` [PATCH 08/20] drm fb helper: remove unused variable crtc_id Sascha Hauer
2012-02-01 10:38 ` [PATCH 09/20] drm fb_helper: use lists for crtcs Sascha Hauer
2012-02-03 10:04 ` Dave Airlie
2012-02-04 10:47 ` Sascha Hauer
2012-02-04 11:21 ` Dave Airlie
2012-02-06 11:08 ` Sascha Hauer
2012-02-01 10:38 ` [PATCH 10/20] drm: remove now unused crtc_count parameter from drm_fb_helper_init Sascha Hauer
2012-02-01 10:38 ` [PATCH 11/20] drm fb helper: add the connectors inside drm_fb_helper_initial_config Sascha Hauer
2012-02-01 10:38 ` [PATCH 12/20] drm crtc_helper: use list_for_each_entry Sascha Hauer
2012-02-01 10:38 ` [PATCH 13/20] drm crtc: Fix locking comments Sascha Hauer
2012-02-01 10:38 ` [PATCH 14/20] drm: add convenience function to create an enum property Sascha Hauer
2012-02-01 11:48 ` Chris Wilson [this message]
2012-02-01 11:53 ` Sascha Hauer
2012-02-01 12:55 ` David Airlie
2012-02-01 13:05 ` Sascha Hauer
2012-02-01 14:00 ` Daniel Vetter
2012-02-03 10:08 ` Dave Airlie
2012-02-03 23:40 ` Sascha Hauer
2012-02-01 10:38 ` [PATCH 15/20] drm: add convenience function to create an range property Sascha Hauer
2012-02-01 11:34 ` Chris Wilson
2012-02-01 10:38 ` [PATCH 16/20] drm: store connector properties in list Sascha Hauer
2012-02-01 10:38 ` [PATCH 17/20] drm: remove checks for same value in set_prop Sascha Hauer
2012-02-01 11:55 ` Chris Wilson
2012-02-01 12:13 ` Sascha Hauer
2012-02-01 12:23 ` Chris Wilson
2012-02-01 10:38 ` [PATCH 18/20] drm: do not call drm_connector_property_set_value from drivers Sascha Hauer
2012-02-01 10:38 ` [PATCH 19/20] drm exynos: use drm_fb_helper_set_par directly Sascha Hauer
2012-02-02 2:25 ` Inki Dae
2012-02-01 10:38 ` [PATCH 20/20] drm: do not set fb_info->pixmap fields Sascha Hauer
2012-02-01 12:00 ` Chris Wilson
2012-02-02 14:13 ` [PATCH] drm cleanup patches Sascha Hauer
2012-02-03 10:21 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$3hhgph@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.