From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] Add intel_panel_fitter tool Date: Fri, 03 Feb 2012 19:12:47 +0000 Message-ID: References: <1328281766-15792-1-git-send-email-przanoni@gmail.com> <4F2C29D6.2000804@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id B9A3E9E75E for ; Fri, 3 Feb 2012 11:12:51 -0800 (PST) In-Reply-To: <4F2C29D6.2000804@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky , Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 03 Feb 2012 10:39:18 -0800, Ben Widawsky wrote: > On 02/03/12 08:44, Paulo Zanoni wrote: > > 2012/2/3 Chris Wilson: > >> I don't this should an installable tool for use by end-users. Direct > >> register access from userspace to registers that the driver owns? I'm > >> wary of installing even root-only tools that can screw us over in > >> unpredictable ways. > >> -Chris > > > > My idea is to write a patch that adds kernel peroperties to solve > > this, but while people still don't have kernel 3.4, the tool would be > > useful. > > > > If adding this tool to i-g-t is not a good idea, that's fine too: I > > still plan to write the kernel patches, so people wanting overscan > > compensation will have to use the kernel patch instead of the tool. > > I didn't read that email from Chris as don't add it. I read it as, > don't have it installed if they do make install or something. So I > think he should clarify himself. If this benefits end users now - I'm > all for it. As Ben said, I meant that I view this a debug/development tool and not the final end-user solution. I think it is useful to distribute such tools in i-g-t so that we can have testers, but I don't want it packaged by distributions and used as the preferred/correct mode of operation. -Chris -- Chris Wilson, Intel Open Source Technology Centre