From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: catch gtfifo errors on forcewake_put Date: Fri, 03 Feb 2012 23:10:09 +0000 Message-ID: References: <1328308301-28304-1-git-send-email-ben@bwidawsk.net> <1328308301-28304-2-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id DAAD69E81E for ; Fri, 3 Feb 2012 15:10:22 -0800 (PST) In-Reply-To: <1328308301-28304-2-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, 3 Feb 2012 14:31:41 -0800, Ben Widawsky wrote: > This is similar to a patch I wrote several months ago. It's been updated > for the new FORCEWAKE_MT, and it also no longer clears the debug > register as it may be helpful to get that for the error state. Also > recommended by Chris Wilson, use WARN() instead of DRM_ERROR, so we can > get a backtrace. > > Signed-off-by: Ben Widawsky Can we use the read of GTFIFODBG in place of the POSTING_READ? And do we really need to watch all the GTFIFODBG reads in the trace, or can I squelch that noise with a I915_READ_NOTRACE? -Chris -- Chris Wilson, Intel Open Source Technology Centre