From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] uxa/glamor: Refine CloseScreen and InitScreen process. Date: Wed, 08 Feb 2012 09:12:13 +0000 Message-ID: References: <1328096848-20599-1-git-send-email-zhigang.gong@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 89F759F751 for ; Wed, 8 Feb 2012 01:12:19 -0800 (PST) In-Reply-To: <1328096848-20599-1-git-send-email-zhigang.gong@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: zhigang.gong@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 1 Feb 2012 19:47:28 +0800, zhigang.gong@linux.intel.com wrote: > From: Zhigang Gong > > The previous version calls glamor_egl_close_screen and > glamor_egl_free_screen manually which is not align with > standard process. Now glamor change the way to follow > standard method: > > glamor layer and glamor egl layer both have their internal > CloseScreens. The correct sequence is after the I830CloseScreen > is registered, then register glamor_egl_close_screen and > the last one is glamor_close_screen. So we move out the > intel_glamor_init from the intel_uxa_init to I830ScreenInit > and just after the registration of I830CloseScreen. > > As the glamor interfaces changed, we need to check the > glamor version when load the glamor egl module to make > sure we are loading the right glamor module. If > failed, it will switch back to UXA path. > > Signed-off-by: Zhigang Gong I added the note about the glamor commit to this and the following patch and pushed. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre