From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 1/2] intel: Add support for overriding the
	PCI ID via an environment variable
Date: Tue, 21 Feb 2012 21:11:07 +0000
Message-ID: <e39f63$3pubsr@fmsmga002.fm.intel.com>
References: <1329857978-30626-1-git-send-email-kenneth@whitecape.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id F27029E755
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 21 Feb 2012 13:11:18 -0800 (PST)
In-Reply-To: <1329857978-30626-1-git-send-email-kenneth@whitecape.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Kenneth Graunke <kenneth@whitecape.org>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 21 Feb 2012 12:59:37 -0800, Kenneth Graunke <kenneth@whitecape.org> wrote:
> @@ -1828,6 +1829,9 @@ drm_intel_gem_bo_mrb_exec2(drm_intel_bo *bo, int used,
>  	execbuf.rsvd1 = 0;
>  	execbuf.rsvd2 = 0;
>  
> +	if (getenv("INTEL_DEVID_OVERRIDE"))
> +		goto skip_execution;

I'm not thrilled about calling getenv() for every execbuffer. And what
about the original execbuffer path?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre