From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: use the new hdmi_force_audio enum more Date: Thu, 23 Feb 2012 16:34:46 +0000 Message-ID: References: <1330013687-7666-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 92E5DA10D8 for ; Thu, 23 Feb 2012 08:34:53 -0800 (PST) In-Reply-To: <1330013687-7666-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter , Wu Fengguang List-Id: intel-gfx@lists.freedesktop.org On Thu, 23 Feb 2012 17:14:47 +0100, Daniel Vetter wrote: > While fixing up a merge conflict with drm-next I've noticed that we > use the same audio drm connector property also for dp and sdvo > outputs. > > So put the new enum to some good use and convert these paths, too. The > HDMI_AUDIO_ prefix is a bit a misnomer. But at least for sdvo it makes > sense (and you can also connect a hdmi monitor with a dp->hdmi cable), > so I've decided to stick with it. > > Cc: Wu Fengguang > Signed-Off-by: Daniel Vetter Review fail, I should have picked that up earlier. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre