From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm: Add locking to resume_force_mode to prevent multiple Date: Thu, 22 Mar 2012 22:57:15 +0000 Message-ID: References: <1332455155-16385-1-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 97DA99E791 for ; Thu, 22 Mar 2012 15:57:19 -0700 (PDT) In-Reply-To: <1332455155-16385-1-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Sean Paul , dri-devel@lists.freedesktop.org, airlied@linux.ie List-Id: dri-devel@lists.freedesktop.org On Thu, 22 Mar 2012 18:25:55 -0400, Sean Paul wrote: > Add a mutex to protect resume_force_mode from being called multiple > times. This fixes a bug observed on SNB where two wake sources call > resume_force_mode and the FDI training fails as a result. The user > facing result of this is complete screen corruption. Looks like a bug in i915_drv.c for calling that function without holding the mode_config.lock -Chris -- Chris Wilson, Intel Open Source Technology Centre