Re: [PATCH 2/2] drm/i915: provide module parameter description

[Chris Wilson <chris@chris-wilson.co.uk>]

On Wed,  6 Jul 2011 15:14:53 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> 
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
>  drivers/gpu/drm/i915/i915_drv.c |   23 +++++++++++++++++++++++
>  1 files changed, 23 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index f5ef954..feac0f9 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -39,39 +39,62 @@
>  
>  static int i915_modeset __read_mostly = -1;
>  module_param_named(modeset, i915_modeset, int, 0400);
> +MODULE_PARM_DESC(modeset, "Use kernel modesetting (KMS) "
> +			  "(0=use DRM_I915_KMS from .config, "
> +			  "1=on, "
> +			  "-1=force vga console preference (default))");

I find this alignment slightly odd, and it is disadvantageous later where
it forces a string across two lines that could just be one. Can you try
aligning the start of the description with the bracket on a new line?
i.e. set cino=:0,(0
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre