From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: provide module parameter description Date: Thu, 07 Jul 2011 06:58:44 +0100 Message-ID: References: <1309990493-27160-1-git-send-email-ben@bwidawsk.net> <1309990493-27160-2-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FB6F9E8DC for ; Wed, 6 Jul 2011 22:58:48 -0700 (PDT) In-Reply-To: <1309990493-27160-2-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky , intel-gfx@lists.freedesktop.org Cc: Julien Cristau List-Id: intel-gfx@lists.freedesktop.org On Wed, 6 Jul 2011 15:14:53 -0700, Ben Widawsky wrote: > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_drv.c | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index f5ef954..feac0f9 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -39,39 +39,62 @@ > > static int i915_modeset __read_mostly = -1; > module_param_named(modeset, i915_modeset, int, 0400); > +MODULE_PARM_DESC(modeset, "Use kernel modesetting (KMS) " > + "(0=use DRM_I915_KMS from .config, " > + "1=on, " > + "-1=force vga console preference (default))"); I find this alignment slightly odd, and it is disadvantageous later where it forces a string across two lines that could just be one. Can you try aligning the start of the description with the bracket on a new line? i.e. set cino=:0,(0 -Chris -- Chris Wilson, Intel Open Source Technology Centre