From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [Mesa-dev] [PATCH 04/10] i965: setup system routine Date: Wed, 13 Jul 2011 22:04:43 +0100 Message-ID: References: <1310590312-21669-1-git-send-email-ben@bwidawsk.net> <1310590312-21669-5-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1310590312-21669-5-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: mesa-dev@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, 13 Jul 2011 13:51:46 -0700, Ben Widawsky wrote: > Upload the system routine as part of the invariant state if debugging. > > Remove SIP setting if not debugging to make it more friendly for others > that may be debugging shaders or media kernels. > > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_misc_state.c | 13 +++++++++---- > 1 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c > index bc8ef78..139c190 100644 > --- a/src/mesa/drivers/dri/i965/brw_misc_state.c > +++ b/src/mesa/drivers/dri/i965/brw_misc_state.c > @@ -652,10 +652,15 @@ static void upload_invarient_state( struct brw_context *brw ) > } > } > > - BEGIN_BATCH(2); > - OUT_BATCH(CMD_STATE_SIP << 16 | (2 - 2)); > - OUT_BATCH(0); > - ADVANCE_BATCH(); > + /* The system routine must be set after a change to Instruction base */ > + if (brw->wm.debugging) { > + assert(brw->wm.sip_offset != 0); > + /* assert instruction base == 0 */ Kill or correct the misleading comment. -Chris -- Chris Wilson, Intel Open Source Technology Centre