From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 0/3] RFC: Common functions for GEM offset creation Date: Tue, 19 Jul 2011 10:33:35 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E73279E822 for ; Tue, 19 Jul 2011 02:33:37 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: Rob Clark List-Id: dri-devel@lists.freedesktop.org On Mon, 18 Jul 2011 19:20:56 -0500, Rob Clark wrote: > In the process of adding GEM support for OMAP DRM driver, I noticed that > I was adding code for creating/freeing mmap offsets which was virtually > identical to what was already duplicated in i915 and gma500 drivers. > > Rather than duplicating the code a 3rd time, it seemed like a good idea > to move it to the GEM core. > > Note that I don't actually have a way to test psb or i915, but the > changes seem straightforward enough. My only concern is that for the common functions the mmap_offset to create should be passed in a parameter, so that we could support more than one mapping for an object. -Chris -- Chris Wilson, Intel Open Source Technology Centre