From: maitreye@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, robdclark@gmail.com,
seanpaul@chromium.org, nganji@codeaurora.org,
aravindh@codeaurora.org, khsieh@codeaurora.org,
abhinavk@codeaurora.org
Subject: Re: [PATCH v5] drm/msm/dp: add logs across DP driver for ease of debugging
Date: Mon, 26 Jul 2021 17:39:48 -0700 [thread overview]
Message-ID: <e3a560813463d54d35d8f381e35f4ea9@codeaurora.org> (raw)
In-Reply-To: <CAE-0n50gGT8nfQ0KEnCG=g2DiQdCPpQZsFOVB_8iROmHXXjNFg@mail.gmail.com>
Thank you Stephen for reviewing.
On 2021-07-26 14:31, Stephen Boyd wrote:
> Quoting maitreye (2021-07-26 10:36:26)
>> @@ -509,6 +515,7 @@ static int dp_display_usbpd_attention_cb(struct
>> device *dev)
>> DRM_ERROR("invalid dev\n");
>> return -EINVAL;
>> }
>> + DRM_DEBUG_DP("sink_request: %d\n", sink_request);
>
> This one is bad. sink_request isn't assigned yet.
>
Yes, thank you will fix it
>>
>> dp = container_of(g_dp_display,
>> struct dp_display_private, dp_display);
>> @@ -523,6 +530,7 @@ static int dp_display_usbpd_attention_cb(struct
>> device *dev)
>> rc = dp_link_process_request(dp->link);
>> if (!rc) {
>> sink_request = dp->link->sink_request;
>> + DRM_DEBUG_DP("hpd_state=%d sink_count=%d\n",
>> dp->hpd_state, sink_request);
>
> Should that say sink_request?
>
Yes will fix this
>> if (sink_request & DS_PORT_STATUS_CHANGED)
>> rc =
>> dp_display_handle_port_ststus_changed(dp);
>> else
WARNING: multiple messages have this Message-ID (diff)
From: maitreye@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
khsieh@codeaurora.org, seanpaul@chromium.org,
abhinavk@codeaurora.org, aravindh@codeaurora.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v5] drm/msm/dp: add logs across DP driver for ease of debugging
Date: Mon, 26 Jul 2021 17:39:48 -0700 [thread overview]
Message-ID: <e3a560813463d54d35d8f381e35f4ea9@codeaurora.org> (raw)
In-Reply-To: <CAE-0n50gGT8nfQ0KEnCG=g2DiQdCPpQZsFOVB_8iROmHXXjNFg@mail.gmail.com>
Thank you Stephen for reviewing.
On 2021-07-26 14:31, Stephen Boyd wrote:
> Quoting maitreye (2021-07-26 10:36:26)
>> @@ -509,6 +515,7 @@ static int dp_display_usbpd_attention_cb(struct
>> device *dev)
>> DRM_ERROR("invalid dev\n");
>> return -EINVAL;
>> }
>> + DRM_DEBUG_DP("sink_request: %d\n", sink_request);
>
> This one is bad. sink_request isn't assigned yet.
>
Yes, thank you will fix it
>>
>> dp = container_of(g_dp_display,
>> struct dp_display_private, dp_display);
>> @@ -523,6 +530,7 @@ static int dp_display_usbpd_attention_cb(struct
>> device *dev)
>> rc = dp_link_process_request(dp->link);
>> if (!rc) {
>> sink_request = dp->link->sink_request;
>> + DRM_DEBUG_DP("hpd_state=%d sink_count=%d\n",
>> dp->hpd_state, sink_request);
>
> Should that say sink_request?
>
Yes will fix this
>> if (sink_request & DS_PORT_STATUS_CHANGED)
>> rc =
>> dp_display_handle_port_ststus_changed(dp);
>> else
next prev parent reply other threads:[~2021-07-27 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 17:36 [PATCH v5] drm/msm/dp: add logs across DP driver for ease of debugging maitreye
2021-07-26 17:36 ` maitreye
2021-07-26 21:00 ` Stephen Boyd
2021-07-26 21:00 ` Stephen Boyd
2021-07-26 21:31 ` Stephen Boyd
2021-07-26 21:31 ` Stephen Boyd
2021-07-27 0:39 ` maitreye [this message]
2021-07-27 0:39 ` maitreye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3a560813463d54d35d8f381e35f4ea9@codeaurora.org \
--to=maitreye@codeaurora.org \
--cc=abhinavk@codeaurora.org \
--cc=aravindh@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=nganji@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.