Re: [PATCH 06/10] arm64: dts: st: add stm32mp235f-dk board support

[Amelie Delaunay <amelie.delaunay@foss.st.com>]

On 2/13/25 10:03, Krzysztof Kozlowski wrote:
> On Mon, Feb 10, 2025 at 04:21:00PM +0100, Amelie Delaunay wrote:
>> Add STM32MP235F Discovery Kit board support. It embeds a STM32MP235FAK
>> SoC, with 4GB of LPDDR4, 2*USB typeA, 1*USB3 typeC, 1*ETH, wifi/BT
>> combo, DSI HDMI, LVDS connector ...
>>
>> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
>> ---
>>   arch/arm64/boot/dts/st/Makefile           |   1 +
>>   arch/arm64/boot/dts/st/stm32mp235f-dk.dts | 115 ++++++++++++++++++++++++++++++
>>   2 files changed, 116 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/st/Makefile b/arch/arm64/boot/dts/st/Makefile
>> index 0cc12f2b1dfeea6510793ea26f599f767df77749..06364152206997863d0991c25589de73c63494fb 100644
>> --- a/arch/arm64/boot/dts/st/Makefile
>> +++ b/arch/arm64/boot/dts/st/Makefile
>> @@ -1,4 +1,5 @@
>>   # SPDX-License-Identifier: GPL-2.0-only
>>   dtb-$(CONFIG_ARCH_STM32) += \
>> +	stm32mp235f-dk.dtb \
>>   	stm32mp257f-dk.dtb \
>>   	stm32mp257f-ev1.dtb
>> diff --git a/arch/arm64/boot/dts/st/stm32mp235f-dk.dts b/arch/arm64/boot/dts/st/stm32mp235f-dk.dts
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..08e330d310749506c5b0e7a1fb2f80dfa134400a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/st/stm32mp235f-dk.dts
>> @@ -0,0 +1,115 @@
>> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
>> +/*
>> + * Copyright (C) STMicroelectronics 2025 - All Rights Reserved
>> + * Author: Amelie Delaunay <amelie.delaunay@foss.st.com> for STMicroelectronics.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/input/input.h>
>> +#include <dt-bindings/leds/common.h>
>> +#include "stm32mp235.dtsi"
>> +#include "stm32mp23xf.dtsi"
>> +#include "stm32mp25-pinctrl.dtsi"
>> +#include "stm32mp25xxak-pinctrl.dtsi"
>> +
>> +/ {
>> +	model = "STMicroelectronics STM32MP235F-DK Discovery Board";
>> +	compatible = "st,stm32mp235f-dk", "st,stm32mp235";
>> +
>> +	aliases {
>> +		serial0 = &usart2;
>> +	};
>> +
>> +	chosen {
>> +		stdout-path = "serial0:115200n8";
>> +	};
>> +
>> +	gpio-keys {
>> +		compatible = "gpio-keys";
>> +
>> +		button-user-1 {
>> +			label = "User-1";
>> +			linux,code = <BTN_1>;
>> +			gpios = <&gpioc 5 GPIO_ACTIVE_HIGH>;
>> +			status = "okay";
> 
> Where is it disabled?
> 
>> +		};
>> +
>> +		button-user-2 {
>> +			label = "User-2";
>> +			linux,code = <BTN_2>;
>> +			gpios = <&gpioc 11 GPIO_ACTIVE_HIGH>;
>> +			status = "okay";
> 
> Same question
> 
>> +		};
>> +	};
> 
> Best regards,
> Krzysztof
> 

Will drop status property.

Regards,
Amelie