From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF0AC77B6E for ; Fri, 7 Apr 2023 07:54:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232753AbjDGHyj (ORCPT ); Fri, 7 Apr 2023 03:54:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230265AbjDGHyh (ORCPT ); Fri, 7 Apr 2023 03:54:37 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A77A06E82; Fri, 7 Apr 2023 00:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1680854076; x=1712390076; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=CZ/jCUb4kYCui3C/8u1ZqszGrltmw8qxX+93UuaVuMU=; b=aJ6Dk3zNtcdKOQnR2wEyMH0dmJpqduCM3Fie0NX6MGZsh5qscUNlQ1Ah XyQtS/kh09UdRoQ31OYkIs/LNDYv4pIhX1VGhFcYiJ2L8Rs1lSFyRA/1e pyu/qLRxy1dP2r7hCkg4YzcLgrFV6MF1btBo+NxS5flMQ/B6s2usbjS3E mgaQamO3HsOveNoelUd8wYqPJYkn1RIHxboh/94BCmozV8VkKvT4cEWva nC2fBRL1dkWZaVyAYMkkGrHYoBW3V0jkwqOfZyKVZyMGnjDUr4rTjN9K5 2nJEvrDi96IwOFx01AA+vwFWd3MeuekCfwLy6E9rPlMeiuxDPKFLh7T5n A==; X-IronPort-AV: E=Sophos;i="5.98,326,1673938800"; d="scan'208";a="208137635" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 07 Apr 2023 00:54:35 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 7 Apr 2023 00:54:35 -0700 Received: from [10.159.245.112] (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Fri, 7 Apr 2023 00:54:33 -0700 Message-ID: Date: Fri, 7 Apr 2023 09:54:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] spi: atmel: Improve exception handling in atmel_spi_configure_dma() To: Markus Elfring , , , , Alexandre Belloni , Claudiu Beznea , Mark Brown , "Tudor Ambarus" , Yang Yingliang CC: , LKML References: <8f785de5-ebe2-edd9-2155-f440acacc643@web.de> <82aebf6c-47ac-9d17-2d11-6245f582338e@web.de> Content-Language: en-US From: Nicolas Ferre Organization: microchip In-Reply-To: <82aebf6c-47ac-9d17-2d11-6245f582338e@web.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 07/04/2023 at 08:22, Markus Elfring wrote: > Date: Fri, 7 Apr 2023 08:08:59 +0200 > > The label “error” was used to jump to another pointer check despite of > the detail in the implementation of the function “atmel_spi_configure_dma” > that it was determined already that the corresponding variable > contained an error pointer because of a failed call of > the function “dma_request_chan”. > > * Thus use more appropriate labels instead. > > * Delete two redundant checks. > > > This issue was detected by using the Coccinelle software. > > Fixes: 398b6b310ec85eef9d98df5963d5ded18aa92ad8 ("spi: atmel: switch to use modern name") > Signed-off-by: Markus Elfring It's becoming a pattern, but still: NACK. Regards, Nicolas > --- > drivers/spi/spi-atmel.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 7f06305e16cb..ed8dc93c73e5 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -511,12 +511,12 @@ static int atmel_spi_configure_dma(struct spi_controller *host, > * requested tx channel. > */ > dev_dbg(dev, "No RX DMA channel, DMA is disabled\n"); > - goto error; > + goto release_channel_tx; > } > > err = atmel_spi_dma_slave_config(as, 8); > if (err) > - goto error; > + goto release_channel_rx; > > dev_info(&as->pdev->dev, > "Using %s (tx) and %s (rx) for DMA transfers\n", > @@ -524,11 +524,11 @@ static int atmel_spi_configure_dma(struct spi_controller *host, > dma_chan_name(host->dma_rx)); > > return 0; > -error: > - if (!IS_ERR(host->dma_rx)) > - dma_release_channel(host->dma_rx); > - if (!IS_ERR(host->dma_tx)) > - dma_release_channel(host->dma_tx); > + > +release_channel_rx: > + dma_release_channel(host->dma_rx); > +release_channel_tx: > + dma_release_channel(host->dma_tx); > error_clear: > host->dma_tx = host->dma_rx = NULL; > return err; > -- > 2.40.0 > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 202BBC6FD1D for ; Fri, 7 Apr 2023 07:55:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E2YcUfiWhDRp+wHW5ajYjji6IBYyPtkgkbVvvbIvHXA=; b=pV1DbCY/z+6xPl 4MnuZSaAQj7DyYdXiaN31gjyMIE17VWsle8RgzGGQVRLrmT/KH4sESxt73AL36nZFqKW9cY2gzxQw yeJ/DIkl8R+k/70BV2UIHHd4txFooBPUyGdM5GcBV/ja3ZTNKUmCsvVUwJ6Y+lzAb28MkKUKhMuzb gOEXx81dijcNSKRzc8K++simsAVbE9NTTiJBWVP1WKepMqNoXzKJeTF4vn+iLKhVOKZPQBV5LdUok DptjJ1oHzS//JbvJQi7yYDbljbq9f/1yv28VMzRa0zRUNZWde3BfHonRtiu5VLHwPSeBh0bHiFcSh EtdtGozmbBiwjtycGwtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkgvi-009QIW-2Y; Fri, 07 Apr 2023 07:54:42 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkgve-009QGY-2u for linux-arm-kernel@lists.infradead.org; Fri, 07 Apr 2023 07:54:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1680854078; x=1712390078; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=CZ/jCUb4kYCui3C/8u1ZqszGrltmw8qxX+93UuaVuMU=; b=Ptk/IodpM8AyaKVx83WCRmsUWbrPDBX3GTMSh3Q1BYiST2TzyQa0FZcS HvzLlHTO5QEjcUu5EOtq7Xg4Cc0mHpMfyZ096FtbKF/WvHRxERQ8rJuaI DU6iYxtoICeKWiZbe883YIXQZFnlFvR6q7bCuM3Wv70U/vnoAe7Ri78RM WG/GaDSXYuUV1kLXsCCP0TlWQJ29aHKiGKcHkWIaxnVVplt+veVxvNVJw dzvhQUixHNQVfrPfBNH0Ugf8KasxlJmv5/X0YV7POjxSfrDnEkvhT286T LOPUMIDMRSRjMP7QPy0RY+6CR4tSpz1F5vlXXqKJlyil9jBiyp+f3EO62 A==; X-IronPort-AV: E=Sophos;i="5.98,326,1673938800"; d="scan'208";a="208137635" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 07 Apr 2023 00:54:35 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 7 Apr 2023 00:54:35 -0700 Received: from [10.159.245.112] (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Fri, 7 Apr 2023 00:54:33 -0700 Message-ID: Date: Fri, 7 Apr 2023 09:54:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] spi: atmel: Improve exception handling in atmel_spi_configure_dma() To: Markus Elfring , , , , Alexandre Belloni , Claudiu Beznea , Mark Brown , "Tudor Ambarus" , Yang Yingliang CC: , LKML References: <8f785de5-ebe2-edd9-2155-f440acacc643@web.de> <82aebf6c-47ac-9d17-2d11-6245f582338e@web.de> Content-Language: en-US From: Nicolas Ferre Organization: microchip In-Reply-To: <82aebf6c-47ac-9d17-2d11-6245f582338e@web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230407_005438_991905_B8875430 X-CRM114-Status: GOOD ( 19.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDcvMDQvMjAyMyBhdCAwODoyMiwgTWFya3VzIEVsZnJpbmcgd3JvdGU6Cj4gRGF0ZTogRnJp LCA3IEFwciAyMDIzIDA4OjA4OjU5ICswMjAwCj4gCj4gVGhlIGxhYmVsIOKAnGVycm9y4oCdIHdh cyB1c2VkIHRvIGp1bXAgdG8gYW5vdGhlciBwb2ludGVyIGNoZWNrIGRlc3BpdGUgb2YKPiB0aGUg ZGV0YWlsIGluIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgZnVuY3Rpb24g4oCcYXRtZWxfc3Bp X2NvbmZpZ3VyZV9kbWHigJ0KPiB0aGF0IGl0IHdhcyBkZXRlcm1pbmVkIGFscmVhZHkgdGhhdCB0 aGUgY29ycmVzcG9uZGluZyB2YXJpYWJsZQo+IGNvbnRhaW5lZCBhbiBlcnJvciBwb2ludGVyIGJl Y2F1c2Ugb2YgYSBmYWlsZWQgY2FsbCBvZgo+IHRoZSBmdW5jdGlvbiDigJxkbWFfcmVxdWVzdF9j aGFu4oCdLgo+IAo+ICogVGh1cyB1c2UgbW9yZSBhcHByb3ByaWF0ZSBsYWJlbHMgaW5zdGVhZC4K PiAKPiAqIERlbGV0ZSB0d28gcmVkdW5kYW50IGNoZWNrcy4KPiAKPiAKPiBUaGlzIGlzc3VlIHdh cyBkZXRlY3RlZCBieSB1c2luZyB0aGUgQ29jY2luZWxsZSBzb2Z0d2FyZS4KPiAKPiBGaXhlczog Mzk4YjZiMzEwZWM4NWVlZjlkOThkZjU5NjNkNWRlZDE4YWE5MmFkOCAoInNwaTogYXRtZWw6IHN3 aXRjaCB0byB1c2UgbW9kZXJuIG5hbWUiKQo+IFNpZ25lZC1vZmYtYnk6IE1hcmt1cyBFbGZyaW5n IDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4KCkl0J3MgYmVjb21pbmcgYSBwYXR0ZXJu LCBidXQgc3RpbGw6Ck5BQ0suCgpSZWdhcmRzLAogICBOaWNvbGFzCgo+IC0tLQo+ICAgZHJpdmVy cy9zcGkvc3BpLWF0bWVsLmMgfCAxNCArKysrKysrLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQs IDcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9zcGkvc3BpLWF0bWVsLmMgYi9kcml2ZXJzL3NwaS9zcGktYXRtZWwuYwo+IGluZGV4IDdmMDYz MDVlMTZjYi4uZWQ4ZGM5M2M3M2U1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvc3BpL3NwaS1hdG1l bC5jCj4gKysrIGIvZHJpdmVycy9zcGkvc3BpLWF0bWVsLmMKPiBAQCAtNTExLDEyICs1MTEsMTIg QEAgc3RhdGljIGludCBhdG1lbF9zcGlfY29uZmlndXJlX2RtYShzdHJ1Y3Qgc3BpX2NvbnRyb2xs ZXIgKmhvc3QsCj4gICAgICAgICAgICAgICAgICAgKiByZXF1ZXN0ZWQgdHggY2hhbm5lbC4KPiAg ICAgICAgICAgICAgICAgICAqLwo+ICAgICAgICAgICAgICAgICAgZGV2X2RiZyhkZXYsICJObyBS WCBETUEgY2hhbm5lbCwgRE1BIGlzIGRpc2FibGVkXG4iKTsKPiAtICAgICAgICAgICAgICAgZ290 byBlcnJvcjsKPiArICAgICAgICAgICAgICAgZ290byByZWxlYXNlX2NoYW5uZWxfdHg7Cj4gICAg ICAgICAgfQo+IAo+ICAgICAgICAgIGVyciA9IGF0bWVsX3NwaV9kbWFfc2xhdmVfY29uZmlnKGFz LCA4KTsKPiAgICAgICAgICBpZiAoZXJyKQo+IC0gICAgICAgICAgICAgICBnb3RvIGVycm9yOwo+ ICsgICAgICAgICAgICAgICBnb3RvIHJlbGVhc2VfY2hhbm5lbF9yeDsKPiAKPiAgICAgICAgICBk ZXZfaW5mbygmYXMtPnBkZXYtPmRldiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgIlVzaW5n ICVzICh0eCkgYW5kICVzIChyeCkgZm9yIERNQSB0cmFuc2ZlcnNcbiIsCj4gQEAgLTUyNCwxMSAr NTI0LDExIEBAIHN0YXRpYyBpbnQgYXRtZWxfc3BpX2NvbmZpZ3VyZV9kbWEoc3RydWN0IHNwaV9j b250cm9sbGVyICpob3N0LAo+ICAgICAgICAgICAgICAgICAgICAgICAgICBkbWFfY2hhbl9uYW1l KGhvc3QtPmRtYV9yeCkpOwo+IAo+ICAgICAgICAgIHJldHVybiAwOwo+IC1lcnJvcjoKPiAtICAg ICAgIGlmICghSVNfRVJSKGhvc3QtPmRtYV9yeCkpCj4gLSAgICAgICAgICAgICAgIGRtYV9yZWxl YXNlX2NoYW5uZWwoaG9zdC0+ZG1hX3J4KTsKPiAtICAgICAgIGlmICghSVNfRVJSKGhvc3QtPmRt YV90eCkpCj4gLSAgICAgICAgICAgICAgIGRtYV9yZWxlYXNlX2NoYW5uZWwoaG9zdC0+ZG1hX3R4 KTsKPiArCj4gK3JlbGVhc2VfY2hhbm5lbF9yeDoKPiArICAgICAgIGRtYV9yZWxlYXNlX2NoYW5u ZWwoaG9zdC0+ZG1hX3J4KTsKPiArcmVsZWFzZV9jaGFubmVsX3R4Ogo+ICsgICAgICAgZG1hX3Jl bGVhc2VfY2hhbm5lbChob3N0LT5kbWFfdHgpOwo+ICAgZXJyb3JfY2xlYXI6Cj4gICAgICAgICAg aG9zdC0+ZG1hX3R4ID0gaG9zdC0+ZG1hX3J4ID0gTlVMTDsKPiAgICAgICAgICByZXR1cm4gZXJy Owo+IC0tCj4gMi40MC4wCj4gCgotLSAKTmljb2xhcyBGZXJyZQoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK