From: JP Kobryn <jp.kobryn@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
mikeba@sentinelone.com, Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Shuah Khan <shuah@kernel.org>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC bpf-next 0/2] bpf: Do not let preemption cause false recursion drops in trampoline progs
Date: Tue, 3 Nov 2026 15:46:27 -0800 [thread overview]
Message-ID: <e3f63654-0f7c-462b-b58d-05f3164fe340@linux.dev> (raw)
In-Reply-To: <DMIIV9CE0PN4.309YUGIXQUZNF@gmail.com>
On 10/30/26 3:22 PM, Alexei Starovoitov wrote:
> On Sun, Oct 25, 2026 at 04:02 AM Mike Bazov via B4 Relay <devnull+mikeba.sentinelone.com@kernel.org> wrote:
>
>> Is disabling preemption in __bpf_prog_enter_recur() on !PREEMPT_RT the
>> preferred fix for fentry/fexit, or would you prefer a different
>> mechanism for reconciling preemptible execution with prog->active and
>> the per-CPU private stack?
>
> No.
> We cannot disable preemption, since progs are not short
> with may_goto they can take 1/4 sec.
Seeing this issue as well. This patch opts in ALL non-sleepable programs
with trampolines. Alexei, would your thoughts be the same if there was
an opt-in approach, like a libbpf annotation "fentry.nonpreempt", for
select programs? A patch like this could then check if
program->nonpreempt is set.
next prev parent reply other threads:[~2026-11-03 23:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 11:02 [PATCH RFC bpf-next 0/2] bpf: Do not let preemption cause false recursion drops in trampoline progs Mike Bazov via B4 Relay
2026-10-25 11:02 ` Mike Bazov
2026-10-25 11:02 ` [PATCH RFC bpf-next 1/2] bpf: Keep recursion-checked trampoline programs non-preemptible on !PREEMPT_RT Mike Bazov via B4 Relay
2026-10-25 11:02 ` Mike Bazov
2026-10-25 11:38 ` sashiko-bot
2026-10-25 11:02 ` [PATCH RFC bpf-next 2/2] selftests/bpf: Add trampoline preemption false-recursion test Mike Bazov via B4 Relay
2026-10-25 11:02 ` Mike Bazov
2026-10-30 22:22 ` [PATCH RFC bpf-next 0/2] bpf: Do not let preemption cause false recursion drops in trampoline progs Alexei Starovoitov
2026-11-02 23:24 ` [EXT.MSG] " Mike Bazov
2026-11-03 1:49 ` Alexei Starovoitov
2026-11-03 21:28 ` Mike Bazov
2026-11-04 2:20 ` Alexei Starovoitov
2026-11-05 1:12 ` Martin Kelly
2026-11-05 5:18 ` Alexei Starovoitov
2026-11-05 8:53 ` Peter Zijlstra
2026-11-05 20:16 ` Martin Kelly
2026-11-05 12:26 ` Peter Zijlstra
2026-11-05 20:44 ` Martin Kelly
2026-11-03 23:46 ` JP Kobryn [this message]
2026-11-04 2:21 ` Alexei Starovoitov
2026-11-05 0:12 ` [EXT.MSG] " Mike Bazov
2026-11-05 5:14 ` Alexei Starovoitov
2026-11-05 21:10 ` Martin Kelly
2026-11-05 23:35 ` Mike Bazov
2026-11-06 22:08 ` Andrii Nakryiko
2026-11-07 21:32 ` Mike Bazov
2026-11-10 0:12 ` JP Kobryn (CrowdStrike)
2026-11-10 20:43 ` Mike Bazov
2026-11-11 2:58 ` JP Kobryn (CrowdStrike)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3f63654-0f7c-462b-b58d-05f3164fe340@linux.dev \
--to=jp.kobryn@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mikeba@sentinelone.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.