From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Peter Chen <peter.chen@nxp.com>, mathias.nyman@intel.com
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
linux-imx@nxp.com, jun.li@nxp.com,
Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH 1/2] usb: host: add XHCI_CDNS_HOST flag
Date: Mon, 26 Oct 2020 17:02:06 +0200 [thread overview]
Message-ID: <e3f75fb0-8fab-357f-d3f4-ca122995166a@linux.intel.com> (raw)
In-Reply-To: <20201022030133.19528-1-peter.chen@nxp.com>
On 22.10.2020 6.01, Peter Chen wrote:
> The Cadence xHCI host has the same issue with Intel's,
> it is triggered by reboot stress test.
>
> Cc: Pawel Laszczak <pawell@cadence.com>
> Cc: Roger Quadros <rogerq@ti.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/usb/host/xhci.c | 2 +-
> drivers/usb/host/xhci.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 482fe8c5e3b4..fc72a03dc27f 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -193,7 +193,7 @@ int xhci_reset(struct xhci_hcd *xhci)
> * Without this delay, the subsequent HC register access,
> * may result in a system hang very rarely.
> */
> - if (xhci->quirks & XHCI_INTEL_HOST)
> + if (xhci->quirks & (XHCI_INTEL_HOST | XHCI_CDNS_HOST))
> udelay(1000);
>
> ret = xhci_handshake(&xhci->op_regs->command,
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index 8be88379c0fb..4b7275c73ea5 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1877,6 +1877,7 @@ struct xhci_hcd {
> #define XHCI_SNPS_BROKEN_SUSPEND BIT_ULL(35)
> #define XHCI_RENESAS_FW_QUIRK BIT_ULL(36)
> #define XHCI_SKIP_PHY_INIT BIT_ULL(37)
> +#define XHCI_CDNS_HOST BIT_ULL(38)
>
> unsigned int num_active_eps;
> unsigned int limit_active_eps;
>
Is the XHCI_CDNS_HOST quirk bit set in some other patchseries?
-Mathias
next prev parent reply other threads:[~2020-10-26 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 3:01 [PATCH 1/2] usb: host: add XHCI_CDNS_HOST flag Peter Chen
2020-10-22 3:01 ` [PATCH 2/2] usb: host: xhci-plat: forbid runtime pm conditionally Peter Chen
2020-10-22 6:48 ` [PATCH 1/2] usb: host: add XHCI_CDNS_HOST flag Roger Quadros
2020-10-22 7:17 ` Peter Chen
2020-10-26 15:02 ` Mathias Nyman [this message]
2020-10-27 1:50 ` Peter Chen
2020-10-27 8:33 ` Mathias Nyman
2020-10-27 9:50 ` Peter Chen
2020-10-28 7:02 ` Peter Chen
2020-10-30 23:14 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3f75fb0-8fab-357f-d3f4-ca122995166a@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.