From: Yang Li <yang.li@amlogic.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: bernd@kuhls.net, yann.morin.1998@free.fr, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/linux-firmware: change Amlogic Bluetooth binary path
Date: Wed, 10 Jul 2024 10:06:42 +0800 [thread overview]
Message-ID: <e411a89b-02cb-46a3-85de-b2e45550fd69@amlogic.com> (raw)
In-Reply-To: <20240709233246.4026b6f8@windsurf>
Dear Thomas
Thanks for your help.
On 2024/7/10 5:32, Thomas Petazzoni wrote:
> [????????? thomas.petazzoni@bootlin.com ????????? https://aka.ms/LearnAboutSenderIdentification?????????????]
>
> [ EXTERNAL EMAIL ]
>
> Hello Yang,
>
> Thanks for your patch, which I have applied, after doing some changes,
> see below.
>
> On Tue, 2 Jul 2024 20:17:37 +0800
> Yang Li <yang.li@amlogic.com> wrote:
>
>> remove bluetooth subdirectory, and use generic pattern aml_*
>> to install all bluetooth binary.
> This commit log was not sufficient. It does not explain since when the
> bluetooth/ directory has been removed. This information is absolutely
> *critical* as it allows us to figure out whether this fix needs to be
> backported or not to previous version of Buildroot. Therefore, I have
> changed the commit log to:
>
> package/linux-firmware: change Amlogic Bluetooth binary path
>
> Since upstream commit 7d931f8afa51d83e9eaee3a3f449bc2f86a5edf3, which
> first appeared in linux-firmware 20240709, the amlogic bluetooth
> firmware files have been moved from amlogic/bluetooth/ to directly
> amlogic/.
It's great!
>> # Amlogic SoC Bluetooth
>> ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)
>> -LINUX_FIRMWARE_FILES += amlogic/bluetooth/*.bin
>> +LINUX_FIRMWARE_FILES += amlogic/aml_*
> The change from *.bin to aml_* looked unnecessary. As far as I can see,
> all files still have a .bin extension, so this change looked
> gratuitous, and was not explained in the commit log. So I kept the
> *.bin for now. If needed a future commit can be made, with a proper
> explanation as to why aml_* is a better wildcard.
Well, It's all right with me.
Thanks again.
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-10 2:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 12:17 [Buildroot] [PATCH] package/linux-firmware: change Amlogic Bluetooth binary path Yang Li
2024-07-09 21:32 ` Thomas Petazzoni via buildroot
2024-07-10 2:06 ` Yang Li [this message]
2024-07-13 11:04 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2024-06-27 2:18 Yang Li
2024-06-19 8:10 Yang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e411a89b-02cb-46a3-85de-b2e45550fd69@amlogic.com \
--to=yang.li@amlogic.com \
--cc=bernd@kuhls.net \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.