All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Dongjiang Zhu <zhudongjiang@fnnas.com>, Qu Wenruo <wqu@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: add "rescue=usebackuproot" into forced read-only options
Date: Fri, 3 Jul 2026 12:49:38 +0930	[thread overview]
Message-ID: <e443ce41-2174-42b1-b005-d7df5e668a31@gmx.com> (raw)
In-Reply-To: <47c417e1-acf9-484c-a166-3787857c8f22@fnnas.com>



在 2026/7/3 12:03, Dongjiang Zhu 写道:
> 在 2026/7/3 7:40, Qu Wenruo 写道:
>> According to btrfs(5) man page, all rescue options should require an
>> read-only mount.
>>
>> But that read-only check is only introduced for newer rescue options,
>> not for the pre-existing "usebackuproot" one.
>>
>> Unify the behavior to match the document.
>> [...]
> 
> Hi Qu,
> 
> Just a small note from looking at this together with my CLEAR_CACHE patch.
> 
> If rescue=usebackuproot requires a read-only mount, my patch to set
> CLEAR_CACHE for it may no longer be needed.

Yes, this patchset is inspired by your patch.

> 
> Also, should rescue=all include usebackuproot too?

That's a good catch.

I'll add a patch to add that into the series.

Thanks,
Qu

> 
> Thanks,
> Dongjiang
> 


  reply	other threads:[~2026-07-03  3:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 23:40 [PATCH 0/2] btrfs: small changes to "usebackuproot" mount Qu Wenruo
2026-07-02 23:40 ` [PATCH 1/2] btrfs: add "rescue=usebackuproot" into forced read-only options Qu Wenruo
2026-07-03  2:33   ` Dongjiang Zhu
2026-07-03  3:19     ` Qu Wenruo [this message]
2026-07-02 23:40 ` [PATCH 2/2] btrfs: remove "usebackuproot" mount option Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e443ce41-2174-42b1-b005-d7df5e668a31@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    --cc=zhudongjiang@fnnas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.