From: Tian Yuchen <cat@malon.dev>
To: Junio C Hamano <gitster@pobox.com>
Cc: Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org, karthik.188@gmail.com,
phillip.wood@dunelm.org.uk, jltobler@gmail.com
Subject: Re: [PATCH v1] builtin/mktree: remove USE_THE_REPOSITORY_VARIABLE
Date: Sat, 14 Mar 2026 02:12:07 +0800 [thread overview]
Message-ID: <e448f98d-58be-409d-9ff2-ae45442dbded@malon.dev> (raw)
In-Reply-To: <xmqqzf4b4ntq.fsf@gitster.g>
On 3/14/26 01:54, Junio C Hamano wrote:
> I strongly disagree your idea that 'z' is more business logic than
> 'h' is. Both are equally relevant.
Perhaps I didn't explain myself clearly :(
I do understand that *currently* both are part of the business logic.
However, what puzzles me is: why is it written this way? Why isn't -h
intercepted at the outer global level, but instead handed off to a
function like parse_options() for interception?
Is this due to historical reasons?
Please forgive my slowness. I would appreciate it if you could offer
some guidance!
Thanks,
Yuchen
next prev parent reply other threads:[~2026-03-13 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 18:17 [PATCH v1] builtin/mktree: remove USE_THE_REPOSITORY_VARIABLE Tian Yuchen
2026-03-12 6:55 ` Patrick Steinhardt
2026-03-12 16:21 ` Tian Yuchen
2026-03-13 7:02 ` Patrick Steinhardt
2026-03-13 16:03 ` Junio C Hamano
2026-03-13 17:15 ` Tian Yuchen
2026-03-13 17:54 ` Junio C Hamano
2026-03-13 18:12 ` Tian Yuchen [this message]
2026-03-13 20:20 ` Junio C Hamano
2026-03-14 3:17 ` Tian Yuchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e448f98d-58be-409d-9ff2-ae45442dbded@malon.dev \
--to=cat@malon.dev \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=karthik.188@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.