From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3758EC433F5 for ; Wed, 24 Nov 2021 17:37:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237597AbhKXRkO (ORCPT ); Wed, 24 Nov 2021 12:40:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236657AbhKXRkJ (ORCPT ); Wed, 24 Nov 2021 12:40:09 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF872C061574; Wed, 24 Nov 2021 09:36:58 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id b1so9152567lfs.13; Wed, 24 Nov 2021 09:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZIcn+RRc9Rps+7b0T+IyJm79uMUpyF3YvcCN2OC7l9Y=; b=FLBSX0+olXTOAlp7C+knSf/7drnIn7H/UX7TDK9AoSp4PkuSj60LVuYkKMnjcC9YY3 ikWuFdLfD1kbuzClK7j2r8uE52m0ciCo0F41wb7XU00orL14Q13pQk+6d+pyM7vdO2QK LYUIqSIXIslxr1QmFi4Bl0ADQeiZ5m+/BOBB6vDflgHIEMsk0Q88DdJUo3wVEYI8Pr5Z sXvAtuyUfl3+J0677+KUwo73hWKLP5dVAe3qav01Qm9WaXlqZU7Qi87kYoIB9qdRIWxe kKTxqqpAJ0WWNVIjLM+Cf5/IG4PS+Rx6faWvmZ4/OGrH5fC0tZn54q+Z8fHjDwt1vOnd kYzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZIcn+RRc9Rps+7b0T+IyJm79uMUpyF3YvcCN2OC7l9Y=; b=uQIzkJn0wSAkVuAw8V7ZbZCiZb2EQ0p8Ko6qYDfSsV+plbKIXBP7i7xvDtXNHj0jTj qRp2UUtb3OsqGRjm4k3CW4HyABMP8hmbGmNUz0R9y9SyGxI0SLmFmHEjOBdHCWTP6cRV aGKYy/I8tkJ77dGvCJw7kBd/PnfqI964WqLxwSuOUiR+ciCmsFqEu7U5b59BcozcGR0S YQSs28vZnHBHdl+LVCEFEMmkcOvIzW3beeV7oPx6degewSh9e2n/o5qRuF53vTnQtfmv CcJfuigbRt7OaTn0Yoy3s8O8pP7DqSBswckosVoSU4uwLFHrpA1AIw555A31uX6vS+iG sQqA== X-Gm-Message-State: AOAM5304oSOUx7N0KWKhx9uJm4Fa87p+VEk1g/gocNbCq4ZDyaJiz1a3 nCjtgt+2l/Jh+JySVcHNMHuDqrYkl74= X-Google-Smtp-Source: ABdhPJxrgNz+71paDdUUv/N7my06bflGW6cF8iV2RywOAz26KaDrmDsPh/ZBuabbAUbFBAGdMU59uQ== X-Received: by 2002:a05:6512:2341:: with SMTP id p1mr16884188lfu.204.1637775417014; Wed, 24 Nov 2021 09:36:57 -0800 (PST) Received: from [192.168.2.145] (94-29-48-99.dynamic.spd-mgts.ru. [94.29.48.99]) by smtp.googlemail.com with ESMTPSA id e14sm42342ljn.78.2021.11.24.09.36.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 09:36:56 -0800 (PST) Subject: Re: [PATCH v2 01/11] ASoC: tegra20-spdif: stop setting slave_id To: Arnd Bergmann Cc: Vinod Koul , Arnd Bergmann , Andy Gross , Andy Shevchenko , Baolin Wang , Bjorn Andersson , Chunyan Zhang , Greg Kroah-Hartman , Hyun Kwon , Jaroslav Kysela , Jon Hunter , Lars-Peter Clausen , Laurent Pinchart , Laxman Dewangan , Manivannan Sadhasivam , Mark Brown , Michal Simek , Nicolas Saenz Julienne , Orson Zhai , Robert Jarzmik , Scott Branden , Takashi Iwai , Thierry Reding , ALSA Development Mailing List , bcm-kernel-feedback-list , dmaengine@vger.kernel.org, dri-devel , Linux ARM , linux-arm-msm , Linux Kernel Mailing List , linux-mmc , linux-mtd , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "open list:SERIAL DRIVERS" , linux-spi , linux-staging@lists.linux.dev, "open list:TEGRA ARCHITECTURE SUPPORT" References: <20211122222203.4103644-1-arnd@kernel.org> <20211122222203.4103644-2-arnd@kernel.org> <1dbe0c9f-e209-49e1-f05c-765d9f9b91eb@gmail.com> From: Dmitry Osipenko Message-ID: Date: Wed, 24 Nov 2021 20:36:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org 24.11.2021 19:47, Arnd Bergmann пишет: > On Wed, Nov 24, 2021 at 5:32 PM Dmitry Osipenko wrote: >> 23.11.2021 01:21, Arnd Bergmann пишет: >> >> The commit message is correct, however you could remove even more code >> here. But there is no need to make a v3 just because this patch because >> I already prepared patchset that revives this S/PDIF driver and enables >> HDMI audio on Tegra20. I'll take care of cleaning up the whole code of >> this driver. > > Ok, perfect, thanks for taking a closer look as well. > >> >> - dmareq = platform_get_resource(pdev, IORESOURCE_DMA, 0); >> - if (!dmareq) { >> - dev_err(&pdev->dev, "No DMA resource\n"); >> - return -ENODEV; >> - } >> - > > Right, I think I considered doing this at some point as well, not sure > why I left it in for the version I posted. Passing the IORESOURCE_DMA > values is clearly wrong by itself and needs to be removed, though > it's not obvious what the correct way of requesting the DMA channel > is for this driver either, without a DT binding or users. Yes, it's indeed not obvious. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B30FAC433F5 for ; Wed, 24 Nov 2021 17:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=qiXUphVmZYwd7Plfgf99H5UDu10shgCAEMSnTb7Keqg=; b=Vgmsir9RdYi3qSnkasEW2zjOsx Vmz4OJMh6o2TxBZkc0/YyJI4JH2t2NXfkMtH+yTfwSEQRFGXiF5xQMKqoz7PeIutbi+5sBCqTMDtO Q5G9FL5X2l9OF1P0b/K6CkNxxcdXUHY9NSUVDQl3LVenoKf3/H30X1PYwjyk//3Ycd6LT3ig/ydoS qRdXRAXH9LYTm8HM1XUt4hyoKvgH8MD480RSPb9egYZW42vBL5ww9ZfcctJ2a0Zv6zsMHu/6/ZRr6 xObV+U5SLo9Qqf+2UTDVZaiMzKLAkfqLJDjJprHmkheCDqvOHT+xy2WtM7PYxHTlsLfTpr4E8IO4R D/KhfAiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpwCc-005PVd-D7; Wed, 24 Nov 2021 17:37:02 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpwCY-005PUv-Vk; Wed, 24 Nov 2021 17:37:00 +0000 Received: by mail-lf1-x135.google.com with SMTP id bi37so9253831lfb.5; Wed, 24 Nov 2021 09:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZIcn+RRc9Rps+7b0T+IyJm79uMUpyF3YvcCN2OC7l9Y=; b=FLBSX0+olXTOAlp7C+knSf/7drnIn7H/UX7TDK9AoSp4PkuSj60LVuYkKMnjcC9YY3 ikWuFdLfD1kbuzClK7j2r8uE52m0ciCo0F41wb7XU00orL14Q13pQk+6d+pyM7vdO2QK LYUIqSIXIslxr1QmFi4Bl0ADQeiZ5m+/BOBB6vDflgHIEMsk0Q88DdJUo3wVEYI8Pr5Z sXvAtuyUfl3+J0677+KUwo73hWKLP5dVAe3qav01Qm9WaXlqZU7Qi87kYoIB9qdRIWxe kKTxqqpAJ0WWNVIjLM+Cf5/IG4PS+Rx6faWvmZ4/OGrH5fC0tZn54q+Z8fHjDwt1vOnd kYzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZIcn+RRc9Rps+7b0T+IyJm79uMUpyF3YvcCN2OC7l9Y=; b=Bd7KnqaSREbd4JtTY86b98oymgntgASvNy10Y+tY9orqiCo+B4Rz04OixIWkkDgJfd 0dhMuPCSityFdqR6E37Krfy/zyJnFSV4lYa8Rg4S9Cer3g/TFzGm8N6297RxIIYipd9Q iezeJgOdaLl6YLRLcx2PsnR4Lg6lYrrggCECrF8n0UEr7+OUnr4wL20Q3nhACRAQwJDx XI6FmgpXmYsrGA+4y8jSFCMGOzDENbV0aL2nJN/XNWQFyKHpZqXGMMUkz3QCLweBarqf PUrlWRhJvWluM8Ahk2qLzdr8aRPIBB4lyyLsUcptLFkPLlWiOLcFRfqL3+su73C2ZpgR W39A== X-Gm-Message-State: AOAM533pcOCjXawJ2uvn0je3GAVX3zqtZJZX9w87V9bmNs0kOJ34zcZX EGzyIQb6q3Kki1/xvnFnKPg= X-Google-Smtp-Source: ABdhPJxrgNz+71paDdUUv/N7my06bflGW6cF8iV2RywOAz26KaDrmDsPh/ZBuabbAUbFBAGdMU59uQ== X-Received: by 2002:a05:6512:2341:: with SMTP id p1mr16884188lfu.204.1637775417014; Wed, 24 Nov 2021 09:36:57 -0800 (PST) Received: from [192.168.2.145] (94-29-48-99.dynamic.spd-mgts.ru. [94.29.48.99]) by smtp.googlemail.com with ESMTPSA id e14sm42342ljn.78.2021.11.24.09.36.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 09:36:56 -0800 (PST) Subject: Re: [PATCH v2 01/11] ASoC: tegra20-spdif: stop setting slave_id To: Arnd Bergmann Cc: Vinod Koul , Arnd Bergmann , Andy Gross , Andy Shevchenko , Baolin Wang , Bjorn Andersson , Chunyan Zhang , Greg Kroah-Hartman , Hyun Kwon , Jaroslav Kysela , Jon Hunter , Lars-Peter Clausen , Laurent Pinchart , Laxman Dewangan , Manivannan Sadhasivam , Mark Brown , Michal Simek , Nicolas Saenz Julienne , Orson Zhai , Robert Jarzmik , Scott Branden , Takashi Iwai , Thierry Reding , ALSA Development Mailing List , bcm-kernel-feedback-list , dmaengine@vger.kernel.org, dri-devel , Linux ARM , linux-arm-msm , Linux Kernel Mailing List , linux-mmc , linux-mtd , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "open list:SERIAL DRIVERS" , linux-spi , linux-staging@lists.linux.dev, "open list:TEGRA ARCHITECTURE SUPPORT" References: <20211122222203.4103644-1-arnd@kernel.org> <20211122222203.4103644-2-arnd@kernel.org> <1dbe0c9f-e209-49e1-f05c-765d9f9b91eb@gmail.com> From: Dmitry Osipenko Message-ID: Date: Wed, 24 Nov 2021 20:36:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_093659_066490_9DA05D30 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org MjQuMTEuMjAyMSAxOTo0NywgQXJuZCBCZXJnbWFubiDQv9C40YjQtdGCOgo+IE9uIFdlZCwgTm92 IDI0LCAyMDIxIGF0IDU6MzIgUE0gRG1pdHJ5IE9zaXBlbmtvIDxkaWdldHhAZ21haWwuY29tPiB3 cm90ZToKPj4gMjMuMTEuMjAyMSAwMToyMSwgQXJuZCBCZXJnbWFubiDQv9C40YjQtdGCOgo+Pgo+ PiBUaGUgY29tbWl0IG1lc3NhZ2UgaXMgY29ycmVjdCwgaG93ZXZlciB5b3UgY291bGQgcmVtb3Zl IGV2ZW4gbW9yZSBjb2RlCj4+IGhlcmUuIEJ1dCB0aGVyZSBpcyBubyBuZWVkIHRvIG1ha2UgYSB2 MyBqdXN0IGJlY2F1c2UgdGhpcyBwYXRjaCBiZWNhdXNlCj4+IEkgYWxyZWFkeSBwcmVwYXJlZCBw YXRjaHNldCB0aGF0IHJldml2ZXMgdGhpcyBTL1BESUYgZHJpdmVyIGFuZCBlbmFibGVzCj4+IEhE TUkgYXVkaW8gb24gVGVncmEyMC4gSSdsbCB0YWtlIGNhcmUgb2YgY2xlYW5pbmcgdXAgdGhlIHdo b2xlIGNvZGUgb2YKPj4gdGhpcyBkcml2ZXIuCj4gCj4gT2ssIHBlcmZlY3QsIHRoYW5rcyBmb3Ig dGFraW5nIGEgY2xvc2VyIGxvb2sgYXMgd2VsbC4KPiAKPj4KPj4gLSAgICAgICBkbWFyZXEgPSBw bGF0Zm9ybV9nZXRfcmVzb3VyY2UocGRldiwgSU9SRVNPVVJDRV9ETUEsIDApOwo+PiAtICAgICAg IGlmICghZG1hcmVxKSB7Cj4+IC0gICAgICAgICAgICAgICBkZXZfZXJyKCZwZGV2LT5kZXYsICJO byBETUEgcmVzb3VyY2VcbiIpOwo+PiAtICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9ERVY7Cj4+ IC0gICAgICAgfQo+PiAtCj4gCj4gUmlnaHQsIEkgdGhpbmsgSSBjb25zaWRlcmVkIGRvaW5nIHRo aXMgYXQgc29tZSBwb2ludCBhcyB3ZWxsLCBub3Qgc3VyZQo+IHdoeSBJIGxlZnQgaXQgaW4gZm9y IHRoZSB2ZXJzaW9uIEkgcG9zdGVkLiBQYXNzaW5nIHRoZSBJT1JFU09VUkNFX0RNQQo+IHZhbHVl cyBpcyBjbGVhcmx5IHdyb25nIGJ5IGl0c2VsZiBhbmQgbmVlZHMgdG8gYmUgcmVtb3ZlZCwgdGhv dWdoCj4gaXQncyBub3Qgb2J2aW91cyB3aGF0IHRoZSBjb3JyZWN0IHdheSBvZiByZXF1ZXN0aW5n IHRoZSBETUEgY2hhbm5lbAo+IGlzIGZvciB0aGlzIGRyaXZlciBlaXRoZXIsIHdpdGhvdXQgYSBE VCBiaW5kaW5nIG9yIHVzZXJzLgoKWWVzLCBpdCdzIGluZGVlZCBub3Qgb2J2aW91cy4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBN VEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A525C433EF for ; Wed, 24 Nov 2021 17:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=bvh6kFN+WsC5xBkra2tmGVX/nx0Xt9tOeu9QvOEY7fM=; b=AT2NwyVtYaZWBwye5p5nvxOrCJ T4dCTL8/tgJO9POWi94ZG4OJjjJsShWKOx9tJwgoSQ6VMqHvvjic6m7GV1iTQT//clojX1YtUKCQr 7F5jkPs9+TWYsYIOV7Y8dN/9Jn5GHEZlYX+RU6QhCNo6gl0c4kbAQlE2BsiHitdPtqCixsmISm1by oTTzYTXqu1OKwcr3mrhBXkWitOTpynCbWJinlDlRRfK4bd2Z9S+VjGxXNV8B+zQ1VuvBGyVVBAd7t 1N7YbAW9LfhpJL1T7AMebRX3q8ly9eIe0NgBy8Ac/Ky0zg5Gt8YXKrwOKK3/hEnmP+0PvPr3LYDWH dLyWfAMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpwCq-005PXp-2E; Wed, 24 Nov 2021 17:37:16 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpwCY-005PUv-Vk; Wed, 24 Nov 2021 17:37:00 +0000 Received: by mail-lf1-x135.google.com with SMTP id bi37so9253831lfb.5; Wed, 24 Nov 2021 09:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZIcn+RRc9Rps+7b0T+IyJm79uMUpyF3YvcCN2OC7l9Y=; b=FLBSX0+olXTOAlp7C+knSf/7drnIn7H/UX7TDK9AoSp4PkuSj60LVuYkKMnjcC9YY3 ikWuFdLfD1kbuzClK7j2r8uE52m0ciCo0F41wb7XU00orL14Q13pQk+6d+pyM7vdO2QK LYUIqSIXIslxr1QmFi4Bl0ADQeiZ5m+/BOBB6vDflgHIEMsk0Q88DdJUo3wVEYI8Pr5Z sXvAtuyUfl3+J0677+KUwo73hWKLP5dVAe3qav01Qm9WaXlqZU7Qi87kYoIB9qdRIWxe kKTxqqpAJ0WWNVIjLM+Cf5/IG4PS+Rx6faWvmZ4/OGrH5fC0tZn54q+Z8fHjDwt1vOnd kYzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZIcn+RRc9Rps+7b0T+IyJm79uMUpyF3YvcCN2OC7l9Y=; b=Bd7KnqaSREbd4JtTY86b98oymgntgASvNy10Y+tY9orqiCo+B4Rz04OixIWkkDgJfd 0dhMuPCSityFdqR6E37Krfy/zyJnFSV4lYa8Rg4S9Cer3g/TFzGm8N6297RxIIYipd9Q iezeJgOdaLl6YLRLcx2PsnR4Lg6lYrrggCECrF8n0UEr7+OUnr4wL20Q3nhACRAQwJDx XI6FmgpXmYsrGA+4y8jSFCMGOzDENbV0aL2nJN/XNWQFyKHpZqXGMMUkz3QCLweBarqf PUrlWRhJvWluM8Ahk2qLzdr8aRPIBB4lyyLsUcptLFkPLlWiOLcFRfqL3+su73C2ZpgR W39A== X-Gm-Message-State: AOAM533pcOCjXawJ2uvn0je3GAVX3zqtZJZX9w87V9bmNs0kOJ34zcZX EGzyIQb6q3Kki1/xvnFnKPg= X-Google-Smtp-Source: ABdhPJxrgNz+71paDdUUv/N7my06bflGW6cF8iV2RywOAz26KaDrmDsPh/ZBuabbAUbFBAGdMU59uQ== X-Received: by 2002:a05:6512:2341:: with SMTP id p1mr16884188lfu.204.1637775417014; Wed, 24 Nov 2021 09:36:57 -0800 (PST) Received: from [192.168.2.145] (94-29-48-99.dynamic.spd-mgts.ru. [94.29.48.99]) by smtp.googlemail.com with ESMTPSA id e14sm42342ljn.78.2021.11.24.09.36.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 09:36:56 -0800 (PST) Subject: Re: [PATCH v2 01/11] ASoC: tegra20-spdif: stop setting slave_id To: Arnd Bergmann Cc: Vinod Koul , Arnd Bergmann , Andy Gross , Andy Shevchenko , Baolin Wang , Bjorn Andersson , Chunyan Zhang , Greg Kroah-Hartman , Hyun Kwon , Jaroslav Kysela , Jon Hunter , Lars-Peter Clausen , Laurent Pinchart , Laxman Dewangan , Manivannan Sadhasivam , Mark Brown , Michal Simek , Nicolas Saenz Julienne , Orson Zhai , Robert Jarzmik , Scott Branden , Takashi Iwai , Thierry Reding , ALSA Development Mailing List , bcm-kernel-feedback-list , dmaengine@vger.kernel.org, dri-devel , Linux ARM , linux-arm-msm , Linux Kernel Mailing List , linux-mmc , linux-mtd , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "open list:SERIAL DRIVERS" , linux-spi , linux-staging@lists.linux.dev, "open list:TEGRA ARCHITECTURE SUPPORT" References: <20211122222203.4103644-1-arnd@kernel.org> <20211122222203.4103644-2-arnd@kernel.org> <1dbe0c9f-e209-49e1-f05c-765d9f9b91eb@gmail.com> From: Dmitry Osipenko Message-ID: Date: Wed, 24 Nov 2021 20:36:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_093659_066490_9DA05D30 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjQuMTEuMjAyMSAxOTo0NywgQXJuZCBCZXJnbWFubiDQv9C40YjQtdGCOgo+IE9uIFdlZCwgTm92 IDI0LCAyMDIxIGF0IDU6MzIgUE0gRG1pdHJ5IE9zaXBlbmtvIDxkaWdldHhAZ21haWwuY29tPiB3 cm90ZToKPj4gMjMuMTEuMjAyMSAwMToyMSwgQXJuZCBCZXJnbWFubiDQv9C40YjQtdGCOgo+Pgo+ PiBUaGUgY29tbWl0IG1lc3NhZ2UgaXMgY29ycmVjdCwgaG93ZXZlciB5b3UgY291bGQgcmVtb3Zl IGV2ZW4gbW9yZSBjb2RlCj4+IGhlcmUuIEJ1dCB0aGVyZSBpcyBubyBuZWVkIHRvIG1ha2UgYSB2 MyBqdXN0IGJlY2F1c2UgdGhpcyBwYXRjaCBiZWNhdXNlCj4+IEkgYWxyZWFkeSBwcmVwYXJlZCBw YXRjaHNldCB0aGF0IHJldml2ZXMgdGhpcyBTL1BESUYgZHJpdmVyIGFuZCBlbmFibGVzCj4+IEhE TUkgYXVkaW8gb24gVGVncmEyMC4gSSdsbCB0YWtlIGNhcmUgb2YgY2xlYW5pbmcgdXAgdGhlIHdo b2xlIGNvZGUgb2YKPj4gdGhpcyBkcml2ZXIuCj4gCj4gT2ssIHBlcmZlY3QsIHRoYW5rcyBmb3Ig dGFraW5nIGEgY2xvc2VyIGxvb2sgYXMgd2VsbC4KPiAKPj4KPj4gLSAgICAgICBkbWFyZXEgPSBw bGF0Zm9ybV9nZXRfcmVzb3VyY2UocGRldiwgSU9SRVNPVVJDRV9ETUEsIDApOwo+PiAtICAgICAg IGlmICghZG1hcmVxKSB7Cj4+IC0gICAgICAgICAgICAgICBkZXZfZXJyKCZwZGV2LT5kZXYsICJO byBETUEgcmVzb3VyY2VcbiIpOwo+PiAtICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9ERVY7Cj4+ IC0gICAgICAgfQo+PiAtCj4gCj4gUmlnaHQsIEkgdGhpbmsgSSBjb25zaWRlcmVkIGRvaW5nIHRo aXMgYXQgc29tZSBwb2ludCBhcyB3ZWxsLCBub3Qgc3VyZQo+IHdoeSBJIGxlZnQgaXQgaW4gZm9y IHRoZSB2ZXJzaW9uIEkgcG9zdGVkLiBQYXNzaW5nIHRoZSBJT1JFU09VUkNFX0RNQQo+IHZhbHVl cyBpcyBjbGVhcmx5IHdyb25nIGJ5IGl0c2VsZiBhbmQgbmVlZHMgdG8gYmUgcmVtb3ZlZCwgdGhv dWdoCj4gaXQncyBub3Qgb2J2aW91cyB3aGF0IHRoZSBjb3JyZWN0IHdheSBvZiByZXF1ZXN0aW5n IHRoZSBETUEgY2hhbm5lbAo+IGlzIGZvciB0aGlzIGRyaXZlciBlaXRoZXIsIHdpdGhvdXQgYSBE VCBiaW5kaW5nIG9yIHVzZXJzLgoKWWVzLCBpdCdzIGluZGVlZCBub3Qgb2J2aW91cy4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC0F1C433F5 for ; Wed, 24 Nov 2021 17:37:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A2C06E914; Wed, 24 Nov 2021 17:37:00 +0000 (UTC) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9778E6E914 for ; Wed, 24 Nov 2021 17:36:58 +0000 (UTC) Received: by mail-lf1-x136.google.com with SMTP id l22so9247704lfg.7 for ; Wed, 24 Nov 2021 09:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZIcn+RRc9Rps+7b0T+IyJm79uMUpyF3YvcCN2OC7l9Y=; b=FLBSX0+olXTOAlp7C+knSf/7drnIn7H/UX7TDK9AoSp4PkuSj60LVuYkKMnjcC9YY3 ikWuFdLfD1kbuzClK7j2r8uE52m0ciCo0F41wb7XU00orL14Q13pQk+6d+pyM7vdO2QK LYUIqSIXIslxr1QmFi4Bl0ADQeiZ5m+/BOBB6vDflgHIEMsk0Q88DdJUo3wVEYI8Pr5Z sXvAtuyUfl3+J0677+KUwo73hWKLP5dVAe3qav01Qm9WaXlqZU7Qi87kYoIB9qdRIWxe kKTxqqpAJ0WWNVIjLM+Cf5/IG4PS+Rx6faWvmZ4/OGrH5fC0tZn54q+Z8fHjDwt1vOnd kYzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZIcn+RRc9Rps+7b0T+IyJm79uMUpyF3YvcCN2OC7l9Y=; b=kQZ0p5QNymPs6wwaBJwRhP+btC+wGLTjqrWMFtCC9AlPZnhZnYRV8LbZSXsOSd11R7 v5lCXU1FpvTYh7E0T9tqkT33W04IWOo+fe9/BPp8gwSdQOBEhn4bzi6oCZ9/haI5gGsm x17yJC6vxnztoyeawzQfSjWxrNol6Uj0qEORWeOsJTsCW/y61CSVGZCbyQRD5dgd8fn8 kAYy/NxNFIVgf68Z/QHgQkAfmOA7z2XSQ/gCApMrkVbsIUfhm+g8NTWSjXYAs5lLOtQA 32GAtK3ypKIXG/nKeCtHpHBKPRUmw0feS7oQuqonRfwMYTx0sZ2943i8+6fgp535sd+E dONw== X-Gm-Message-State: AOAM5313UX/Wj07kJ2aVPSNsCOhixSDErD5o68ci/aQTyUsgHu7ohG0O 4oD5wXJRLNyx74cUo33Ud8s= X-Google-Smtp-Source: ABdhPJxrgNz+71paDdUUv/N7my06bflGW6cF8iV2RywOAz26KaDrmDsPh/ZBuabbAUbFBAGdMU59uQ== X-Received: by 2002:a05:6512:2341:: with SMTP id p1mr16884188lfu.204.1637775417014; Wed, 24 Nov 2021 09:36:57 -0800 (PST) Received: from [192.168.2.145] (94-29-48-99.dynamic.spd-mgts.ru. [94.29.48.99]) by smtp.googlemail.com with ESMTPSA id e14sm42342ljn.78.2021.11.24.09.36.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 09:36:56 -0800 (PST) Subject: Re: [PATCH v2 01/11] ASoC: tegra20-spdif: stop setting slave_id To: Arnd Bergmann References: <20211122222203.4103644-1-arnd@kernel.org> <20211122222203.4103644-2-arnd@kernel.org> <1dbe0c9f-e209-49e1-f05c-765d9f9b91eb@gmail.com> From: Dmitry Osipenko Message-ID: Date: Wed, 24 Nov 2021 20:36:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ALSA Development Mailing List , dri-devel , Bjorn Andersson , "open list:TEGRA ARCHITECTURE SUPPORT" , Laxman Dewangan , linux-mtd , Laurent Pinchart , linux-spi , Robert Jarzmik , Chunyan Zhang , linux-staging@lists.linux.dev, Michal Simek , Jon Hunter , Andy Gross , bcm-kernel-feedback-list , "open list:SERIAL DRIVERS" , Orson Zhai , Nicolas Saenz Julienne , Arnd Bergmann , Manivannan Sadhasivam , linux-arm-msm , dmaengine@vger.kernel.org, Mark Brown , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , Jaroslav Kysela , Andy Shevchenko , Linux ARM , Scott Branden , Hyun Kwon , Greg Kroah-Hartman , linux-mmc , Takashi Iwai , Linux Kernel Mailing List , Vinod Koul , Thierry Reding , Baolin Wang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 24.11.2021 19:47, Arnd Bergmann пишет: > On Wed, Nov 24, 2021 at 5:32 PM Dmitry Osipenko wrote: >> 23.11.2021 01:21, Arnd Bergmann пишет: >> >> The commit message is correct, however you could remove even more code >> here. But there is no need to make a v3 just because this patch because >> I already prepared patchset that revives this S/PDIF driver and enables >> HDMI audio on Tegra20. I'll take care of cleaning up the whole code of >> this driver. > > Ok, perfect, thanks for taking a closer look as well. > >> >> - dmareq = platform_get_resource(pdev, IORESOURCE_DMA, 0); >> - if (!dmareq) { >> - dev_err(&pdev->dev, "No DMA resource\n"); >> - return -ENODEV; >> - } >> - > > Right, I think I considered doing this at some point as well, not sure > why I left it in for the version I posted. Passing the IORESOURCE_DMA > values is clearly wrong by itself and needs to be removed, though > it's not obvious what the correct way of requesting the DMA channel > is for this driver either, without a DT binding or users. Yes, it's indeed not obvious.