All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Andreas Schwab <schwab@suse.de>
Cc: linuxppc-dev@ozlabs.org, Linus Torvalds <torvalds@osdl.org>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: Please pull powerpc.git for_paulus branch (fwd)
Date: Mon, 28 May 2007 13:34:20 +0200	[thread overview]
Message-ID: <e460825e91e0abfc55f8dd777dcc248b@kernel.crashing.org> (raw)
In-Reply-To: <jesl9hgql9.fsf@sykes.suse.de>

>> -	.comm	fee_restarts,4
>> +	.section .bss
>> +	.align	2
>> +fee_restarts:
>> +	.space	4
>> +	.previous
>
> This is equivalent to .lcomm.

Oh nice!  So this should become

	.lcomm fee_restarts,4,4

for the local symbols, and

	.globl fee_restarts
	.lcomm fee_restarts,4,4

for the global ones.  Kumar: the parameters here are size,align;
and it takes an alignment in bytes, not in power-of-two like
.align does on powerpc.  Which is a good thing, considering that
you messed up the log-alignment for global_dcbr0 in the original
patch ;-)


Segher

      reply	other threads:[~2007-05-28 11:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-27 13:58 Please pull powerpc.git for_paulus branch (fwd) Kumar Gala
2007-05-28  1:32 ` Benjamin Herrenschmidt
2007-05-28  1:52 ` Paul Mackerras
2007-05-28 11:36   ` Segher Boessenkool
2007-05-28 11:00 ` Andreas Schwab
2007-05-28 11:34   ` Segher Boessenkool [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e460825e91e0abfc55f8dd777dcc248b@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=schwab@suse.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.