From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v9 3/3] tools/libxc: use superpages during restore of HVM guest
Date: Wed, 6 Sep 2017 13:23:34 +0100 [thread overview]
Message-ID: <e490044b-571f-5ec8-e329-413f31b33630@citrix.com> (raw)
In-Reply-To: <20170906121739.GC23062@aepfle.de>
On 06/09/17 13:17, Olaf Hering wrote:
> On Wed, Sep 06, Andrew Cooper wrote:
>
>> On 01/09/17 17:08, Olaf Hering wrote:
>>> + /* No superpage in 1st 2MB due to VGA hole */
>>> + xc_sr_set_bit(0, &ctx->x86_hvm.restore.attempted_1g);
>>> + xc_sr_set_bit(0, &ctx->x86_hvm.restore.attempted_2m);
>> This is false for PVH guests.
> How can I detect a PVH guest?
You (hopefully) can't, and it would be a layering violation if you could.
The exact set of emulation available to/used by a guest is not relevant
to how we move its memory.
If a PVH guest has got MTRRs disabled, then it genuinely can run on an
unshattered 1G superpage at 0.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-06 12:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 16:08 [PATCH v9 0/3] tools/libxc: use superpages Olaf Hering
2017-09-01 16:08 ` [PATCH v9 1/3] tools/libxc: move SUPERPAGE macros to common header Olaf Hering
2017-09-01 16:08 ` [PATCH v9 2/3] tools/libxc: add API for bitmap access for restore Olaf Hering
2017-09-06 11:57 ` Andrew Cooper
2017-09-06 12:15 ` Olaf Hering
2017-09-01 16:08 ` [PATCH v9 3/3] tools/libxc: use superpages during restore of HVM guest Olaf Hering
2017-09-06 11:34 ` Wei Liu
2017-09-06 11:39 ` Andrew Cooper
2017-09-08 11:45 ` Olaf Hering
2017-10-11 14:15 ` Olaf Hering
2017-10-11 15:09 ` Olaf Hering
2017-09-06 12:02 ` Olaf Hering
2017-09-06 12:13 ` Andrew Cooper
2017-09-06 12:17 ` Olaf Hering
2017-09-06 12:23 ` Andrew Cooper [this message]
2017-09-06 12:25 ` Olaf Hering
2017-09-06 12:24 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e490044b-571f-5ec8-e329-413f31b33630@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.