From: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe: Move xe_gpu_commands.h file to instructions/
Date: Thu, 9 May 2024 10:07:07 +0530 [thread overview]
Message-ID: <e495c482-e70c-4ca1-bf55-0a02bc5f806d@intel.com> (raw)
In-Reply-To: <20240508174856.1908-1-michal.wajdeczko@intel.com>
On 08-05-2024 23:18, Michal Wajdeczko wrote:
> All other files with commands definitions are in instructions/
> folder. Move xe_gpu_commands.h also there.
LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Thanks.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/xe/{regs => instructions}/xe_gpu_commands.h | 0
> drivers/gpu/drm/xe/xe_bb.c | 1 -
> drivers/gpu/drm/xe/xe_device.c | 2 +-
> drivers/gpu/drm/xe/xe_execlist.c | 1 -
> drivers/gpu/drm/xe/xe_lrc.c | 1 -
> drivers/gpu/drm/xe/xe_migrate.c | 2 +-
> drivers/gpu/drm/xe/xe_ring_ops.c | 2 +-
> 7 files changed, 3 insertions(+), 6 deletions(-)
> rename drivers/gpu/drm/xe/{regs => instructions}/xe_gpu_commands.h (100%)
>
> diff --git a/drivers/gpu/drm/xe/regs/xe_gpu_commands.h b/drivers/gpu/drm/xe/instructions/xe_gpu_commands.h
> similarity index 100%
> rename from drivers/gpu/drm/xe/regs/xe_gpu_commands.h
> rename to drivers/gpu/drm/xe/instructions/xe_gpu_commands.h
> diff --git a/drivers/gpu/drm/xe/xe_bb.c b/drivers/gpu/drm/xe/xe_bb.c
> index 37e056fde95d..a13e0b3a169e 100644
> --- a/drivers/gpu/drm/xe/xe_bb.c
> +++ b/drivers/gpu/drm/xe/xe_bb.c
> @@ -6,7 +6,6 @@
> #include "xe_bb.h"
>
> #include "instructions/xe_mi_commands.h"
> -#include "regs/xe_gpu_commands.h"
> #include "xe_assert.h"
> #include "xe_device.h"
> #include "xe_exec_queue_types.h"
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index b63d98872a41..f89c781986a5 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -17,7 +17,7 @@
> #include <drm/xe_drm.h>
>
> #include "display/xe_display.h"
> -#include "regs/xe_gpu_commands.h"
> +#include "instructions/xe_gpu_commands.h"
> #include "regs/xe_gt_regs.h"
> #include "regs/xe_regs.h"
> #include "xe_bo.h"
> diff --git a/drivers/gpu/drm/xe/xe_execlist.c b/drivers/gpu/drm/xe/xe_execlist.c
> index dece2785933c..e9dee1e14fef 100644
> --- a/drivers/gpu/drm/xe/xe_execlist.c
> +++ b/drivers/gpu/drm/xe/xe_execlist.c
> @@ -9,7 +9,6 @@
>
> #include "instructions/xe_mi_commands.h"
> #include "regs/xe_engine_regs.h"
> -#include "regs/xe_gpu_commands.h"
> #include "regs/xe_gt_regs.h"
> #include "regs/xe_lrc_layout.h"
> #include "xe_assert.h"
> diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
> index 2066d34ddf0b..a0cdd6977ebe 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.c
> +++ b/drivers/gpu/drm/xe/xe_lrc.c
> @@ -11,7 +11,6 @@
> #include "instructions/xe_gfxpipe_commands.h"
> #include "instructions/xe_gfx_state_commands.h"
> #include "regs/xe_engine_regs.h"
> -#include "regs/xe_gpu_commands.h"
> #include "regs/xe_lrc_layout.h"
> #include "xe_bb.h"
> #include "xe_bo.h"
> diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c
> index 9f6e9b7f11c8..36db5ed1a572 100644
> --- a/drivers/gpu/drm/xe/xe_migrate.c
> +++ b/drivers/gpu/drm/xe/xe_migrate.c
> @@ -14,8 +14,8 @@
>
> #include <generated/xe_wa_oob.h>
>
> +#include "instructions/xe_gpu_commands.h"
> #include "instructions/xe_mi_commands.h"
> -#include "regs/xe_gpu_commands.h"
> #include "regs/xe_gtt_defs.h"
> #include "tests/xe_test.h"
> #include "xe_assert.h"
> diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c
> index d42b3f33bd7a..a3ca718456f6 100644
> --- a/drivers/gpu/drm/xe/xe_ring_ops.c
> +++ b/drivers/gpu/drm/xe/xe_ring_ops.c
> @@ -7,9 +7,9 @@
>
> #include <generated/xe_wa_oob.h>
>
> +#include "instructions/xe_gpu_commands.h"
> #include "instructions/xe_mi_commands.h"
> #include "regs/xe_engine_regs.h"
> -#include "regs/xe_gpu_commands.h"
> #include "regs/xe_gt_regs.h"
> #include "regs/xe_lrc_layout.h"
> #include "xe_exec_queue_types.h"
next prev parent reply other threads:[~2024-05-09 4:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 17:48 [PATCH] drm/xe: Move xe_gpu_commands.h file to instructions/ Michal Wajdeczko
2024-05-08 18:12 ` ✓ CI.Patch_applied: success for " Patchwork
2024-05-08 18:13 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-08 18:13 ` ✓ CI.KUnit: success " Patchwork
2024-05-08 18:25 ` ✓ CI.Build: " Patchwork
2024-05-08 18:28 ` ✓ CI.Hooks: " Patchwork
2024-05-08 18:29 ` ✓ CI.checksparse: " Patchwork
2024-05-08 19:01 ` ✓ CI.BAT: " Patchwork
2024-05-09 4:37 ` Ghimiray, Himal Prasad [this message]
2024-05-09 5:49 ` ✗ CI.FULL: failure " Patchwork
2024-05-09 19:17 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e495c482-e70c-4ca1-bf55-0a02bc5f806d@intel.com \
--to=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.