From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915/breadcrumbs: Drop request reference for the signaler thread Date: Mon, 5 Feb 2018 13:45:16 +0000 Message-ID: References: <3e00c71f-3df0-b8db-1318-7c4917d530ca@linux.intel.com> <20180203101914.24880-1-chris@chris-wilson.co.uk> <9517cdab-87fb-4838-b1f3-30983bf4af99@linux.intel.com> <151783779666.15322.2777983453531447737@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 412926E1CA for ; Mon, 5 Feb 2018 13:45:19 +0000 (UTC) In-Reply-To: <151783779666.15322.2777983453531447737@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA1LzAyLzIwMTggMTM6MzYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTAyLTA1IDEzOjIzOjU0KQo+Pgo+PiBPbiAwMy8wMi8yMDE4IDEwOjE5 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBAQCAtNjU2LDQxICs3MDUsMjEgQEAgc3RhdGljIGlu dCBpbnRlbF9icmVhZGNydW1ic19zaWduYWxlcih2b2lkICphcmcpCj4+PiAgICAgICAgICAgICAg ICAgKiBhIG5ldyBjbGllbnQuCj4+PiAgICAgICAgICAgICAgICAgKi8KPj4+ICAgICAgICAgICAg ICAgIHJjdV9yZWFkX2xvY2soKTsKPj4+IC0gICAgICAgICAgICAgcmVxdWVzdCA9IHJjdV9kZXJl ZmVyZW5jZShiLT5maXJzdF9zaWduYWwpOwo+Pj4gLSAgICAgICAgICAgICBpZiAocmVxdWVzdCkK Pj4+IC0gICAgICAgICAgICAgICAgICAgICByZXF1ZXN0ID0gaTkxNV9nZW1fcmVxdWVzdF9nZXRf cmN1KHJlcXVlc3QpOwo+Pj4gKyAgICAgICAgICAgICByZXF1ZXN0ID0gZ2V0X2ZpcnN0X3NpZ25h bF9yY3UoYik7Cj4+PiAgICAgICAgICAgICAgICByY3VfcmVhZF91bmxvY2soKTsKPj4+ICAgICAg ICAgICAgICAgIGlmIChzaWduYWxfY29tcGxldGUocmVxdWVzdCkpIHsKPj4+IC0gICAgICAgICAg ICAgICAgICAgICBsb2NhbF9iaF9kaXNhYmxlKCk7Cj4+PiAtICAgICAgICAgICAgICAgICAgICAg ZG1hX2ZlbmNlX3NpZ25hbCgmcmVxdWVzdC0+ZmVuY2UpOwo+Pj4gLSAgICAgICAgICAgICAgICAg ICAgIGxvY2FsX2JoX2VuYWJsZSgpOyAvKiBraWNrIHN0YXJ0IHRoZSB0YXNrbGV0cyAqLwo+Pj4g LQo+Pj4gLSAgICAgICAgICAgICAgICAgICAgIHNwaW5fbG9ja19pcnEoJmItPnJiX2xvY2spOwo+ Pj4gLQo+Pj4gLSAgICAgICAgICAgICAgICAgICAgIC8qIFdha2UgdXAgYWxsIG90aGVyIGNvbXBs ZXRlZCB3YWl0ZXJzIGFuZCBzZWxlY3QgdGhlCj4+PiAtICAgICAgICAgICAgICAgICAgICAgICog bmV4dCBib3R0b20taGFsZiBmb3IgdGhlIG5leHQgdXNlciBpbnRlcnJ1cHQuCj4+PiAtICAgICAg ICAgICAgICAgICAgICAgICovCj4+PiAtICAgICAgICAgICAgICAgICAgICAgX19pbnRlbF9lbmdp bmVfcmVtb3ZlX3dhaXQoZW5naW5lLAo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICZyZXF1ZXN0LT5zaWduYWxpbmcud2FpdCk7Cj4+PiAtCj4+PiAt ICAgICAgICAgICAgICAgICAgICAgLyogRmluZCB0aGUgbmV4dCBvbGRlc3Qgc2lnbmFsLiBOb3Rl IHRoYXQgYXMgd2UgaGF2ZQo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAqIG5vdCBiZWVuIGhv bGRpbmcgdGhlIGxvY2ssIGFub3RoZXIgY2xpZW50IG1heQo+Pj4gLSAgICAgICAgICAgICAgICAg ICAgICAqIGhhdmUgaW5zdGFsbGVkIGFuIGV2ZW4gb2xkZXIgc2lnbmFsIHRoYW4gdGhlIG9uZQo+ Pj4gLSAgICAgICAgICAgICAgICAgICAgICAqIHdlIGp1c3QgY29tcGxldGVkIC0gc28gZG91Ymxl IGNoZWNrIHdlIGFyZSBzdGlsbAo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAqIHRoZSBvbGRl c3QgYmVmb3JlIHBpY2tpbmcgdGhlIG5leHQgb25lLgo+Pj4gLSAgICAgICAgICAgICAgICAgICAg ICAqLwo+Pj4gLSAgICAgICAgICAgICAgICAgICAgIGlmIChyZXF1ZXN0ID09IHJjdV9hY2Nlc3Nf cG9pbnRlcihiLT5maXJzdF9zaWduYWwpKSB7Cj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzdHJ1Y3QgcmJfbm9kZSAqcmIgPQo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICByYl9uZXh0KCZyZXF1ZXN0LT5zaWduYWxpbmcubm9kZSk7Cj4+PiAtICAgICAg ICAgICAgICAgICAgICAgICAgICAgICByY3VfYXNzaWduX3BvaW50ZXIoYi0+Zmlyc3Rfc2lnbmFs LAo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJi ID8gdG9fc2lnbmFsZXIocmIpIDogTlVMTCk7Cj4+PiArICAgICAgICAgICAgICAgICAgICAgaWYg KCF0ZXN0X2JpdChETUFfRkVOQ0VfRkxBR19TSUdOQUxFRF9CSVQsCj4+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAmcmVxdWVzdC0+ZmVuY2UuZmxhZ3MpKSB7Cj4+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBsb2NhbF9iaF9kaXNhYmxlKCk7Cj4+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBkbWFfZmVuY2Vfc2lnbmFsKCZyZXF1ZXN0LT5mZW5jZSk7 Cj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb2NhbF9iaF9lbmFibGUoKTsgLyog a2ljayBzdGFydCB0aGUgdGFza2xldHMgKi8KPj4+ICAgICAgICAgICAgICAgICAgICAgICAgfQo+ Pj4gLSAgICAgICAgICAgICAgICAgICAgIHJiX2VyYXNlKCZyZXF1ZXN0LT5zaWduYWxpbmcubm9k ZSwgJmItPnNpZ25hbHMpOwo+Pj4gLSAgICAgICAgICAgICAgICAgICAgIFJCX0NMRUFSX05PREUo JnJlcXVlc3QtPnNpZ25hbGluZy5ub2RlKTsKPj4+IC0KPj4+IC0gICAgICAgICAgICAgICAgICAg ICBzcGluX3VubG9ja19pcnEoJmItPnJiX2xvY2spOwo+Pj4gICAgCj4+PiAtICAgICAgICAgICAg ICAgICAgICAgaTkxNV9nZW1fcmVxdWVzdF9wdXQocmVxdWVzdCk7Cj4+PiArICAgICAgICAgICAg ICAgICAgICAgaWYgKFJFQURfT05DRShyZXF1ZXN0LT5zaWduYWxpbmcud2FpdC5zZXFubykpIHsK Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNwaW5fbG9ja19pcnEoJmItPnJiX2xv Y2spOwo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX19pbnRlbF9lbmdpbmVfcmVt b3ZlX3NpZ25hbChlbmdpbmUsIHJlcXVlc3QpOwo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgc3Bpbl91bmxvY2tfaXJxKCZiLT5yYl9sb2NrKTsKPj4+ICsgICAgICAgICAgICAgICAg ICAgICB9Cj4+Cj4+IEhvdyB3b3VsZCB5b3UgdmlldyB0YWtpbmcgdGhlIHJlcXVlc3QtPmxvY2sg b3ZlciB0aGlzIGJsb2NrIGluIHRoZQo+PiBzaWduYWxlciBhbmQgdGhlbiBiZWluZyBhYmxlIHRv IGNhbGwgc2ltcGx5Cj4+IGludGVsX2VuZ2luZV9jYW5jZWxfc2lnbmFsaW5nIC0gZW5kaW5nIHVw IHdpdGggdmVyeSBzaW1pbGFyIGNvZGUgYXMgaW4KPj4gaTkxNV9nZW1fcmVxdWVzdF9yZXRpcmU/ Cj4gCj4gSSBhbSBub3Qga2VlbiBvbiB0aGUgY29uZmxhdGlvbiBoZXJlIChtYXliZSBpdCdzIGp1 c3QgYSBoYXRyZWQgb2YgYm9vbAo+IHBhcmFtZXRlcnMpLiBCdXQgYXQgZmlyc3QgZ2xhbmNlIGl0 J3MganVzdCB0aGUgY29tbW9uYWxpdHkgb2YKPiByZW1vdmVfc2lnbmFsLCB3aGljaCBpcyBhbHJl YWR5IGEgY29tbW9uIHJvdXRpbmU/Cj4gCj4+IE9ubHkgZGlmZmVyZW5jZSB3b3VsZCBiZSB0aGUg dGFza2xldCBraWNraW5nLCBidXQgbWF5YmUgc3RpbGwgaXQgd291bGQKPj4gYmUgcG9zc2libGUg dG8gY29uc29saWRhdGUgdGhlIHR3byBpbiBvbmUgaGVscGVyLgo+Pgo+PiBfX2k5MTVfZ2VtX3Jl cXVlc3RfcmV0aXJlX3NpZ25hbGluZyhyZXEsIGJvb2wga2lja190YXNrbGV0cykKPj4gewo+PiAg ICAgICAgICBpZiAoIURNQV9GRU5DRV9GTEFHX1NJR05BTEVEX0JJVCkgewo+PiAgICAgICAgICAg ICAgICAgIGRtYV9mZW5jZV9zaWduYWxfbG9ja2VkKC4uLik7Cj4+ICAgICAgICAgICAgICAgICAg aWYgKGtpY2tfdGFza2xldHMpIHsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgIGxvY2FsX2Jo X2Rpc2FibGUoKTsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgIGxvY2FsX2JoX2VuYWJsZSgp Owo+PiAgICAgICAgICAgICAgICAgIH0KPiAKPiBXZSBjYW4ndCBraWNrIHRoZSB0YXNrbGV0IGlu c2lkZSBhIHNwaW5sb2NrLiBFc3BlY2lhbGx5IG5vdCBhIGxvY2tjbGFzcwo+IGFzIG5lc3RlZCBh cyByZXF1ZXN0LmxvY2sgOigKClllcCBib29sIGlzIHVnbHkuIFNvIG1heWJlIG1ha2UgdGhlIGhl bHBlciByZXR1cm4gc3RhdHVzLCBzbyB0aGUgY2FsbGVyIApjYW4ga2ljayBpZiBmZW5jZSB3YXMg c2lnbmFsZWQ/IE9yIHlvdSB3b3VsZCB3b3JyeSBhYm91dCBsb3NpbmcgYSBsaXR0bGUgCmJpdCBv ZiBsYXRlbmN5PyBUaGF0IGFsc28gaXMgbm90IGlkZWFsIEkgYWdyZWUuCgpUb28gYmFkLCBJIHdv dWxkIGtpbmQgb2YgbGlrZSB0byBjb25zb2xpZGF0ZSBpZiBub3RoaW5nIHRvIGJlIApzeW1tZXRy aWNhbCB3cnQgcmVxLT5sb2NrIHVzYWdlLgoKT3RoZXJ3aXNlIHBhdGNoIGxvb2tzIHNhZmUgdG8g bWUuIEF0IGxlYXN0IEkgZmFpbGVkIHRvIGZpbmQgYW55IHByb2JsZW1zLgoKUmV2aWV3ZWQtYnk6 IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZy dGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=