All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yanteng Si <si.yanteng@linux.dev>
To: Huacai Chen <chenhuacai@kernel.org>,
	Qunqin Zhao <zhaoqunqin@loongson.cn>
Cc: kuba@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com, fancer.lancer@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-loongson: Add fix_soc_reset function
Date: Tue, 21 Jan 2025 21:47:32 +0800	[thread overview]
Message-ID: <e49da678-3bed-47e0-9169-67a777edd700@linux.dev> (raw)
In-Reply-To: <CAAhV-H7LA7OBCxRzQogCbDeniY39EsxA6GVN07WM=e6EzasM0w@mail.gmail.com>


在 1/21/25 17:29, Huacai Chen 写道:
> Hi, Qunqin,
>
> The patch itself looks good to me, but something can be improved.
> 1. The title can be "net: stmmac: dwmac-loongson: Add fix_soc_reset() callback"
> 2. You lack a "." at the end of the commit message.

> 3. Add a "Cc: stable@vger.kernel.org" because it is needed to backport
> to 6.12/6.13.

Then we also need to have a fixes tag.

Thanks,

Yanteng



  reply	other threads:[~2025-01-21 13:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21  8:25 [PATCH] net: stmmac: dwmac-loongson: Add fix_soc_reset function Qunqin Zhao
2025-01-21  9:29 ` Huacai Chen
2025-01-21 13:47   ` Yanteng Si [this message]
2025-01-22  1:32     ` Qunqin Zhao
2025-01-21 18:11   ` Jakub Kicinski
2025-01-22  4:09     ` Huacai Chen
2025-01-23  3:44       ` Jakub Kicinski
2025-01-22  1:22   ` Qunqin Zhao
2025-01-21 13:41 ` Yanteng Si
2025-01-22  1:31   ` Qunqin Zhao
2025-01-22  8:53     ` Yanteng Si
2025-02-06  7:22       ` Qunqin Zhao
2025-02-06  8:36         ` Yanteng Si

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e49da678-3bed-47e0-9169-67a777edd700@linux.dev \
    --to=si.yanteng@linux.dev \
    --cc=andrew+netdev@lunn.ch \
    --cc=chenhuacai@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fancer.lancer@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=zhaoqunqin@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.