From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1FB7CD8CA8 for ; Tue, 16 Jun 2026 03:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gD6UekMhCMWuTZbJ6UBieTVY/io3jS82dlWITvROM4s=; b=lHF9LCdT86t5hrDbOlxtjPMefk XB9GDQVqAXsQsCShCvHPX2xVwGYSxyBJwf10GclwSxMaYRo9P2Uou/T4UbvtEagmsexsqTUDGpekt 1A/HgbluA1K2uP8jpF8OVKW+wREc06SDbZ/f3oyxsJu8vz0CBZMAWPJCnSJl1EYXgNGY=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wZKYT-0005ZH-BQ; Tue, 16 Jun 2026 03:33:37 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wZKYR-0005ZB-N0 for linux-f2fs-devel@lists.sourceforge.net; Tue, 16 Jun 2026 03:33:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rXV1AfD2VPtL1VYvZN3tbd31ULGRpvq9A/rjFnaZQCk=; b=Evv7fzGx8psGk2jOoDjKf0sTPE Dmh0Uprm8nl39pGY3oJUV5RP48im0vITHHQtP0GZ5STf/E/tVYnorXJlWOox5mAHvdv6fFz22QG1Z pXJHI9T9C7bVUUZHPOjyzfkWqrWF2h730rrhAQtbFx/A1J+eWNkc742h4bpT+rBUfTNY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rXV1AfD2VPtL1VYvZN3tbd31ULGRpvq9A/rjFnaZQCk=; b=CgzOttY9IAfTnNDu/CKOvHlq+d 1nURqEm0iaZ1j/arP4So5eVLZaqOIBIg/B2ZcTvgkySP+Daq5ndhs3Q5z5/LsdLWv7D6x+uIHeywg Ar4vWsZDTUUdLhdNWZB/nzAx77YWoz5CXhhHP2tds0Y2Nz5/y94x7mm7V2JlhGbqTzSA=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wZKYQ-0005cT-9z for linux-f2fs-devel@lists.sourceforge.net; Tue, 16 Jun 2026 03:33:35 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 355B9600AB for ; Tue, 16 Jun 2026 03:33:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 158421F000E9; Tue, 16 Jun 2026 03:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781580803; bh=rXV1AfD2VPtL1VYvZN3tbd31ULGRpvq9A/rjFnaZQCk=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=Of68jNtw+7/IOaFSkEtAcCT57lPE6wFWl/ekIjgOiXi5k55ooZCfxeFLIvMCOUax/ 8Z6TqidXKr8+QkxuBOTHLZlqwQVJnHE3qznhttqL2eM2lfBeTTqahaNziUwtNonyVx Myin48MF6HvBT2t9tgmMpUNsYUh+mEghRBFk1dEkx6i4TEwblOQ7tF2dxOfCbKN3ug EYi3nUd4y5MnuGLY02afgv1ZkVBwZd0etMmQYWLJ5qZrEAGxuTqESaxZkYv/k9ED6y 9ZarG87VRZ7+cZXQ42+cW9HXXNT+7oaeh1QtBaqWZGG6ZDCwsy3FKucmI3HKIRwoPK RSRhzttVli0xA== Message-ID: Date: Tue, 16 Jun 2026 11:33:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: fstests@vger.kernel.org, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20260612005802.3017709-1-chao@kernel.org> Content-Language: en-US In-Reply-To: X-Headers-End: 1wZKYQ-0005cT-9z Subject: Re: [f2fs-dev] [PATCH] f2fs/025: test to do sanity check section type correctly in f2fs GC X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gNi8xNi8yNiAwNDowNSwgWm9ycm8gTGFuZyB3cm90ZToKPiBPbiBNb24sIEp1biAxNSwgMjAy NiBhdCAwNDoyMjozNFBNICswODAwLCBDaGFvIFl1IHdyb3RlOgo+PiBPbiA2LzE1LzI2IDAxOjE2 LCBab3JybyBMYW5nIHdyb3RlOgo+Pj4gT24gRnJpLCBKdW4gMTIsIDIwMjYgYXQgMTI6NTg6MDJB TSArMDAwMCwgQ2hhbyBZdSB3cm90ZToKPj4+PiBXaXRob3V0IGNvbW1pdCA1MjA3NjBiOWY5MTUg KCJmMmZzOiBvcHRpbWl6ZSByZXByZXNlbnRhdGl2ZSB0eXBlIGRldGVybWluYXRpb24KPj4+PiBp biBHQyIpLCBmMmZzIEdDIHdpbGwgcmVwb3J0IGluY29uc2lzdGVudCBzZWdtZW50IHR5cGUgaW4g bGFyZ2Ugc2VjdGlvbiBpc3N1ZSwKPj4+PiBhbmQgdGhlbiBpdCB3aWxsIGZvcmNlIHRvIHNodXRk b3duIGZpbGVzeXN0ZW0uCj4+Pj4KPj4+PiBbICA3NjguMTkwOTAzXSBGMkZTLWZzIChsb29wNTEp OiBJbmNvbnNpc3RlbnQgc2VnbWVudCAoMykgdHlwZSBbMSwgMF0gaW4gU0lUIGFuZCBTU0EKPj4+ Pgo+Pj4+IFRoZSByZWFzb24gaXMgZjJmcyBrZXJuZWwgd2lsbCBhc3N1bWUgYWxsIHNlZ21lbnQg dHlwZSBpbnNpZGUgbGFyZ2Ugc2VjdGlvbiBpcwo+Pj4+IHRoZSBzYW1lLCBkdXJpbmcgR0MgaXQg bG9hZHMgdHlwZSBmcm9tIG9uZSBzZWdtZW50IGFuZCBjb21wYXJlIGl0IHRvIG90aGVyCj4+Pj4g c2VnbWVudHMnIHR5cGUsIGhvd2V2ZXIgZHVlIHRvIHJlY292ZXJ5IGZsb3csIHRoZSBjaG9zZW4g c2VnbWVudCBtYXkgaGFzIHplcm8KPj4+PiB2YWxpZCBibG9ja3Mgdy8gZGlmZmVyZW50IHNlZ21l bnQgdHlwZSwgc2luY2UgdGhlIHNlZ21lbnQgaXMgaW52YWxpZChmcmVlKSBvbmUsCj4+Pj4gaXQg d2lsbCBuZXZlciBiZSBtaWdyYXRlZCwgc28gdGhhdCB3ZSBzaG91bGQgbm90IHRyZWF0IHN1Y2gg c3RhdGUgYXMgYWJub3JtYWwKPj4+PiBjb25kaXRpb24uCj4+Pj4KPj4+PiBUaGlzIHRlc3RjYXNl IGlzIGNyZWF0ZWQgdG8gc2ltdWxhdGUgYWJvdmUgY29uZGl0aW9uIHRvIHNlZSB3aGV0aGVyIGYy ZnMga2VybmVsCj4+Pj4gbW9kdWxlIGNhbiBoYW5kbGUgaXQgY29ycmVjdGx5Cj4+Pj4KPj4+PiBT aWduZWQtb2ZmLWJ5OiBDaGFvIFl1IDxjaGFvQGtlcm5lbC5vcmc+Cj4+Pj4gLS0tCj4+Pj4gdjI6 Cj4+Pj4gLSBjbGVhciBNS0ZTX09QVElPTlMgYW5kIE1PVU5UX09QVElPTlMgdG8gZ3VhcmFudGVl IGJsb2NrIGFsbG9jYXRpb24gaXMgYXMgZXhwZWN0ZWQuCj4+Pgo+Pj4gSGkgQ2hhbywKPj4+Cj4+ PiBTb3JyeSwgSSBqdXN0IG5vdGljZWQgeW91ciByZXBseSB0byBteSByZXZpZXcgb24gdGhlIHBy ZXZpb3VzIHBhdGNoIHZlcnNpb24uCj4+PiBEdWUgdG8gc29tZSB1bmV4cGVjdGVkIHNoYWtlLXVw cyByZWNlbnRseSwgSeKAmXZlIGJlZW4gYm9nZ2VkIGRvd24gd2l0aCBzZXR0aW5nCj4+PiB1cCBh bmQgbW9kaWZ5aW5nIHZhcmlvdXMgbmV3IHN5c3RlbSBlbnZpcm9ubWVudHMsIGFuZCBJIGFjY2lk ZW50YWxseSBtYXJrZWQKPj4+IHNvbWUgdW5yZWFkIGVtYWlscyBhcyByZWFkLgo+Pgo+PiBObyB3 b3JyaWVzLiA6KQo+Pgo+Pj4KPj4+IFRoZSBwYXRjaCBsb29rcyBnb29kIHRvIG1lLCB3aXRoIGp1 c3QgYSBmZXcgcGlja3kgcmV2aWV3IHBvaW50cyBiZWxvdzoKPj4KPj4gVGhhbmtzIFpvcnJvIGZv ciB0YWtpbmcgYSBsb29rLgo+Pgo+Pj4KPj4+PiAgdGVzdHMvZjJmcy8wMjUgICAgIHwgOTIgKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+Pj4+ICB0ZXN0cy9m MmZzLzAyNS5vdXQgfCAgMiArCj4+Pj4gIDIgZmlsZXMgY2hhbmdlZCwgOTQgaW5zZXJ0aW9ucygr KQo+Pj4+ICBjcmVhdGUgbW9kZSAxMDA2NDQgdGVzdHMvZjJmcy8wMjUKPj4+PiAgY3JlYXRlIG1v ZGUgMTAwNjQ0IHRlc3RzL2YyZnMvMDI1Lm91dAo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL3Rlc3Rz L2YyZnMvMDI1IGIvdGVzdHMvZjJmcy8wMjUKPj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+Pj4+ IGluZGV4IDAwMDAwMDAwMC4uMzk3ZTU0MzlhCj4+Pj4gLS0tIC9kZXYvbnVsbAo+Pj4+ICsrKyBi L3Rlc3RzL2YyZnMvMDI1Cj4+Pj4gQEAgLTAsMCArMSw5MiBAQAo+Pj4+ICsjISAvYmluL2Jhc2gK Pj4+PiArIyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAo+Pj4+ICsjIENvcHlyaWdo dCAoYykgMjAyNiBDaGFvIFl1IDxjaGFvQGtlcm5lbC5vcmc+Cj4+Pj4gKyMKPj4+PiArIyBGUyBR QSBUZXN0IE5vLiBmMmZzLzAyNQo+Pj4+ICsjCj4+Pj4gKyMgQ2hlY2sgd2hldGhlciBmMmZzIHdp bGwgZW5jb3VudGVyIGNwX2Vycm9yIChJbmNvbnNpc3RlbnQgc2VnbWVudCB0eXBlKQo+Pj4+ICsj IHdoZW4gZG9pbmcgc2FuaXR5IGNoZWNrIG9uIHR5cGUgb2Ygc2VnbWVudHMgaW5zaWRlIGxhcmdl IHNlY3Rpb24gZHVyaW5nCj4+Pj4gKyMgZ2FyYmFnZSBjb2xsZWN0aW9uLgo+Pj4+ICsjCj4+Pj4g Ky4gLi9jb21tb24vcHJlYW1ibGUKPj4+PiArX2JlZ2luX2ZzdGVzdCBhdXRvIHF1aWNrCj4+Pj4g Kwo+Pj4+ICtfZml4ZWRfYnlfa2VybmVsX2NvbW1pdCA1MjA3NjBiOWY5MTUgXAo+Pj4+ICsJImYy ZnM6IG9wdGltaXplIHJlcHJlc2VudGF0aXZlIHR5cGUgZGV0ZXJtaW5hdGlvbiBpbiBHQyIKPj4+ PiArCj4+Pj4gKy4gLi9jb21tb24vZmlsdGVyCj4+Pj4gKwo+Pj4+ICtfY2xlYW51cCgpCj4+Pj4g K3sKPj4+PiArCWNkIC8KPj4+PiArCXJtIC1yIC1mICR0bXAuKgo+Pj4+ICt9Cj4+Pgo+Pj4gVGhp cyBfY2xlYW51cCgpIGZ1bmN0aW9uIGlzIHNhbWUgYXMgZGVmYXVsdC4gSXQgY2FuIGJlIHJlbW92 ZWQuCj4+Cj4+IFdpbGwgcmVtb3ZlLgo+Pgo+Pj4KPj4+PiArCj4+Pj4gK19yZXF1aXJlX3NjcmF0 Y2gKPj4+PiArX3JlcXVpcmVfeGZzX2lvX2NvbW1hbmQgInB3cml0ZSIKPj4+PiArX3JlcXVpcmVf eGZzX2lvX2NvbW1hbmQgInRydW5jYXRlIgo+Pj4+ICtfcmVxdWlyZV9jb21tYW5kICIkRjJGU19J T19QUk9HIiBmMmZzX2lvCj4+Pj4gK19yZXF1aXJlX2NoZWNrX2RtZXNnCj4+Pj4gKwo+Pj4+ICsj IENsZWFyIG9wdGlvbnMgdG8gYXZvaWQgaW50ZXJmZXJlbmNlIGZyb20gZXh0ZXJuYWwgY29uZmln dXJhdGlvbnMKPj4+PiArZXhwb3J0IE1LRlNfT1BUSU9OUz0iIgo+Pj4+ICtleHBvcnQgTU9VTlRf T1BUSU9OUz0iIgo+Pj4+ICsKPj4+PiArIyBGb3JtYXQgd2l0aCA5Nk1CIHNpemUgYW5kIDIgc2Vn bWVudHMgcGVyIHNlY3Rpb24KPj4+PiArX3NjcmF0Y2hfbWtmc19zaXplZCAkKCg5NiAqIDEwMjQg KiAxMDI0KSkgIiIgIi1zIDIiID4+ICRzZXFyZXMuZnVsbCAyPiYxCj4+Pj4gKwo+Pj4+ICsjIE1v dW50IHdpdGggbW9kZT1sZnMKPj4+PiArX3NjcmF0Y2hfbW91bnQgLW8gbW9kZT1sZnMgPj4gJHNl cXJlcy5mdWxsIDI+JjEKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5eXl5eXl5e Xl5eXl5eXl5eXl5eCj4+PiBJdCdzIGhlbHBsZXNzLCBkdWUgdG8gaWYgX3NjcmF0Y2hfbW91bnQg ZmFpbHMsIGl0IGV4aXQoKSBkaXJlY3RseS4KPj4KPj4gUmlnaHQsIHdpbGwgZml4Lgo+Pgo+Pj4K Pj4+PiArCj4+Pj4gKyMgQ3JlYXRlIGZpbGVzIHRvIGZpbGwgd2hvbGUgZmlsZXN5c3RlbSwgdGhl biBzZWdtZW50IHR5cGUgd2lsbCBiZSBjaGFuZ2VkIHRvIG5vZGUgdHlwZQo+Pj4+ICtmb3IgKChp PTA7aTw1MTIwO2krKykpIGRvCj4+Pj4gKwl0b3VjaCAkU0NSQVRDSF9NTlQvJGkgPj4gJHNlcXJl cy5mdWxsIDI+JjEKPj4+PiArZG9uZQo+Pj4+ICtzeW5jCj4+Pj4gKwo+Pj4+ICsjIFJlbW92ZSBh bGwgZmlsZXMgdG8gY3JlYXRlIGZyZWUoZW1wdHkpIG5vZGUgc2VnbWVudHMKPj4+PiArcm0gLWYg JFNDUkFUQ0hfTU5ULyoKPj4+PiArc3luYwo+Pj4+ICsKPj4+PiArIyBBbGxvY2F0ZSBmcmVlIHNw YWNlIHNvIHRoYXQgd2UgaGF2ZSBjaGFuY2UgdG8gcmV1c2UgZnJlZShlbXB0eSkgbm9kZSBzZWdt ZW50cwo+Pj4+ICskWEZTX0lPX1BST0cgLWYgLWMgInB3cml0ZSAtYiA0ayAwIDE5MjhrIiAkU0NS QVRDSF9NTlQvZmlsZSA+PiAkc2VxcmVzLmZ1bGwgMj4mMQo+Pj4+ICtzeW5jCj4+Pj4gKwo+Pj4+ ICskWEZTX0lPX1BST0cgLWMgInRydW5jYXRlIDAiICRTQ1JBVENIX01OVC9maWxlID4+ICRzZXFy ZXMuZnVsbCAyPiYxCj4+Pj4gKyRYRlNfSU9fUFJPRyAtZCAtYyAicHdyaXRlIC1iIDRrIDAgMTZN IiAkU0NSQVRDSF9NTlQvZmlsZSA+PiAkc2VxcmVzLmZ1bGwgMj4mMQo+Pj4+ICskWEZTX0lPX1BS T0cgLWMgInRydW5jYXRlIDAiICRTQ1JBVENIX01OVC9maWxlID4+ICRzZXFyZXMuZnVsbCAyPiYx Cj4+Pj4gKyRYRlNfSU9fUFJPRyAtZCAtYyAicHdyaXRlIC1iIDRrIDAgMTZNIiAkU0NSQVRDSF9N TlQvZmlsZSA+PiAkc2VxcmVzLmZ1bGwgMj4mMQo+Pj4+ICskWEZTX0lPX1BST0cgLWMgInRydW5j YXRlIDAiICRTQ1JBVENIX01OVC9maWxlID4+ICRzZXFyZXMuZnVsbCAyPiYxCj4+Pj4gK3N5bmMK Pj4+PiArCj4+Pj4gKyRYRlNfSU9fUFJPRyAtZCAtYyAicHdyaXRlIC1iIDRrIDAgOE0iICRTQ1JB VENIX01OVC9maWxlID4+ICRzZXFyZXMuZnVsbCAyPiYxCj4+Pj4gKyRYRlNfSU9fUFJPRyAtYyAi dHJ1bmNhdGUgMCIgJFNDUkFUQ0hfTU5UL2ZpbGUgPj4gJHNlcXJlcy5mdWxsIDI+JjEKPj4+PiAr JFhGU19JT19QUk9HIC1kIC1jICJwd3JpdGUgLWIgNGsgMCAzMksiICRTQ1JBVENIX01OVC9maWxl ID4+ICRzZXFyZXMuZnVsbCAyPiYxCj4+Pj4gKyRYRlNfSU9fUFJPRyAtYyAidHJ1bmNhdGUgMCIg JFNDUkFUQ0hfTU5UL2ZpbGUgPj4gJHNlcXJlcy5mdWxsIDI+JjEKPj4+PiArJFhGU19JT19QUk9H IC1kIC1jICJwd3JpdGUgLWIgNGsgMCAyTSIgLWMgImZzeW5jIiAkU0NSQVRDSF9NTlQvZmlsZSA+ PiAkc2VxcmVzLmZ1bGwgMj4mMQo+Pj4+ICsKPj4+PiArIyBTaHV0ZG93biB0aGUgZmlsZXN5c3Rl bSB3aXRob3V0IGNoZWNrcG9pbnQKPj4+PiArJEYyRlNfSU9fUFJPRyBzaHV0ZG93biAyICRTQ1JB VENIX01OVCA+PiAkc2VxcmVzLmZ1bGwgMj4mMQo+Pj4KPj4+IEknbSB3b25kZXJpbmcgaWYgd2Ug Y2FuIGhhdmUgZjJmcyBzdXBwb3J0aW5nIGluIGNvbW1vbiBfc2NyYXRjaF9zaHV0ZG93bgo+Pj4g aGVscGVyIDopCj4+Cj4+IEkgdGhpbmsgd2UgY2FuIGNoYW5nZSBmMmZzIHRlc3RjYXNlIHRvIHVz ZSBfc2NyYXRjaF9zaHV0ZG93biBiZWNhdXNlIHRoZSBkZWZpbml0aW9uIG9mCj4+IG5vbG9nZmx1 c2ggc2h1dGRvd24gaW50ZXJmYWNlIGlzIHRoZSBzYW1lIGFzIHhmcyc6Cj4+Cj4+IC8qCj4+ICAq IHNob3VsZCBiZSBzYW1lIGFzIFhGU19JT0NfR09JTkdET1dOLgo+PiAgKiBGbGFncyBmb3IgZ29p bmcgZG93biBvcGVyYXRpb24gdXNlZCBieSBGU19JT0NfR09JTkdET1dOCj4+ICAqLwo+PiAjZGVm aW5lIEYyRlNfSU9DX1NIVVRET1dOCV9JT1IoJ1gnLCAxMjUsIF9fdTMyKQkvKiBTaHV0ZG93biAq Lwo+PiAjZGVmaW5lIEYyRlNfR09JTkdfRE9XTl9OT1NZTkMJCTB4MgkvKiBnb2luZyBkb3duICov Cj4+Cj4+ICNkZWZpbmUgWEZTX0lPQ19HT0lOR0RPV04JICAgICBfSU9SICgnWCcsIDEyNSwgdWlu dDMyX3QpCj4+ICNkZWZpbmUgWEZTX0ZTT1BfR09JTkdfRkxBR1NfTk9MT0dGTFVTSAkJMHgyCS8q IGRvbid0IGZsdXNoIGxvZyBub3IgZGF0YSAqLwo+Pgo+Pj4KPj4+PiArCj4+Pj4gK19zY3JhdGNo X3VubW91bnQgPj4gJHNlcXJlcy5mdWxsIDI+JjEKPj4+ICAgICAgICAgICAgICAgICAgICAgXl5e Xl5eXl5eXl5eXl5eXl5eXl4KPj4+Cj4+PiBJZiB1bm1vdW50IGZhaWxzLCBob3cgYWJvdXQgbGV0 IGl0IG91dHB1dCB0aGUgZXJyb3JzLCB0byBicmVhayB0aGUgZ29sZGVuIGltYWdlPwo+Pgo+PiBZ ZXMsIGl0J3MgYmV0dGVyLgo+Pgo+Pj4KPj4+PiArCj4+Pj4gK19zY3JhdGNoX21vdW50IC1vIG1v ZGU9bGZzID4+ICRzZXFyZXMuZnVsbCAyPiYxCj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBeXl5eXl5eXl5eXl5eXl5eXl5eXgo+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaGVscGxlc3MKPj4KPj4gV2lsbCBmaXguCj4+Cj4+Pgo+Pj4+ICsKPj4+PiArIyBSdW4gdXJn ZW50X2djIG1vZGUgdG8gdHJpZ2dlciBnYXJiYWdlIGNvbGxlY3Rpb24KPj4+PiArZGV2X25hbWU9 JChfc2hvcnRfZGV2ICRTQ1JBVENIX0RFVikKPj4+PiAraWYgWyAtZiAvc3lzL2ZzL2YyZnMvJGRl dl9uYW1lL2djX3VyZ2VudCBdOyB0aGVuCj4+Pj4gKwllY2hvIDEgPiAvc3lzL2ZzL2YyZnMvJGRl dl9uYW1lL2djX3VyZ2VudAo+Pj4+ICtmaQo+Pj4KPj4+IEhtbS4uLiB3aGF0IGlmIHRoZXJlJ3Mg bm90IC9zeXMvZnMvZjJmcy8kZGV2X25hbWUvZ2NfdXJnZW50PyBEb2VzIGl0Cj4+PiBhZmZlY3Qg dGhlIHRlc3QgcmVzdWx0Pwo+Pj4KPj4+IElmIGl0IGRvZXMsIHRoaXMncyBhIG5lY2Vzc2FyeSBy ZXF1aXJlbWVudCBmb3IgdGhpcyB0ZXN0LCB3ZSBzaG91bGRuJ3QKPj4+IGlnbm9yZSBpdCBhbmQg a2VlcCBydW5uaW5nLiBEb2VzICRGMkZTX0lPX1BST0cgcHJvdmlkZSBhIGNvbW1hbmQgdG8KPj4+ IG1ha2UgYSBmb3JjZSBHQz8gT3Igd2UgbmVlZCB0byBjaGVjayB0aGlzIGZpbGUgYW5kIF9ub3Ry dW4gaWYgaXQncwo+Pj4gbm90IGV4aXN0ZWQuCj4+Cj4+IEFoLCByaWdodCwgdGhhdCdzIGdvb2Qg cG9pbnQhCj4+Cj4+IFdlIGNhbiB1c2UgIiRGMkZTX0lPX1BST0cgZ2NfdXJnZW50IDxkZXZfbmFt ZT4gcnVuIDUiIGluc3RlYWQsIGl0IHdpbGwgZG8gYmVsb3cgY29tbWFuZHM6Cj4gCj4gR3JlYXQs IEkganVzdCBob3BlIHRoZSAqZ2NfdXJnZW50KiBpc24ndCBhIG5ldyBmZWF0dXJlIHdoaWNoIG5l ZWRzIHNvbWV0aGluZyBsaWtlczoKCkkgZ3Vlc3MgaXQncyBub3QgYSBuZXcgc3ViY29tbWFuZCBm b3IgZjJmc19pbywKCmNvbW1pdCAyMmQ3NThlMmU2YWYyMTBkYzllNmNkZjk5NDM4ZjA2MzM4M2Jh NzJmCkF1dGhvcjogSmFlZ2V1ayBLaW0gPGphZWdldWtAa2VybmVsLm9yZz4KRGF0ZTogICBUdWUg RmViIDE5IDE5OjA3OjIxIDIwMTkgLTA4MDAKCiAgICBmMmZzX2lvOiBhZGQgZ2NfdXJnZW50Cgog ICAgZS5nLiwKICAgIGYyZnNfaW8gZ2NfdXJnZW50IGRtLTQgW3N0YXJ0L2VuZC9ydW5dIFt0aW1l IGluIHNlY10KCiAgICBUaGlzIGNvbnRyb2xzIHN5c2ZzL2djX3VyZ2VudCB0byBydW4gZjJmc19n YyB1cmdlbnRseS4KCiAgICBTaWduZWQtb2ZmLWJ5OiBKYWVnZXVrIEtpbSA8amFlZ2V1a0BrZXJu ZWwub3JnPgoKPiBgX3JlcXVpcmVfZjJmc19pbyBnY191cmdlbnRgICh0aGVyZSdzIG5vdCBfcmVx dWlyZV9mMmZzX2lvOikKCkFncmVlZCwgd2UgbmVlZCB0byBpbnRyb2R1Y2UgX3JlcXVpcmVfZjJm c19pbygpLCBsZXQgbWUgd29yayBvbiB0aGlzLgoKPiAKPj4gMS4gZWNobyAxID4gL3N5cy9mcy9m MmZzLyRkZXZfbmFtZS9nY191cmdlbnQKPj4gMi4gc2xlZXAgNSBzZWNvbmRzCj4+IDMuIGVjaG8g MCA+IC9zeXMvZnMvZjJmcy8kZGV2X25hbWUvZ2NfdXJnZW50Cj4gCj4gSXQgYWxzbyBkZXBlbmRz IG9uIHRoZSAvc3lzL2ZzL2YyZnMvJGRldl9uYW1lL2djX3VyZ2VudCB0b28uIFNvIHdlIGhhdmUg dG8gZmFjZQo+IHRoZSBzYW1lIHF1ZXN0aW9uOgo+ICAgSWYgdGhpcyBmaWxlIGRvZXNuJ3QgZXhp c3QsIHNob3VsZCB0aGlzIHRlc3QgY2FzZSBfbm90cnVuPwoKT2gsIHJpZ2h0LCBtYXliZSB3ZSBj YW4gaW50cm9kdWNlIF9yZXF1aXJlX2YyZnNfc3lzZnMoKSB0byBjaGVjayB3aGV0aGVyIGYyZnMg a2VybmVsCm1vZHVsZSBoYXMgc3VwcG9ydGVkIHRhcmdldCBzeXNmcyBub2RlPwoKVGhhbmtzLAoK PiAKPiBUaGFua3MsCj4gWm9ycm8KPiAKPj4KPj4+Cj4+Pj4gKwo+Pj4+ICsjIFdhaXQgYmFja2dy b3VuZCBHQyB0aHJlYWQgdG8gd2FrZSB1cCB0byBydW4gYW5kIHBvdGVudGlhbGx5IGVuY291bnRl ciB0aGUgaW5jb25zaXN0ZW5jeQo+Pj4+ICtzbGVlcCA1Cj4+Pgo+Pj4gRG9lcyB0aGlzIHNsZWVw IHRyeSB0byB3YWl0IGFib3ZlICJlY2hvIDEgPiAvc3lzL2ZzL2YyZnMvJGRldl9uYW1lL2djX3Vy Z2VudCI/Cj4+PiBJZiBzbywgaXQgbWFrZXMgbW9yZSBzZW5zZSB0byBtb3ZlIGl0IGludG8gdGhl ICJpZi10aGVuIiBsb2dpYy4KPj4+Cj4+Pj4gKwo+Pj4+ICtfc2NyYXRjaF91bm1vdW50ID4+ICRz ZXFyZXMuZnVsbCAyPiYxCj4+PiAgICAgICAgICAgICAgICAgICAgIF5eXl5eXl5eXl5eXl5eXl5e Xl5eCj4+PiBTYW1lIGFzIGFib3ZlLgo+Pgo+PiBXaWxsIGZpeC4KPj4KPj4+Cj4+Pj4gKwo+Pj4+ ICsjIENoZWNrIHdoZXRoZXIgdGhlIGRtZXNnIGhhcyB0aGUgd2FybmluZyBpbmRpY2F0aW5nIHRo ZSBidWcKPj4+PiArX2NoZWNrX2RtZXNnX2ZvciAiRjJGUy1mcyBcKCRkZXZfbmFtZVwpOiBJbmNv bnNpc3RlbnQgc2VnbWVudCIgJiYgXAo+Pj4+ICsJX2ZhaWwgIkYyRlMtZnMgKCRkZXZfbmFtZSk6 IEluY29uc2lzdGVudCBzZWdtZW50IHR5cGUgZGV0ZWN0ZWQgaW4gZG1lc2chIgo+Pj4+ICsKPj4+ PiArZWNobyAiU2lsZW5jZSBpcyBnb2xkZW4iCj4+Pj4gK3N0YXR1cz0wCj4+Pj4gK2V4aXQKPj4+ Cj4+PiBXZSd2ZSByZXBsYWNlZCAic3RhdHVzPTA7ZXhpdDsiIHdpdGggIl9leGl0IDAiLgo+Pgo+ PiBXaWxsIGZpeC4KPj4KPj4gVGhhbmtzLAo+Pgo+Pj4KPj4+IFRoYW5rcywKPj4+IFpvcnJvCj4+ Pgo+Pj4+IGRpZmYgLS1naXQgYS90ZXN0cy9mMmZzLzAyNS5vdXQgYi90ZXN0cy9mMmZzLzAyNS5v dXQKPj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+Pj4+IGluZGV4IDAwMDAwMDAwMC4uM2Q3MDk1 MWVmCj4+Pj4gLS0tIC9kZXYvbnVsbAo+Pj4+ICsrKyBiL3Rlc3RzL2YyZnMvMDI1Lm91dAo+Pj4+ IEBAIC0wLDAgKzEsMiBAQAo+Pj4+ICtRQSBvdXRwdXQgY3JlYXRlZCBieSAwMjUKPj4+PiArU2ls ZW5jZSBpcyBnb2xkZW4KPj4+PiAtLSAKPj4+PiAyLjQ5LjAKPj4+Pgo+Pgo+PgoKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1mMmZzLWRldmVs IG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRw czovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZzLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05BAF17555 for ; Tue, 16 Jun 2026 03:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781580805; cv=none; b=Wz9AnxcQ8qbCe4L2AB2iwzVEIXfJA9KFbii0FCRRVmRFRt360PSnn+JqWU9af+U0XHZWhEYOBRsgx6qAhoKU6cEMRJwdLbWBJWRWsz1x3+hMfznKwmvoCZ7/khoZolX+h+BrpoV0xFzWafILv39Crvu0/cFxahV/4OKimD0guIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781580805; c=relaxed/simple; bh=zF6hqx1ra7GG/J8W1nlETBKJgYLoW2WznXGBfV5q+HE=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=AelNebVv8VILOhxngBhiTkyZic1GD0gUECjMMnbWlPT4p+meTPChZPNKyjlvXI4BUzMCCNgIYdkFxzu9OE2UqNmlm9TN3ZzcROUAj/dd09agTMqb2VwktpQzgSeGRbXrlXvYXGBGBui45iUc+nVT2UFcMIagAVMCmCsS7ZnIUN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Of68jNtw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Of68jNtw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 158421F000E9; Tue, 16 Jun 2026 03:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781580803; bh=rXV1AfD2VPtL1VYvZN3tbd31ULGRpvq9A/rjFnaZQCk=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=Of68jNtw+7/IOaFSkEtAcCT57lPE6wFWl/ekIjgOiXi5k55ooZCfxeFLIvMCOUax/ 8Z6TqidXKr8+QkxuBOTHLZlqwQVJnHE3qznhttqL2eM2lfBeTTqahaNziUwtNonyVx Myin48MF6HvBT2t9tgmMpUNsYUh+mEghRBFk1dEkx6i4TEwblOQ7tF2dxOfCbKN3ug EYi3nUd4y5MnuGLY02afgv1ZkVBwZd0etMmQYWLJ5qZrEAGxuTqESaxZkYv/k9ED6y 9ZarG87VRZ7+cZXQ42+cW9HXXNT+7oaeh1QtBaqWZGG6ZDCwsy3FKucmI3HKIRwoPK RSRhzttVli0xA== Message-ID: Date: Tue, 16 Jun 2026 11:33:20 +0800 Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org Subject: Re: [PATCH] f2fs/025: test to do sanity check section type correctly in f2fs GC To: fstests@vger.kernel.org, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20260612005802.3017709-1-chao@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/16/26 04:05, Zorro Lang wrote: > On Mon, Jun 15, 2026 at 04:22:34PM +0800, Chao Yu wrote: >> On 6/15/26 01:16, Zorro Lang wrote: >>> On Fri, Jun 12, 2026 at 12:58:02AM +0000, Chao Yu wrote: >>>> Without commit 520760b9f915 ("f2fs: optimize representative type determination >>>> in GC"), f2fs GC will report inconsistent segment type in large section issue, >>>> and then it will force to shutdown filesystem. >>>> >>>> [ 768.190903] F2FS-fs (loop51): Inconsistent segment (3) type [1, 0] in SIT and SSA >>>> >>>> The reason is f2fs kernel will assume all segment type inside large section is >>>> the same, during GC it loads type from one segment and compare it to other >>>> segments' type, however due to recovery flow, the chosen segment may has zero >>>> valid blocks w/ different segment type, since the segment is invalid(free) one, >>>> it will never be migrated, so that we should not treat such state as abnormal >>>> condition. >>>> >>>> This testcase is created to simulate above condition to see whether f2fs kernel >>>> module can handle it correctly >>>> >>>> Signed-off-by: Chao Yu >>>> --- >>>> v2: >>>> - clear MKFS_OPTIONS and MOUNT_OPTIONS to guarantee block allocation is as expected. >>> >>> Hi Chao, >>> >>> Sorry, I just noticed your reply to my review on the previous patch version. >>> Due to some unexpected shake-ups recently, I’ve been bogged down with setting >>> up and modifying various new system environments, and I accidentally marked >>> some unread emails as read. >> >> No worries. :) >> >>> >>> The patch looks good to me, with just a few picky review points below: >> >> Thanks Zorro for taking a look. >> >>> >>>> tests/f2fs/025 | 92 ++++++++++++++++++++++++++++++++++++++++++++++ >>>> tests/f2fs/025.out | 2 + >>>> 2 files changed, 94 insertions(+) >>>> create mode 100644 tests/f2fs/025 >>>> create mode 100644 tests/f2fs/025.out >>>> >>>> diff --git a/tests/f2fs/025 b/tests/f2fs/025 >>>> new file mode 100644 >>>> index 000000000..397e5439a >>>> --- /dev/null >>>> +++ b/tests/f2fs/025 >>>> @@ -0,0 +1,92 @@ >>>> +#! /bin/bash >>>> +# SPDX-License-Identifier: GPL-2.0 >>>> +# Copyright (c) 2026 Chao Yu >>>> +# >>>> +# FS QA Test No. f2fs/025 >>>> +# >>>> +# Check whether f2fs will encounter cp_error (Inconsistent segment type) >>>> +# when doing sanity check on type of segments inside large section during >>>> +# garbage collection. >>>> +# >>>> +. ./common/preamble >>>> +_begin_fstest auto quick >>>> + >>>> +_fixed_by_kernel_commit 520760b9f915 \ >>>> + "f2fs: optimize representative type determination in GC" >>>> + >>>> +. ./common/filter >>>> + >>>> +_cleanup() >>>> +{ >>>> + cd / >>>> + rm -r -f $tmp.* >>>> +} >>> >>> This _cleanup() function is same as default. It can be removed. >> >> Will remove. >> >>> >>>> + >>>> +_require_scratch >>>> +_require_xfs_io_command "pwrite" >>>> +_require_xfs_io_command "truncate" >>>> +_require_command "$F2FS_IO_PROG" f2fs_io >>>> +_require_check_dmesg >>>> + >>>> +# Clear options to avoid interference from external configurations >>>> +export MKFS_OPTIONS="" >>>> +export MOUNT_OPTIONS="" >>>> + >>>> +# Format with 96MB size and 2 segments per section >>>> +_scratch_mkfs_sized $((96 * 1024 * 1024)) "" "-s 2" >> $seqres.full 2>&1 >>>> + >>>> +# Mount with mode=lfs >>>> +_scratch_mount -o mode=lfs >> $seqres.full 2>&1 >>> ^^^^^^^^^^^^^^^^^^^^ >>> It's helpless, due to if _scratch_mount fails, it exit() directly. >> >> Right, will fix. >> >>> >>>> + >>>> +# Create files to fill whole filesystem, then segment type will be changed to node type >>>> +for ((i=0;i<5120;i++)) do >>>> + touch $SCRATCH_MNT/$i >> $seqres.full 2>&1 >>>> +done >>>> +sync >>>> + >>>> +# Remove all files to create free(empty) node segments >>>> +rm -f $SCRATCH_MNT/* >>>> +sync >>>> + >>>> +# Allocate free space so that we have chance to reuse free(empty) node segments >>>> +$XFS_IO_PROG -f -c "pwrite -b 4k 0 1928k" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> +sync >>>> + >>>> +$XFS_IO_PROG -c "truncate 0" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> +$XFS_IO_PROG -d -c "pwrite -b 4k 0 16M" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> +$XFS_IO_PROG -c "truncate 0" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> +$XFS_IO_PROG -d -c "pwrite -b 4k 0 16M" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> +$XFS_IO_PROG -c "truncate 0" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> +sync >>>> + >>>> +$XFS_IO_PROG -d -c "pwrite -b 4k 0 8M" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> +$XFS_IO_PROG -c "truncate 0" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> +$XFS_IO_PROG -d -c "pwrite -b 4k 0 32K" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> +$XFS_IO_PROG -c "truncate 0" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> +$XFS_IO_PROG -d -c "pwrite -b 4k 0 2M" -c "fsync" $SCRATCH_MNT/file >> $seqres.full 2>&1 >>>> + >>>> +# Shutdown the filesystem without checkpoint >>>> +$F2FS_IO_PROG shutdown 2 $SCRATCH_MNT >> $seqres.full 2>&1 >>> >>> I'm wondering if we can have f2fs supporting in common _scratch_shutdown >>> helper :) >> >> I think we can change f2fs testcase to use _scratch_shutdown because the definition of >> nologflush shutdown interface is the same as xfs': >> >> /* >> * should be same as XFS_IOC_GOINGDOWN. >> * Flags for going down operation used by FS_IOC_GOINGDOWN >> */ >> #define F2FS_IOC_SHUTDOWN _IOR('X', 125, __u32) /* Shutdown */ >> #define F2FS_GOING_DOWN_NOSYNC 0x2 /* going down */ >> >> #define XFS_IOC_GOINGDOWN _IOR ('X', 125, uint32_t) >> #define XFS_FSOP_GOING_FLAGS_NOLOGFLUSH 0x2 /* don't flush log nor data */ >> >>> >>>> + >>>> +_scratch_unmount >> $seqres.full 2>&1 >>> ^^^^^^^^^^^^^^^^^^^^ >>> >>> If unmount fails, how about let it output the errors, to break the golden image? >> >> Yes, it's better. >> >>> >>>> + >>>> +_scratch_mount -o mode=lfs >> $seqres.full 2>&1 >>> ^^^^^^^^^^^^^^^^^^^^ >>> helpless >> >> Will fix. >> >>> >>>> + >>>> +# Run urgent_gc mode to trigger garbage collection >>>> +dev_name=$(_short_dev $SCRATCH_DEV) >>>> +if [ -f /sys/fs/f2fs/$dev_name/gc_urgent ]; then >>>> + echo 1 > /sys/fs/f2fs/$dev_name/gc_urgent >>>> +fi >>> >>> Hmm... what if there's not /sys/fs/f2fs/$dev_name/gc_urgent? Does it >>> affect the test result? >>> >>> If it does, this's a necessary requirement for this test, we shouldn't >>> ignore it and keep running. Does $F2FS_IO_PROG provide a command to >>> make a force GC? Or we need to check this file and _notrun if it's >>> not existed. >> >> Ah, right, that's good point! >> >> We can use "$F2FS_IO_PROG gc_urgent run 5" instead, it will do below commands: > > Great, I just hope the *gc_urgent* isn't a new feature which needs something likes: I guess it's not a new subcommand for f2fs_io, commit 22d758e2e6af210dc9e6cdf99438f063383ba72f Author: Jaegeuk Kim Date: Tue Feb 19 19:07:21 2019 -0800 f2fs_io: add gc_urgent e.g., f2fs_io gc_urgent dm-4 [start/end/run] [time in sec] This controls sysfs/gc_urgent to run f2fs_gc urgently. Signed-off-by: Jaegeuk Kim > `_require_f2fs_io gc_urgent` (there's not _require_f2fs_io:) Agreed, we need to introduce _require_f2fs_io(), let me work on this. > >> 1. echo 1 > /sys/fs/f2fs/$dev_name/gc_urgent >> 2. sleep 5 seconds >> 3. echo 0 > /sys/fs/f2fs/$dev_name/gc_urgent > > It also depends on the /sys/fs/f2fs/$dev_name/gc_urgent too. So we have to face > the same question: > If this file doesn't exist, should this test case _notrun? Oh, right, maybe we can introduce _require_f2fs_sysfs() to check whether f2fs kernel module has supported target sysfs node? Thanks, > > Thanks, > Zorro > >> >>> >>>> + >>>> +# Wait background GC thread to wake up to run and potentially encounter the inconsistency >>>> +sleep 5 >>> >>> Does this sleep try to wait above "echo 1 > /sys/fs/f2fs/$dev_name/gc_urgent"? >>> If so, it makes more sense to move it into the "if-then" logic. >>> >>>> + >>>> +_scratch_unmount >> $seqres.full 2>&1 >>> ^^^^^^^^^^^^^^^^^^^^ >>> Same as above. >> >> Will fix. >> >>> >>>> + >>>> +# Check whether the dmesg has the warning indicating the bug >>>> +_check_dmesg_for "F2FS-fs \($dev_name\): Inconsistent segment" && \ >>>> + _fail "F2FS-fs ($dev_name): Inconsistent segment type detected in dmesg!" >>>> + >>>> +echo "Silence is golden" >>>> +status=0 >>>> +exit >>> >>> We've replaced "status=0;exit;" with "_exit 0". >> >> Will fix. >> >> Thanks, >> >>> >>> Thanks, >>> Zorro >>> >>>> diff --git a/tests/f2fs/025.out b/tests/f2fs/025.out >>>> new file mode 100644 >>>> index 000000000..3d70951ef >>>> --- /dev/null >>>> +++ b/tests/f2fs/025.out >>>> @@ -0,0 +1,2 @@ >>>> +QA output created by 025 >>>> +Silence is golden >>>> -- >>>> 2.49.0 >>>> >> >>