From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E83CAC79FB9 for ; Thu, 10 Sep 2026 08:55:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x4aYx-0002Kt-FK; Thu, 10 Sep 2026 04:55:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4aYv-0002KN-Qn for qemu-devel@nongnu.org; Thu, 10 Sep 2026 04:55:18 -0400 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4aYt-0000nv-RF for qemu-devel@nongnu.org; Thu, 10 Sep 2026 04:55:17 -0400 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A6B27600CB; Thu, 10 Sep 2026 08:55:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 110541F000FF; Thu, 10 Sep 2026 08:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789030514; bh=5Evwcv3CFPuOEnakF/pLn7+JX2ybeUrgDFbedbxqFis=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=D+6eU+Im/0vLVE1k6EpLrlnlR85WpyfrM7keSOl+ODRofSIyAu1cJtC9T3cM+sEam /NkWsGpMvNphOnO99JrAUdO6prvcLNRMnUZr1TDAfbU9K+KiQkoib8o9nPweNqBirq ExB47AwrU7jQao6dd/Hs+GxWqtvlqe8cb/SVPcByx/3eqkYwQcWHcXdYClqhfWDtRh ivpezmy4jOmaYRMe+bGZvrLjbJUT7tcinpuwnI748oYNphmeFPSrFvZsunXLTxHnFP uSZDQEs2R2dBPb4WA53TbQ+dHubYy9X27fEqAYLfVmfcnl4lAQkL4csBuwbaTJtzhu qp3OjRkfTh9fA== Message-ID: Date: Thu, 10 Sep 2026 10:55:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 09/12] machine: Rename machine_require_guest_memfd() to *_private() To: Michael Roth , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, berrange@redhat.com, armbru@redhat.com, pankaj.gupta@amd.com, isaku.yamahata@intel.com, xiaoyao.li@intel.com, chao.p.peng@linux.intel.com, Peter Xu References: <20260908133151.836685-1-michael.roth@amd.com> <20260908133151.836685-10-michael.roth@amd.com> From: David Hildenbrand Content-Language: en-US In-Reply-To: <20260908133151.836685-10-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2600:3c04:e001:324:0:1991:8:25; envelope-from=david@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 9/8/26 15:30, Michael Roth wrote: > From: Peter Xu > > Differenciate it from fully shared guest-memfd use cases. s/Differenciate/Differentiate/ > > When at it, add proper brackets in kvm_handle_hc_map_gpa_range() otherwise > checkpatch may complain. Why is this patch not moved further up, where we rename other stuff? Reviewed-by: David Hildenbrand -- Cheers, David