From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF38C433F5 for ; Fri, 11 Feb 2022 20:46:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232014AbiBKUqg (ORCPT ); Fri, 11 Feb 2022 15:46:36 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbiBKUqg (ORCPT ); Fri, 11 Feb 2022 15:46:36 -0500 Received: from mxout01.lancloud.ru (mxout01.lancloud.ru [45.84.86.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D8B61A2; Fri, 11 Feb 2022 12:46:33 -0800 (PST) Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout01.lancloud.ru CF85C20AC19D Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH] sh: avoid using IRQ0 on SH3/4 To: John Paul Adrian Glaubitz , Rich Felker , , CC: Yoshinori Sato References: <2f419ed2-66b8-4098-7cd3-0fe698d341c9@omp.ru> <63f06bf0-fc7b-3c5c-8af9-5adfd7628354@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Fri, 11 Feb 2022 23:46:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On 2/11/22 11:30 PM, John Paul Adrian Glaubitz wrote: [...] >>> Using IRQ0 by the platform devices is going to be disallowed soon (see [1]) >>> and the code supporting SH3/4 SoCs maps the IRQ #s starting at 0 -- modify >>> that code to start the IRQ #s from 16 instead. >>> >>> [1] https://lore.kernel.org/all/5e001ec1-d3f1-bcb8-7f30-a6301fd9930c@omp.ru/ >>> >>> Signed-off-by: Sergey Shtylyov >>> >>> --- >>> The patch is against Linus Torvalds' 'linux.git' repo. >>> >>> arch/sh/kernel/cpu/sh3/entry.S | 4 ++-- >>> include/linux/sh_intc.h | 6 +++--- >>> 2 files changed, 5 insertions(+), 5 deletions(-) >>> >>> Index: linux/arch/sh/kernel/cpu/sh3/entry.S >>> =================================================================== >>> --- linux.orig/arch/sh/kernel/cpu/sh3/entry.S >>> +++ linux/arch/sh/kernel/cpu/sh3/entry.S >>> @@ -470,9 +470,9 @@ ENTRY(handle_interrupt) >>> mov r4, r0 ! save vector->jmp table offset for later >>> >>> shlr2 r4 ! vector to IRQ# conversion >>> - add #-0x10, r4 >>> >>> - cmp/pz r4 ! is it a valid IRQ? >>> + mov #0x10, r5 >>> + cmp/ge r5, r4 ! is it a valid IRQ? >> >> Maybe I should've used cmp/hs... my 1st try at SH assembly! :-) Yeah, cmp/hs seems m ore correct as we don't subtract any more... > I can test your revised patch next week on my SH7785LCR. Please do, although testing on the AP-SH4A* bords would be a bit more interesting, as they actually use IRQ0 for the SMSC911x chip... Maybe you have SH7786 base board, by chance? > Thanks, > Adrian MBR, Sergey