From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0388BFCD0B8 for ; Wed, 18 Mar 2026 05:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Content-Transfer-Encoding:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/ToQygVD2aRar3azEF/af6SwRIo2nMLg5iMDRZE0YjA=; b=O71Mm1HymH7vijuJgw3AAj3qJb 6a5kpgLal4wvVJ4cI67Y7Z+wLpDfMJ7p+jjKDYImPfbjiVCIA290NEImxT7zu9I3tdh3fLLVVE1mQ YhEdJ3b+zGxlY8ynYfXI6RxRbfbQfply0hFuRFgDKX43TJXID78L5Rr2rJgqvFPiqBJM=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w2ju8-0001Ki-6F; Wed, 18 Mar 2026 05:57:16 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w2jtr-0001J0-RZ for linux-f2fs-devel@lists.sourceforge.net; Wed, 18 Mar 2026 05:57:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NxlKDox5d5JeTQv+nhgUzot1Q141Nw8WjddEhlt286M=; b=PNfc/NX4+0QcX7EkjBIF47aVvM 24jPJyo2UsYqHRcYivUpwfsLOwq7jJZsuuhBjzot1GHAXqA6FrvSaAaDkSU+Ftt1s+1DFNUqZo6JE 1OM8JctGouhsA8fq/rLi2XDmdij0DWgNZRkBhZyY8fye4NUFeAg1qqXaW2rFsi2dOwDQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NxlKDox5d5JeTQv+nhgUzot1Q141Nw8WjddEhlt286M=; b=C5NTxBcaidlg6VK96F7S8lukQ/ rxcSNTweLwPs+LXkSReGQgyK94nri1kwjbWOmx/xTjWw2lXvuEpX4Y6EScaPswmco/L9TQZBTgRyL 3cgIF3WK2dDq30dlzIa5vuEyqxp+8p7zIklI8aKRkBpwjpeaRiDXFeV7fLpWokVm5P0I=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w2jts-0001xu-2o for linux-f2fs-devel@lists.sourceforge.net; Wed, 18 Mar 2026 05:57:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 87C354331D; Wed, 18 Mar 2026 05:56:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEA32C19421; Wed, 18 Mar 2026 05:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773813409; bh=rfnoONL4n34OjU2sHTyixSXVbI/HvWxE4shOwhh1/U4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=hLA071ZclBL3RTTcwn/pOIftcsRdkRLlQ01MypwCaaWnEpWDP+9OHf7TWsWz6B1Og 4Y/JQTzVhxygAasPS/tdwraK/zCHgOpskGJFXTXjK1NkLKlxZR6TVub1ozlWOOx8PM WEoZuDlah4w0rAwhw0WrmVh9p9x5lnVq4epGNeb9MbXzGAacNv4uAArXBj94NLbts1 oDxhH+8Tr6CNiRipMdPAbsJ80G6IxavymzuiwD9JLKvY54pAeSUm7hQKO2a6R7TD66 E/ZGJTFadHf6/b8nfweWHTrwS44a5Xp+LlVv0kFM0cHS1t4VuLJV8ZrgYAHeIOaYNS utARMWH6rdxaw== Message-ID: Date: Wed, 18 Mar 2026 13:56:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Cen Zhang , jaegeuk@kernel.org References: <20260317114225.3017089-1-zzzccc427@gmail.com> Content-Language: en-US In-Reply-To: <20260317114225.3017089-1-zzzccc427@gmail.com> X-Headers-End: 1w2jts-0001xu-2o Subject: Re: [f2fs-dev] [PATCH] f2fs: add READ_ONCE() for i_blocks in f2fs_update_inode() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: gality369@gmail.com, zhenghaoran154@gmail.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, baijiaju1990@gmail.com, ziyuzhang201@gmail.com, r33s3n6@gmail.com, hanguidong02@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2026/3/17 19:42, Cen Zhang wrote: > f2fs_update_inode() reads inode->i_blocks without holding i_lock to > serialize it to the on-disk inode, while concurrent truncate or > allocation paths may modify i_blocks under i_lock. Since blkcnt_t is > u64, this risks torn reads on 32-bit architectures. > > Following the approach in ext4_inode_blocks_set(), add READ_ONCE() to prevent > potential compiler-induced tearing. > Need a Fixes line and Cc stable@kernel.org? Otherwise, it looks good to me. Thanks, > Signed-off-by: Cen Zhang > --- > fs/f2fs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 078874db918c..73b913dbe02a 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -694,7 +694,7 @@ void f2fs_update_inode(struct inode *inode, struct folio *node_folio) > ri->i_uid = cpu_to_le32(i_uid_read(inode)); > ri->i_gid = cpu_to_le32(i_gid_read(inode)); > ri->i_links = cpu_to_le32(inode->i_nlink); > - ri->i_blocks = cpu_to_le64(SECTOR_TO_BLOCK(inode->i_blocks) + 1); > + ri->i_blocks = cpu_to_le64(SECTOR_TO_BLOCK(READ_ONCE(inode->i_blocks)) + 1); > > if (!f2fs_is_atomic_file(inode) || > is_inode_flag_set(inode, FI_ATOMIC_COMMITTED)) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D60FE2A1CF for ; Wed, 18 Mar 2026 05:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773813409; cv=none; b=XCLS+8/sdnnN4HvAnt7j8Au+UvrW8kBmaHrtVmnDntpKpURptUWj9EbmCryFDDxmXlwz71WIM+AQgfOm3rWNuNFwV+Vw/kI4cmyIV+ongWP1W7VO/P4fd8rd4a57pfE4sA7pppq8ByiWqT6MsfRKcYkqonZifOfVDhctQaSDb3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773813409; c=relaxed/simple; bh=rfnoONL4n34OjU2sHTyixSXVbI/HvWxE4shOwhh1/U4=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=S843JMeKrZu7FuEPpMHZdI89YwKXuq7P7b0xEwF6IDsnDr/JHuwIUmHCqhWVwOS5g1uoOk4ft1gwFyj1z/9Oa34Z77oPbm90L+l3D2LsKPSF+XAqkWz9qqTof9j6S5p/Mtb97L225ZEgvue/iWPhZN8ciAcATda/+uOjytGFYd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hLA071Zc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hLA071Zc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEA32C19421; Wed, 18 Mar 2026 05:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773813409; bh=rfnoONL4n34OjU2sHTyixSXVbI/HvWxE4shOwhh1/U4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=hLA071ZclBL3RTTcwn/pOIftcsRdkRLlQ01MypwCaaWnEpWDP+9OHf7TWsWz6B1Og 4Y/JQTzVhxygAasPS/tdwraK/zCHgOpskGJFXTXjK1NkLKlxZR6TVub1ozlWOOx8PM WEoZuDlah4w0rAwhw0WrmVh9p9x5lnVq4epGNeb9MbXzGAacNv4uAArXBj94NLbts1 oDxhH+8Tr6CNiRipMdPAbsJ80G6IxavymzuiwD9JLKvY54pAeSUm7hQKO2a6R7TD66 E/ZGJTFadHf6/b8nfweWHTrwS44a5Xp+LlVv0kFM0cHS1t4VuLJV8ZrgYAHeIOaYNS utARMWH6rdxaw== Message-ID: Date: Wed, 18 Mar 2026 13:56:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, r33s3n6@gmail.com, gality369@gmail.com, zhenghaoran154@gmail.com, hanguidong02@gmail.com, ziyuzhang201@gmail.com Subject: Re: [PATCH] f2fs: add READ_ONCE() for i_blocks in f2fs_update_inode() To: Cen Zhang , jaegeuk@kernel.org References: <20260317114225.3017089-1-zzzccc427@gmail.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260317114225.3017089-1-zzzccc427@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/3/17 19:42, Cen Zhang wrote: > f2fs_update_inode() reads inode->i_blocks without holding i_lock to > serialize it to the on-disk inode, while concurrent truncate or > allocation paths may modify i_blocks under i_lock. Since blkcnt_t is > u64, this risks torn reads on 32-bit architectures. > > Following the approach in ext4_inode_blocks_set(), add READ_ONCE() to prevent > potential compiler-induced tearing. > Need a Fixes line and Cc stable@kernel.org? Otherwise, it looks good to me. Thanks, > Signed-off-by: Cen Zhang > --- > fs/f2fs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 078874db918c..73b913dbe02a 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -694,7 +694,7 @@ void f2fs_update_inode(struct inode *inode, struct folio *node_folio) > ri->i_uid = cpu_to_le32(i_uid_read(inode)); > ri->i_gid = cpu_to_le32(i_gid_read(inode)); > ri->i_links = cpu_to_le32(inode->i_nlink); > - ri->i_blocks = cpu_to_le64(SECTOR_TO_BLOCK(inode->i_blocks) + 1); > + ri->i_blocks = cpu_to_le64(SECTOR_TO_BLOCK(READ_ONCE(inode->i_blocks)) + 1); > > if (!f2fs_is_atomic_file(inode) || > is_inode_flag_set(inode, FI_ATOMIC_COMMITTED))