From: dean@sensoray.com
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] media: usb: s2255: add serial number V4L2_CID
Date: Thu, 14 Dec 2023 17:28:14 -0600 [thread overview]
Message-ID: <e4d2dda6f0ec4abfad064a994466843f@sensoray.com> (raw)
In-Reply-To: <917c4e00-28bd-416f-9be7-b87717b3cf2f@xs4all.nl>
On 2023-12-13 04:03, Hans Verkuil wrote:
> Hi Dean,
>
> A few more comments below.
>
...
> I never noticed this before, but there is a call to
> v4l2_ctrl_handler_setup() missing
> in this driver! That call ensures that s2255_s_ctrl() is called with
> the initial control
> values.
>
> It's probably something that should be added.
If this is added, it needs done very carefully. Adding it to probe will
100% break the firmware load. s2255_s_ctrl sends a USB command to the
board and the asynchronous firmware load shares the endpoint for
commands.
The initial brightness, contrast, hue, and saturation default values
match what the firmware sets when first loaded. It's redundant to set
them again immediately after the firmware load succeeds. I think at a
minimum this belongs in a separate patch.
Regards,
Dean
>
> Regards,
>
> Hans
next prev parent reply other threads:[~2023-12-14 23:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 22:38 [PATCH] media: usb: s2255: add serial number V4L2_CID Dean Anderson
2023-12-13 10:03 ` Hans Verkuil
2023-12-14 22:21 ` dean
2023-12-14 23:28 ` dean [this message]
2023-12-15 7:56 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4d2dda6f0ec4abfad064a994466843f@sensoray.com \
--to=dean@sensoray.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.