From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Martin KaFai Lau <martin.lau@linux.dev>
Cc: kuba@kernel.org, andrii@kernel.org, ast@kernel.org,
mykolal@fb.com, bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 1/2] bpf: add skcipher API support to TC/XDP programs
Date: Fri, 17 Nov 2023 09:10:59 -0500 [thread overview]
Message-ID: <e4d76f14-5045-4935-b699-e84beb645652@linux.dev> (raw)
In-Reply-To: <ZVblI/mbqFsdVI00@gondor.apana.org.au>
On 16/11/2023 19:59, Herbert Xu wrote:
> Vadim Fedorenko <vadfed@meta.com> wrote:
>> Add crypto API support to BPF to be able to decrypt or encrypt packets
>> in TC/XDP BPF programs. Only symmetric key ciphers are supported for
>> now. Special care should be taken for initialization part of crypto algo
>> because crypto_alloc_sync_skcipher() doesn't work with preemtion
>> disabled, it can be run only in sleepable BPF program. Also async crypto
>> is not supported because of the very same issue - TC/XDP BPF programs
>> are not sleepable.
>>
>> Signed-off-by: Vadim Fedorenko <vadfed@meta.com>
>
> Please use the newly introduced lskcipher interface instead of
> skcipher.
Oh, sounds like we do have proper API to work with buffers directly!
Thanks for pointing to it, I'll send v5 soon.
prev parent reply other threads:[~2023-11-17 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 20:34 [PATCH bpf-next v4 1/2] bpf: add skcipher API support to TC/XDP programs Vadim Fedorenko
2023-11-10 20:35 ` [PATCH bpf-next v4 2/2] selftests: bpf: crypto skcipher algo selftests Vadim Fedorenko
2023-11-17 3:59 ` [PATCH bpf-next v4 1/2] bpf: add skcipher API support to TC/XDP programs Herbert Xu
2023-11-17 14:10 ` Vadim Fedorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4d76f14-5045-4935-b699-e84beb645652@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.