From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com,
xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com,
consulting@bugseng.com,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>
Subject: Re: [XEN PATCH v2 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3
Date: Mon, 07 Aug 2023 18:43:25 +0200 [thread overview]
Message-ID: <e4eaad8dec9a289821d799b6eab8f29b@bugseng.com> (raw)
In-Reply-To: <17069ab9-03ff-9f7b-6480-d50e1349e16a@suse.com>
On 07/08/2023 14:48, Jan Beulich wrote:
> On 04.08.2023 22:45, Stefano Stabellini wrote:
>> On Fri, 4 Aug 2023, Nicola Vetrini wrote:
>>> Rename variables to avoid shadowing and thus address
>>> MISRA C:2012 Rule 5.3:
>>> "An identifier declared in an inner scope shall not hide an
>>> identifier declared in an outer scope".
>>>
>>> The shadowing happens between the struct declaration 'mtrr_state' in
>>> 'xen/arch/x86/include/asm/mtrr.h' and local variable names.
>
> Let's try to be precise: The issue isn't with the struct declaration,
> but with the declaration of the global variable of that name a few
> lines later. Afaict - please clarify.
Yes, my wording is wrong.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
next prev parent reply other threads:[~2023-08-07 16:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 8:03 [XEN PATCH v2 0/4] x86: address some violations of MISRA C:2012 Rule 5.3 Nicola Vetrini
2023-08-04 8:03 ` [XEN PATCH v2 1/4] x86/mce: address " Nicola Vetrini
2023-08-04 20:43 ` Stefano Stabellini
2023-08-07 12:44 ` Jan Beulich
2023-08-04 8:03 ` [XEN PATCH v2 2/4] x86/mtrr: " Nicola Vetrini
2023-08-04 20:45 ` Stefano Stabellini
2023-08-07 12:48 ` Jan Beulich
2023-08-07 16:43 ` Nicola Vetrini [this message]
2023-08-04 8:03 ` [XEN PATCH v2 3/4] x86/irq: rename variable to " Nicola Vetrini
2023-08-04 20:47 ` Stefano Stabellini
2023-08-07 7:18 ` Nicola Vetrini
2023-08-07 12:55 ` Jan Beulich
2023-08-04 8:03 ` [XEN PATCH v2 4/4] x86/setup: " Nicola Vetrini
2023-08-04 20:48 ` Stefano Stabellini
2023-08-07 13:05 ` Jan Beulich
2023-08-07 13:18 ` Nicola Vetrini
2023-08-07 13:42 ` Jan Beulich
2023-08-07 14:10 ` Nicola Vetrini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4eaad8dec9a289821d799b6eab8f29b@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=andrew.cooper3@citrix.com \
--cc=ayan.kumar.halder@amd.com \
--cc=consulting@bugseng.com \
--cc=jbeulich@suse.com \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.