All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [RFC] send-pack: allow skipping delta when sending pack
Date: Sun, 21 May 2006 11:24:42 +0200	[thread overview]
Message-ID: <e4pbk3$6au$1@sea.gmane.org> (raw)
In-Reply-To: 20060521084403.GB12825@coredump.intra.peff.net

Jeff King wrote:

> On Sun, May 21, 2006 at 10:24:37AM +0200, Jakub Narebski wrote:
> 
>> Hmmm... isn't the patch slightly against git coding style?
> 
> Oops, yes (though the point is moot since the patch is conceptually
> wrong). Is there a git coding style document somewhere?

Not that I know of. It's better to follow the coding style used
in the rest of files.

Besides, differentiating between

   if (condition)

and

   function(argument);

makes IMVHO sense.

-- 
Jakub Narebski
Warsaw, Poland

  parent reply	other threads:[~2006-05-21  9:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-21  5:48 [RFC] send-pack: allow skipping delta when sending pack Jeff King
2006-05-21  6:17 ` Junio C Hamano
2006-05-21  8:14   ` Jeff King
2006-05-21  8:24     ` Jakub Narebski
2006-05-21  8:44       ` Jeff King
2006-05-21  9:14         ` Junio C Hamano
2006-05-21  9:24         ` Jakub Narebski [this message]
2006-05-21  8:31     ` Junio C Hamano
2006-05-21  8:43       ` Jeff King
2006-05-21  9:40         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='e4pbk3$6au$1@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.