From: Chuck Lever <cel@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: kdevops@lists.linux.dev, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [RFC PATCH 1/5] guestfs: Replace scripts/destroy_guestfs.sh with an Ansible playbook
Date: Thu, 22 May 2025 13:03:40 -0400 [thread overview]
Message-ID: <e510d8a1-1069-4e43-8d2f-3fa53c658c5e@kernel.org> (raw)
In-Reply-To: <aC9YlSVD8HqeGWxr@bombadil.infradead.org>
On 5/22/25 1:02 PM, Luis Chamberlain wrote:
> On Thu, May 22, 2025 at 09:31:33AM -0400, cel@kernel.org wrote:
>> From: Chuck Lever <chuck.lever@oracle.com>
>>
>> Start to make use of the Ansible libvirt module to handle libvirt
>> guest configuration, and replace the open-coded loop over the
>> content of guestfs/kdevops_nodes.yml.
>>
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> +- name: Remove per-node configuration files
>> + ansible.builtin.file:
>> + path: "{{ item }}"
>> + state: absent
>> + loop:
>> + - "{{ guestfs_path }}/{{ inventory_hostname }}"
>> + - "{{ kdevops_storage_pool_path }}/guestfs/{{ inventory_hostname }}"
>
> Does this remove a directory? If so then:
>
> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
>
> Luis
I think it does remove directories: guestfs/ is empty after these
steps complete.
--
Chuck Lever
next prev parent reply other threads:[~2025-05-22 17:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 13:31 [RFC PATCH 0/5] Convert bringup_guestfs to a single Ansible role cel
2025-05-22 13:31 ` [RFC PATCH 1/5] guestfs: Replace scripts/destroy_guestfs.sh with an Ansible playbook cel
2025-05-22 17:02 ` Luis Chamberlain
2025-05-22 17:03 ` Chuck Lever [this message]
2025-05-22 13:31 ` [RFC PATCH 2/5] Move the guestfs install-deps to the guestfs playbook cel
2025-05-22 17:07 ` Luis Chamberlain
2025-05-22 17:13 ` Chuck Lever
2025-05-22 17:16 ` Luis Chamberlain
2025-05-22 13:31 ` [RFC PATCH 3/5] guestfs: Move console-related steps to guestfs role cel
2025-05-22 17:09 ` Luis Chamberlain
2025-05-22 17:11 ` Chuck Lever
2025-05-22 17:15 ` Luis Chamberlain
2025-05-22 13:31 ` [RFC PATCH 4/5] guestfs: Move check-config, network, and storage-pool tags cel
2025-05-22 13:31 ` [RFC PATCH 5/5] guestfs: Convert part of scripts/bringup_guestfs.sh to Ansible cel
2025-05-22 17:14 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e510d8a1-1069-4e43-8d2f-3fa53c658c5e@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.