From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from m42-4.mailgun.net ([69.72.42.4]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZw7z-0003RS-2Q for ath10k@lists.infradead.org; Tue, 03 Nov 2020 13:13:37 +0000 MIME-Version: 1.0 Date: Tue, 03 Nov 2020 10:34:47 +0800 From: Carl Huang Subject: Re: [RFC 1/2] nl80211: add common API to configure SAR power limitations. In-Reply-To: <20201031024631.1528113-1-kuabhs@chromium.org> References: <20201030205639.1452712-1-kuabhs@chromium.org> <20201031024631.1528113-1-kuabhs@chromium.org> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Abhishek Kumar Cc: johannes@sipsolutions.net, briannorris@chromium.org, linux-wireless@vger.kernel.org, dianders@chromium.org, ath10k@lists.infradead.org T24gMjAyMC0xMC0zMSAxMDo0NiwgQWJoaXNoZWsgS3VtYXIgd3JvdGU6Cj4gRnJvbToga3VhYmhz QGNocm9taXVtLm9yZwo+IAo+IFRoZXJlIGFyZSBmZXcgbW9yZSBhZGRpdGlvbmFsIGNvbW1lbnRz IGhlcmUuCj4+ICsgKiBATkw4MDIxMV9DTURfU0VUX1NBUl9TUEVDUzogU0FSIHBvd2VyIGxpbWl0 YXRpb24gY29uZmlndXJhdGlvbiBpcwo+PiArICogwqAgwqAgcGFzc2VkIHVzaW5nICVOTDgwMjEx X0FUVFJfU0FSX1NQRUMuCj4+ICsgKgo+IAo+IFRoaXMgY29tbWFuZCByZXF1aXJlcyBOTDgwMjEx X0FUVFJfSUZJTkRFWCwgcHJvYmFibHkgc2hvdWxkIGJlIGJldHRlciAKPiB0byBhZGQKPiB0aGlz IGluIHRoZSBjb21tZW50ID8KPiAKUGVyIEpvaGFubmVzJ3MgY29tbWVudHMsIHRoaXMgZXhwbGlj aXQgaW5kZXggaXMgbm90IHJlcXVpcmVkLiBBcmUgeW91IApmaW5lCndpdGggaXQ/CgpJbnN0ZWFk LCB1c2VyLXNwYWNlIGFwcGxpY2F0aW9uIHJlY29yZHMgdGhlIGFycmF5IGluZGV4IHdoZW4gcXVl cnlpbmcgCnRoZSBTQVIKY2FwYWJpbGl0eS4gV2hlbiBzZXQsIHRoZSBuZXN0ZWQgYXJyYXkgaW5k ZXggd2lsbCBiZSB1c2VkIHRvIHNldCB0aGUgCnBvd2VyLgpUaGlzIHJlcXVpcmVzIHVzZXItc3Bh Y2UgaGFzIGEgc3RyaWN0IG1hcHBpbmcgb2YgaW5kZXguIGFuZCAKTkw4MDIxMV9BVFRSX0lGSU5E RVgKaXMgdG8gYmUgcmVtb3ZlZC4KCgo+PiArc3RhdGljIGludAo+PiArbmw4MDIxMV9wdXRfc2Fy X3NwZWNzKHN0cnVjdCBjZmc4MDIxMV9yZWdpc3RlcmVkX2RldmljZSAqcmRldiwKPj4gKyDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBzdHJ1Y3Qgc2tfYnVmZiAqbXNnKQo+PiArewo+PiAr IMKgIMKgIMKgIHN0cnVjdCBubGF0dHIgKnNhcl9jYXBhLCAqc3BlY3MsICpzdWJfZnJlcV9yYW5n ZTsKPj4gKyDCoCDCoCDCoCB1OCDCoG51bV9mcmVxX3JhbmdlczsKPj4gKyDCoCDCoCDCoCBpbnQg aTsKPj4gKwo+PiArIMKgIMKgIMKgIGlmICghcmRldi0+d2lwaHkuc2FyX2NhcGEpCj4+ICsgwqAg wqAgwqAgwqAgwqAgwqAgwqAgcmV0dXJuIDA7Cj4+ICsKPj4gKyDCoCDCoCDCoCBudW1fZnJlcV9y YW5nZXMgPSByZGV2LT53aXBoeS5zYXJfY2FwYS0+bnVtX2ZyZXFfcmFuZ2VzOwo+PiArCj4+ICsg wqAgwqAgwqAgc2FyX2NhcGEgPSBubGFfbmVzdF9zdGFydChtc2csIE5MODAyMTFfQVRUUl9TQVJf U1BFQyk7Cj4+ICsgwqAgwqAgwqAgaWYgKCFzYXJfY2FwYSkKPj4gKyDCoCDCoCDCoCDCoCDCoCDC oCDCoCByZXR1cm4gLUVOT1NQQzsKPiAKPiBJIHNlZSBzb21lIHBsYWNlcyBubGFfbmVzdF9zdGFy dF9ub2ZsYWcgYmVpbmcgdXNlZCBhbmQgaGVyZSAKPiBubGFfbmVzdF9zdGFydC4KPiBXaGF0cyB0 aGUgc3BlY2lmaWMgcmVhc29uIHRvIGRvIHRoYXQgPyBJbiB0aGUgbmV3ZXIgS2VybmVsIHZlcnNp b25zLCBJIAo+IGJlbGlldmUKPiBubGFfbmVzdF9zdGFydCBpcyBwcmVmZXJyZWQuCj4gClRoaXMg d2lsbCBiZSBhZGRyZXNzZWQgaW4gbmV4dCB2ZXJzaW9uLgoKPj4gKyDCoCDCoCDCoCDCoCDCoCDC oCDCoCBwb3dlciA9IAo+PiBubGFfZ2V0X3U4KHNwZWNbTkw4MDIxMV9TQVJfQVRUUl9TUEVDU19Q T1dFUl0pOwo+PiArIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHNhcl9zcGVjLT5zdWJfc3BlY3Nbc3Bl Y3NdLnBvd2VyID0gcG93ZXI7Cj4+ICsKPj4gKyDCoCDCoCDCoCDCoCDCoCDCoCDCoCAvKiBpZiBO TDgwMjExX1NBUl9BVFRSX1NQRUNTX0ZSRVFfUkFOR0VfSU5ERVggaXNuJ3QgCj4+IHByZXNlbnQs Cj4+ICsgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAqIHRoZW4gdGhlIHBvd2VyIGFwcGxpZXMgdG8g YWxsIGJhbmRzLiBCdXQgaXQncyBvbmx5IAo+PiB2YWxpZAo+PiArIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgKiBmb3IgdGhlIGZpcnN0IGVudHJ5Lgo+PiArIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg Ki8KPj4gKyDCoCDCoCDCoCDCoCDCoCDCoCDCoCBpZiAoIXNwZWNbTkw4MDIxMV9TQVJfQVRUUl9T UEVDU19GUkVRX1JBTkdFX0lOREVYXSkgewo+PiArIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIGlmIChzcGVjcykgewo+PiArIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIGVyciA9IC1FSU5WQUw7Cj4+ICsgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgZ290byBlcnJvcjsKPj4gKyDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCB9IGVsc2Ugewo+PiArIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIAo+PiBzYXJfc3BlYy0+c3ViX3NwZWNzW3NwZWNzXS5mcmVxX3Jhbmdl X2luZGV4ID0KPj4gKyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCBOTDgwMjExX1NBUl9BTExfRlJFUV9STkFHRVM7Cj4+ICsgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgc3BlY3MrKzsKPj4gKyDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBicmVhazsKPj4gKyDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCB9Cj4+ICsgwqAgwqAgwqAgwqAgwqAgwqAgwqAgfQo+ IAo+IEhlcmUgSSBzZWUgeW91IGFyZSBhc3NpZ25pbmcgc2FtZSBwb3dlciB0byBhbGwgZnJlcSBi YW5kIGlmIGZvciB0aGUgCj4gZmlyc3QgYmFuZAo+IHRoZSBmcmVxIGluZGV4IGlzIG5vdCBwcm92 aWRlZC4gSXMgdGhlcmUgYW55IHNwZWNpZmljIHJlYXNvbiB0byBvbmx5Cj4gY2hlY2sgdGhlIGZp cnN0Cj4gaGVyZSA/IFByb2JhYmx5IHRoaXMgbG9naWMgc2hvdWxkIG1vdmUgaW50byBzcGVjaWZp YyBkcml2ZXJzLiBUaG91Z2h0cyAKPiA/Cj4gClRoaXMgbG9naWMgd2lsbCBiZSByZW1vdmVkIHBl ciBKb2hhbm5lcydzIGNvbW1lbnRzLgoKUGxlYXNlIHJlYWQgIEpvaGFubmVzJ3MgY29tbWVudHMu IElmIHlvdSBhZ3JlZSB3aXRoIGhpbSBhbmQgaGFzIG5vIG90aGVyIAphZHZpY2VzLAp0aGVuIEkg d2lsbCBwb3N0IHRoZSBzZWNvbmQgdmVyc2lvbiBvZiBpdC4KCgo+IC1BYmhpc2hlawo+IAo+IAo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gYXRoMTBr IG1haWxpbmcgbGlzdAo+IGF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBr QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D94C2D0A3 for ; Tue, 3 Nov 2020 13:13:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3677322243 for ; Tue, 3 Nov 2020 13:13:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="uPYKnWTF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729037AbgKCNNa (ORCPT ); Tue, 3 Nov 2020 08:13:30 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:16113 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728721AbgKCNN3 (ORCPT ); Tue, 3 Nov 2020 08:13:29 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604409209; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=kJE3Itmf+jWbO4yB/RJMz173+NAW4O8iB9/q9jXy720=; b=uPYKnWTFhlzv12JJQnN1gh/RrULPRGAfxB4hKhcEzTN+NDETWoqASrT/Cx+40r83KHtU2ocw DlwuORKg2Uiv9UGNCvTbvt6X6bWtyoEgztFbi7mjuDBsDfbntk7P+HHFrnIfe9+/LPtOWHsY LtPNZ9qI2ckzC4Km7T8fHKeixTg= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5fa15770d608b771031723ba (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 03 Nov 2020 13:13:20 GMT Sender: cjhuang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BA179C43395; Tue, 3 Nov 2020 02:34:48 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cjhuang) by smtp.codeaurora.org (Postfix) with ESMTPSA id D4D49C43382; Tue, 3 Nov 2020 02:34:47 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 03 Nov 2020 10:34:47 +0800 From: Carl Huang To: Abhishek Kumar Cc: briannorris@chromium.org, linux-wireless@vger.kernel.org, dianders@chromium.org, ath10k@lists.infradead.org, johannes@sipsolutions.net Subject: Re: [RFC 1/2] nl80211: add common API to configure SAR power limitations. In-Reply-To: <20201031024631.1528113-1-kuabhs@chromium.org> References: <20201030205639.1452712-1-kuabhs@chromium.org> <20201031024631.1528113-1-kuabhs@chromium.org> Message-ID: X-Sender: cjhuang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-10-31 10:46, Abhishek Kumar wrote: > From: kuabhs@chromium.org > > There are few more additional comments here. >> + * @NL80211_CMD_SET_SAR_SPECS: SAR power limitation configuration is >> + *     passed using %NL80211_ATTR_SAR_SPEC. >> + * > > This command requires NL80211_ATTR_IFINDEX, probably should be better > to add > this in the comment ? > Per Johannes's comments, this explicit index is not required. Are you fine with it? Instead, user-space application records the array index when querying the SAR capability. When set, the nested array index will be used to set the power. This requires user-space has a strict mapping of index. and NL80211_ATTR_IFINDEX is to be removed. >> +static int >> +nl80211_put_sar_specs(struct cfg80211_registered_device *rdev, >> +                     struct sk_buff *msg) >> +{ >> +       struct nlattr *sar_capa, *specs, *sub_freq_range; >> +       u8  num_freq_ranges; >> +       int i; >> + >> +       if (!rdev->wiphy.sar_capa) >> +               return 0; >> + >> +       num_freq_ranges = rdev->wiphy.sar_capa->num_freq_ranges; >> + >> +       sar_capa = nla_nest_start(msg, NL80211_ATTR_SAR_SPEC); >> +       if (!sar_capa) >> +               return -ENOSPC; > > I see some places nla_nest_start_noflag being used and here > nla_nest_start. > Whats the specific reason to do that ? In the newer Kernel versions, I > believe > nla_nest_start is preferred. > This will be addressed in next version. >> +               power = >> nla_get_u8(spec[NL80211_SAR_ATTR_SPECS_POWER]); >> +               sar_spec->sub_specs[specs].power = power; >> + >> +               /* if NL80211_SAR_ATTR_SPECS_FREQ_RANGE_INDEX isn't >> present, >> +                * then the power applies to all bands. But it's only >> valid >> +                * for the first entry. >> +                */ >> +               if (!spec[NL80211_SAR_ATTR_SPECS_FREQ_RANGE_INDEX]) { >> +                       if (specs) { >> +                               err = -EINVAL; >> +                               goto error; >> +                       } else { >> +                               >> sar_spec->sub_specs[specs].freq_range_index = >> +                                       NL80211_SAR_ALL_FREQ_RNAGES; >> +                               specs++; >> +                               break; >> +                       } >> +               } > > Here I see you are assigning same power to all freq band if for the > first band > the freq index is not provided. Is there any specific reason to only > check the first > here ? Probably this logic should move into specific drivers. Thoughts > ? > This logic will be removed per Johannes's comments. Please read Johannes's comments. If you agree with him and has no other advices, then I will post the second version of it. > -Abhishek > > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k