From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23E0FC197A0 for ; Thu, 16 Nov 2023 10:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p1qu9dHoAwO4zOawhF7BgDgXtRDuv2U+zhRRTVxfFqY=; b=k/Y/jvqPI7wld5 hCWIPRetb+a0ZrFNdktrTqQMgjae1GZLg1rvj+FgS14jvXWvx6+kCOTt3D1UkLyK5cPsUWDJ+qRGM IOlYjE9TEm0r5XKBJ1Duyn/2Ty5OeQEmdEVQd+ZFXwZYbUV2g9O/R18a/XpAkFThCxiD0DVpo41UG 9lEpa6ECgOAkjGzPBddCEQ7GMp/5wiZKy4mcwaCugObidH3Kt87iepN/aCJaRfmXMB0twqdeekCgQ lBZAEuN9zgzlGNTfHG6w9EIUoeVC/DlhV+u7OQq48a9N8Q0IUWAOdS6cxuVqPskINCM87HC4gazEk O5UCMyQufxuBaXwfHNzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3ZaE-0034sI-0X; Thu, 16 Nov 2023 10:26:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3Za9-0034qP-2W for linux-arm-kernel@lists.infradead.org; Thu, 16 Nov 2023 10:26:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6E571595; Thu, 16 Nov 2023 02:27:28 -0800 (PST) Received: from [10.1.35.163] (XHFQ2J9959.cambridge.arm.com [10.1.35.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F0F43F6C4; Thu, 16 Nov 2023 02:26:39 -0800 (PST) Message-ID: Date: Thu, 16 Nov 2023 10:26:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/14] mm: Batch-copy PTE ranges during fork() Content-Language: en-GB To: David Hildenbrand , Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Anshuman Khandual , Matthew Wilcox , Yu Zhao , Mark Rutland , Kefeng Wang , John Hubbard , Zi Yan Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20231115163018.1303287-1-ryan.roberts@arm.com> <20231115163018.1303287-2-ryan.roberts@arm.com> <271f1e98-6217-4b40-bae0-0ac9fe5851cb@redhat.com> From: Ryan Roberts In-Reply-To: <271f1e98-6217-4b40-bae0-0ac9fe5851cb@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231116_022645_917516_3A224990 X-CRM114-Status: GOOD ( 39.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTYvMTEvMjAyMyAxMDowMywgRGF2aWQgSGlsZGVuYnJhbmQgd3JvdGU6Cj4gT24gMTUuMTEu MjMgMTc6MzAsIFJ5YW4gUm9iZXJ0cyB3cm90ZToKPj4gQ29udmVydCBjb3B5X3B0ZV9yYW5nZSgp IHRvIGNvcHkgYSBzZXQgb2YgcHRlcyBpbiBhIGJhdGNoLiBBIGdpdmVuIGJhdGNoCj4+IG1hcHMg YSBwaHlzaWNhbGx5IGNvbnRpZ3VvdXMgYmxvY2sgb2YgbWVtb3J5LCBhbGwgYmVsb25naW5nIHRv IHRoZSBzYW1lCj4+IGZvbGlvLCB3aXRoIHRoZSBzYW1lIHBlcm1pc3Npb25zLCBhbmQgZm9yIHNo YXJlZCBtYXBwaW5ncywgdGhlIHNhbWUKPj4gZGlydHkgc3RhdGUuIFRoaXMgd2lsbCBsaWtlbHkg aW1wcm92ZSBwZXJmb3JtYW5jZSBieSBhIHRpbnkgYW1vdW50IGR1ZQo+PiB0byBiYXRjaGluZyB0 aGUgZm9saW8gcmVmZXJlbmNlIGNvdW50IG1hbmFnZW1lbnQgYW5kIGNhbGxpbmcgc2V0X3B0ZXMo KQo+PiByYXRoZXIgdGhhbiBtYWtpbmcgaW5kaXZpZHVhbCBjYWxscyB0byBzZXRfcHRlX2F0KCku Cj4+Cj4+IEhvd2V2ZXIsIHRoZSBwcmltYXJ5IG1vdGl2YXRpb24gZm9yIHRoaXMgY2hhbmdlIGlz IHRvIHJlZHVjZSB0aGUgbnVtYmVyCj4+IG9mIHRsYiBtYWludGVuYW5jZSBvcGVyYXRpb25zIHRo YXQgdGhlIGFybTY0IGJhY2tlbmQgaGFzIHRvIHBlcmZvcm0KPj4gZHVyaW5nIGZvcmssIGFzIGl0 IGlzIGFib3V0IHRvIGFkZCB0cmFuc3BhcmVudCBzdXBwb3J0IGZvciB0aGUKPj4gImNvbnRpZ3Vv dXMgYml0IiBpbiBpdHMgcHRlcy4gQnkgd3JpdGUtcHJvdGVjdGluZyB0aGUgcGFyZW50IHVzaW5n IHRoZQo+PiBuZXcgcHRlcF9zZXRfd3Jwcm90ZWN0cygpIChub3RlIHRoZSAncycgYXQgdGhlIGVu ZCkgZnVuY3Rpb24sIHRoZQo+PiBiYWNrZW5kIGNhbiBhdm9pZCBoYXZpbmcgdG8gdW5mb2xkIGNv bnRpZyByYW5nZXMgb2YgUFRFcywgd2hpY2ggaXMKPj4gZXhwZW5zaXZlLCB3aGVuIGFsbCBwdGVz IGluIHRoZSByYW5nZSBhcmUgYmVpbmcgd3JpdGUtcHJvdGVjdGVkLgo+PiBTaW1pbGFybHksIGJ5 IHVzaW5nIHNldF9wdGVzKCkgcmF0aGVyIHRoYW4gc2V0X3B0ZV9hdCgpIHRvIHNldCB1cCBwdGVz Cj4+IGluIHRoZSBjaGlsZCwgdGhlIGJhY2tlbmQgZG9lcyBub3QgbmVlZCB0byBmb2xkIGEgY29u dGlndW91cyByYW5nZSBvbmNlCj4+IHRoZXkgYXJlIGFsbCBwb3B1bGF0ZWQgLSB0aGV5IGNhbiBi ZSBpbml0aWFsbHkgcG9wdWxhdGVkIGFzIGEgY29udGlndW91cwo+PiByYW5nZSBpbiB0aGUgZmly c3QgcGxhY2UuCj4+Cj4+IFRoaXMgY2hhbmdlIGFkZHJlc3NlcyB0aGUgY29yZS1tbSByZWZhY3Rv cmluZyBvbmx5LCBhbmQgaW50cm9kdWNlcwo+PiBwdGVwX3NldF93cnByb3RlY3RzKCkgd2l0aCBh IGRlZmF1bHQgaW1wbGVtZW50YXRpb24gdGhhdCBjYWxscwo+PiBwdGVwX3NldF93cnByb3RlY3Qo KSBmb3IgZWFjaCBwdGUgaW4gdGhlIHJhbmdlLiBBIHNlcGFyYXRlIGNoYW5nZSB3aWxsCj4+IGlt cGxlbWVudCBwdGVwX3NldF93cnByb3RlY3RzKCkgaW4gdGhlIGFybTY0IGJhY2tlbmQgdG8gcmVh bGl6ZSB0aGUKPj4gcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQgYXMgcGFydCBvZiB0aGUgd29yayB0 byBlbmFibGUgY29udHB0ZSBtYXBwaW5ncy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogUnlhbiBSb2Jl cnRzIDxyeWFuLnJvYmVydHNAYXJtLmNvbT4KPj4gLS0tCj4+IMKgIGluY2x1ZGUvbGludXgvcGd0 YWJsZS5oIHzCoCAxMyArKysKPj4gwqAgbW0vbWVtb3J5LmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgfCAxNzUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLQo+PiDCoCAy IGZpbGVzIGNoYW5nZWQsIDE1MCBpbnNlcnRpb25zKCspLCAzOCBkZWxldGlvbnMoLSkKPj4KPj4g ZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvcGd0YWJsZS5oIGIvaW5jbHVkZS9saW51eC9wZ3Rh YmxlLmgKPj4gaW5kZXggYWY3NjM5YzNiMGEzLi4xYzUwZjhhMGZkZGUgMTAwNjQ0Cj4+IC0tLSBh L2luY2x1ZGUvbGludXgvcGd0YWJsZS5oCj4+ICsrKyBiL2luY2x1ZGUvbGludXgvcGd0YWJsZS5o Cj4+IEBAIC02MjIsNiArNjIyLDE5IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBwdGVwX3NldF93cnBy b3RlY3Qoc3RydWN0IG1tX3N0cnVjdAo+PiAqbW0sIHVuc2lnbmVkIGxvbmcgYWRkcmVzCj4+IMKg IH0KPj4gwqAgI2VuZGlmCj4+IMKgICsjaWZuZGVmIHB0ZXBfc2V0X3dycHJvdGVjdHMKPj4gK3N0 cnVjdCBtbV9zdHJ1Y3Q7Cj4+ICtzdGF0aWMgaW5saW5lIHZvaWQgcHRlcF9zZXRfd3Jwcm90ZWN0 cyhzdHJ1Y3QgbW1fc3RydWN0ICptbSwKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCB1bnNpZ25lZCBsb25nIGFkZHJlc3MsIHB0ZV90ICpwdGVwLAo+PiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBucikKPj4gK3sKPj4gK8KgwqDCoCB1bnNpZ25l ZCBpbnQgaTsKPj4gKwo+PiArwqDCoMKgIGZvciAoaSA9IDA7IGkgPCBucjsgaSsrLCBhZGRyZXNz ICs9IFBBR0VfU0laRSwgcHRlcCsrKQo+PiArwqDCoMKgwqDCoMKgwqAgcHRlcF9zZXRfd3Jwcm90 ZWN0KG1tLCBhZGRyZXNzLCBwdGVwKTsKPj4gK30KPj4gKyNlbmRpZgo+PiArCj4+IMKgIC8qCj4+ IMKgwqAgKiBPbiBzb21lIGFyY2hpdGVjdHVyZXMgaGFyZHdhcmUgZG9lcyBub3Qgc2V0IHBhZ2Ug YWNjZXNzIGJpdCB3aGVuIGFjY2Vzc2luZwo+PiDCoMKgICogbWVtb3J5IHBhZ2UsIGl0IGlzIHJl c3BvbnNpYmlsaXR5IG9mIHNvZnR3YXJlIHNldHRpbmcgdGhpcyBiaXQuIEl0IGJyaW5ncwo+PiBk aWZmIC0tZ2l0IGEvbW0vbWVtb3J5LmMgYi9tbS9tZW1vcnkuYwo+PiBpbmRleCAxZjE4ZWQ0YTU0 OTcuLmI3YzgyMjg4ODNjZiAxMDA2NDQKPj4gLS0tIGEvbW0vbWVtb3J5LmMKPj4gKysrIGIvbW0v bWVtb3J5LmMKPj4gQEAgLTkyMSw0NiArOTIxLDEyOSBAQCBjb3B5X3ByZXNlbnRfcGFnZShzdHJ1 Y3Qgdm1fYXJlYV9zdHJ1Y3QgKmRzdF92bWEsCj4+IHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqc3Jj X3ZtYQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgLyogVWZmZC13cCBuZWVkcyB0byBiZSBkZWxpdmVy ZWQgdG8gZGVzdCBwdGUgYXMgd2VsbCAqLwo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgcHRlID0gcHRl X21rdWZmZF93cChwdGUpOwo+PiDCoMKgwqDCoMKgIHNldF9wdGVfYXQoZHN0X3ZtYS0+dm1fbW0s IGFkZHIsIGRzdF9wdGUsIHB0ZSk7Cj4+IC3CoMKgwqAgcmV0dXJuIDA7Cj4+ICvCoMKgwqAgcmV0 dXJuIDE7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyBpbmxpbmUgdW5zaWduZWQgbG9uZyBwYWdlX2Nv bnRfbWFwcGVkX3ZhZGRyKHN0cnVjdCBwYWdlICpwYWdlLAo+PiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHN0cnVjdCBwYWdlICphbmNob3IsIHVuc2lnbmVkIGxvbmcgYW5jaG9yX3Zh ZGRyKQo+PiArewo+PiArwqDCoMKgIHVuc2lnbmVkIGxvbmcgb2Zmc2V0Owo+PiArwqDCoMKgIHVu c2lnbmVkIGxvbmcgdmFkZHI7Cj4+ICsKPj4gK8KgwqDCoCBvZmZzZXQgPSAocGFnZV90b19wZm4o cGFnZSkgLSBwYWdlX3RvX3BmbihhbmNob3IpKSA8PCBQQUdFX1NISUZUOwo+PiArwqDCoMKgIHZh ZGRyID0gYW5jaG9yX3ZhZGRyICsgb2Zmc2V0Owo+PiArCj4+ICvCoMKgwqAgaWYgKGFuY2hvciA+ IHBhZ2UpIHsKPj4gK8KgwqDCoMKgwqDCoMKgIGlmICh2YWRkciA+IGFuY2hvcl92YWRkcikKPj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7Cj4+ICvCoMKgwqAgfSBlbHNlIHsKPj4g K8KgwqDCoMKgwqDCoMKgIGlmICh2YWRkciA8IGFuY2hvcl92YWRkcikKPj4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqAgcmV0dXJuIFVMT05HX01BWDsKPj4gK8KgwqDCoCB9Cj4+ICsKPj4gK8KgwqDC oCByZXR1cm4gdmFkZHI7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyBpbnQgZm9saW9fbnJfcGFnZXNf Y29udF9tYXBwZWQoc3RydWN0IGZvbGlvICpmb2xpbywKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcGFnZSAqcGFnZSwgcHRlX3QgKnB0ZSwKPj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25n IGFkZHIsIHVuc2lnbmVkIGxvbmcgZW5kLAo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHB0ZV90IHB0ZW50LCBib29sICphbnlfZGlydHkpCj4+ICt7Cj4+ICvC oMKgwqAgaW50IGZsb29wczsKPj4gK8KgwqDCoCBpbnQgaTsKPj4gK8KgwqDCoCB1bnNpZ25lZCBs b25nIHBmbjsKPj4gK8KgwqDCoCBwZ3Byb3RfdCBwcm90Owo+PiArwqDCoMKgIHN0cnVjdCBwYWdl ICpmb2xpb19lbmQ7Cj4+ICsKPj4gK8KgwqDCoCBpZiAoIWZvbGlvX3Rlc3RfbGFyZ2UoZm9saW8p KQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDE7Cj4+ICsKPj4gK8KgwqDCoCBmb2xpb19lbmQg PSAmZm9saW8tPnBhZ2UgKyBmb2xpb19ucl9wYWdlcyhmb2xpbyk7Cj4+ICvCoMKgwqAgZW5kID0g bWluKHBhZ2VfY29udF9tYXBwZWRfdmFkZHIoZm9saW9fZW5kLCBwYWdlLCBhZGRyKSwgZW5kKTsK Pj4gK8KgwqDCoCBmbG9vcHMgPSAoZW5kIC0gYWRkcikgPj4gUEFHRV9TSElGVDsKPj4gK8KgwqDC oCBwZm4gPSBwYWdlX3RvX3BmbihwYWdlKTsKPj4gK8KgwqDCoCBwcm90ID0gcHRlX3BncHJvdChw dGVfbWtvbGQocHRlX21rY2xlYW4ocHRlbnQpKSk7Cj4+ICsKPj4gK8KgwqDCoCAqYW55X2RpcnR5 ID0gcHRlX2RpcnR5KHB0ZW50KTsKPj4gKwo+PiArwqDCoMKgIHBmbisrOwo+PiArwqDCoMKgIHB0 ZSsrOwo+PiArCj4+ICvCoMKgwqAgZm9yIChpID0gMTsgaSA8IGZsb29wczsgaSsrKSB7Cj4+ICvC oMKgwqDCoMKgwqDCoCBwdGVudCA9IHB0ZXBfZ2V0KHB0ZSk7Cj4+ICvCoMKgwqDCoMKgwqDCoCBw dGVudCA9IHB0ZV9ta29sZChwdGVfbWtjbGVhbihwdGVudCkpOwo+PiArCj4+ICvCoMKgwqDCoMKg wqDCoCBpZiAoIXB0ZV9wcmVzZW50KHB0ZW50KSB8fCBwdGVfcGZuKHB0ZW50KSAhPSBwZm4gfHwK Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGdwcm90X3ZhbChwdGVfcGdwcm90KHB0ZW50KSkg IT0gcGdwcm90X3ZhbChwcm90KSkKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYnJlYWs7Cj4+ ICsKPj4gK8KgwqDCoMKgwqDCoMKgIGlmIChwdGVfZGlydHkocHRlbnQpKQo+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCAqYW55X2RpcnR5ID0gdHJ1ZTsKPj4gKwo+PiArwqDCoMKgwqDCoMKgwqAg cGZuKys7Cj4+ICvCoMKgwqDCoMKgwqDCoCBwdGUrKzsKPj4gK8KgwqDCoCB9Cj4+ICsKPj4gK8Kg wqDCoCByZXR1cm4gaTsKPj4gwqAgfQo+PiDCoCDCoCAvKgo+PiAtICogQ29weSBvbmUgcHRlLsKg IFJldHVybnMgMCBpZiBzdWNjZWVkZWQsIG9yIC1FQUdBSU4gaWYgb25lIHByZWFsbG9jYXRlZCBw YWdlCj4+IC0gKiBpcyByZXF1aXJlZCB0byBjb3B5IHRoaXMgcHRlLgo+PiArICogQ29weSBzZXQg b2YgY29udGlndW91cyBwdGVzLsKgIFJldHVybnMgbnVtYmVyIG9mIHB0ZXMgY29waWVkIGlmIHN1 Y2NlZWRlZAo+PiArICogKGFsd2F5cyBndGUgMSksIG9yIC1FQUdBSU4gaWYgb25lIHByZWFsbG9j YXRlZCBwYWdlIGlzIHJlcXVpcmVkIHRvIGNvcHkgdGhlCj4+ICsgKiBmaXJzdCBwdGUuCj4+IMKg wqAgKi8KPj4gwqAgc3RhdGljIGlubGluZSBpbnQKPj4gLWNvcHlfcHJlc2VudF9wdGUoc3RydWN0 IHZtX2FyZWFfc3RydWN0ICpkc3Rfdm1hLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnNyY192bWEs Cj4+IC3CoMKgwqDCoMKgwqDCoMKgIHB0ZV90ICpkc3RfcHRlLCBwdGVfdCAqc3JjX3B0ZSwgdW5z aWduZWQgbG9uZyBhZGRyLCBpbnQgKnJzcywKPj4gLcKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IGZv bGlvICoqcHJlYWxsb2MpCj4+ICtjb3B5X3ByZXNlbnRfcHRlcyhzdHJ1Y3Qgdm1fYXJlYV9zdHJ1 Y3QgKmRzdF92bWEsIHN0cnVjdCB2bV9hcmVhX3N0cnVjdAo+PiAqc3JjX3ZtYSwKPj4gK8KgwqDC oMKgwqDCoMKgwqDCoCBwdGVfdCAqZHN0X3B0ZSwgcHRlX3QgKnNyY19wdGUsCj4+ICvCoMKgwqDC oMKgwqDCoMKgwqAgdW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBsb25nIGVuZCwKPj4gK8Kg wqDCoMKgwqDCoMKgwqDCoCBpbnQgKnJzcywgc3RydWN0IGZvbGlvICoqcHJlYWxsb2MpCj4+IMKg IHsKPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgbW1fc3RydWN0ICpzcmNfbW0gPSBzcmNfdm1hLT52bV9t bTsKPj4gwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIHZtX2ZsYWdzID0gc3JjX3ZtYS0+dm1fZmxh Z3M7Cj4+IMKgwqDCoMKgwqAgcHRlX3QgcHRlID0gcHRlcF9nZXQoc3JjX3B0ZSk7Cj4+IMKgwqDC oMKgwqAgc3RydWN0IHBhZ2UgKnBhZ2U7Cj4+IMKgwqDCoMKgwqAgc3RydWN0IGZvbGlvICpmb2xp bzsKPj4gK8KgwqDCoCBpbnQgbnIgPSAxOwo+PiArwqDCoMKgIGJvb2wgYW5vbjsKPj4gK8KgwqDC oCBib29sIGFueV9kaXJ0eSA9IHB0ZV9kaXJ0eShwdGUpOwo+PiArwqDCoMKgIGludCBpOwo+PiDC oCDCoMKgwqDCoMKgIHBhZ2UgPSB2bV9ub3JtYWxfcGFnZShzcmNfdm1hLCBhZGRyLCBwdGUpOwo+ PiAtwqDCoMKgIGlmIChwYWdlKQo+PiArwqDCoMKgIGlmIChwYWdlKSB7Cj4+IMKgwqDCoMKgwqDC oMKgwqDCoCBmb2xpbyA9IHBhZ2VfZm9saW8ocGFnZSk7Cj4+IC3CoMKgwqAgaWYgKHBhZ2UgJiYg Zm9saW9fdGVzdF9hbm9uKGZvbGlvKSkgewo+PiAtwqDCoMKgwqDCoMKgwqAgLyoKPj4gLcKgwqDC oMKgwqDCoMKgwqAgKiBJZiB0aGlzIHBhZ2UgbWF5IGhhdmUgYmVlbiBwaW5uZWQgYnkgdGhlIHBh cmVudCBwcm9jZXNzLAo+PiAtwqDCoMKgwqDCoMKgwqDCoCAqIGNvcHkgdGhlIHBhZ2UgaW1tZWRp YXRlbHkgZm9yIHRoZSBjaGlsZCBzbyB0aGF0IHdlJ2xsIGFsd2F5cwo+PiAtwqDCoMKgwqDCoMKg wqDCoCAqIGd1YXJhbnRlZSB0aGUgcGlubmVkIHBhZ2Ugd29uJ3QgYmUgcmFuZG9tbHkgcmVwbGFj ZWQgaW4gdGhlCj4+IC3CoMKgwqDCoMKgwqDCoMKgICogZnV0dXJlLgo+PiAtwqDCoMKgwqDCoMKg wqDCoCAqLwo+PiAtwqDCoMKgwqDCoMKgwqAgZm9saW9fZ2V0KGZvbGlvKTsKPj4gLcKgwqDCoMKg wqDCoMKgIGlmICh1bmxpa2VseShwYWdlX3RyeV9kdXBfYW5vbl9ybWFwKHBhZ2UsIGZhbHNlLCBz cmNfdm1hKSkpIHsKPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLyogUGFnZSBtYXkgYmUgcGlu bmVkLCB3ZSBoYXZlIHRvIGNvcHkuICovCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZvbGlv X3B1dChmb2xpbyk7Cj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBjb3B5X3ByZXNl bnRfcGFnZShkc3Rfdm1hLCBzcmNfdm1hLCBkc3RfcHRlLCBzcmNfcHRlLAo+PiAtwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFkZHIsIHJzcywgcHJlYWxs b2MsIHBhZ2UpOwo+PiArwqDCoMKgwqDCoMKgwqAgYW5vbiA9IGZvbGlvX3Rlc3RfYW5vbihmb2xp byk7Cj4+ICvCoMKgwqDCoMKgwqDCoCBuciA9IGZvbGlvX25yX3BhZ2VzX2NvbnRfbWFwcGVkKGZv bGlvLCBwYWdlLCBzcmNfcHRlLCBhZGRyLAo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBlbmQsIHB0ZSwgJmFueV9kaXJ0eSk7Cj4+ICsKPj4gK8KgwqDC oMKgwqDCoMKgIGZvciAoaSA9IDA7IGkgPCBucjsgaSsrLCBwYWdlKyspIHsKPj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqAgaWYgKGFub24pIHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCAvKgo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKiBJZiB0aGlzIHBh Z2UgbWF5IGhhdmUgYmVlbiBwaW5uZWQgYnkgdGhlCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAqIHBhcmVudCBwcm9jZXNzLCBjb3B5IHRoZSBwYWdlIGltbWVkaWF0ZWx5IGZv cgo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKiB0aGUgY2hpbGQgc28gdGhh dCB3ZSdsbCBhbHdheXMgZ3VhcmFudGVlIHRoZQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgKiBwaW5uZWQgcGFnZSB3b24ndCBiZSByYW5kb21seSByZXBsYWNlZCBpbiB0aGUK Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICogZnV0dXJlLgo+PiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKi8KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBpZiAodW5saWtlbHkocGFnZV90cnlfZHVwX2Fub25fcm1hcCgKPj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGFnZSwgZmFsc2UsIHNyY192 bWEpKSkgewo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKGkg IT0gMCkKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg YnJlYWs7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAvKiBQYWdl IG1heSBiZSBwaW5uZWQsIHdlIGhhdmUgdG8gY29weS4gKi8KPj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBjb3B5X3ByZXNlbnRfcGFnZSgKPj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZHN0X3ZtYSwgc3JjX3Zt YSwgZHN0X3B0ZSwKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgc3JjX3B0ZSwgYWRkciwgcnNzLCBwcmVhbGxvYywKPj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGFnZSk7Cj4+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgfQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJzc1tN TV9BTk9OUEFHRVNdKys7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgVk1fQlVH X09OKFBhZ2VBbm9uRXhjbHVzaXZlKHBhZ2UpKTsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAg fSBlbHNlIHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwYWdlX2R1cF9maWxl X3JtYXAocGFnZSwgZmFsc2UpOwo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJz c1ttbV9jb3VudGVyX2ZpbGUocGFnZSldKys7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0K Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIH0KPj4gLcKgwqDCoMKgwqDCoMKgIHJzc1tNTV9BTk9OUEFH RVNdKys7Cj4+IC3CoMKgwqAgfSBlbHNlIGlmIChwYWdlKSB7Cj4+IC3CoMKgwqDCoMKgwqDCoCBm b2xpb19nZXQoZm9saW8pOwo+PiAtwqDCoMKgwqDCoMKgwqAgcGFnZV9kdXBfZmlsZV9ybWFwKHBh Z2UsIGZhbHNlKTsKPj4gLcKgwqDCoMKgwqDCoMKgIHJzc1ttbV9jb3VudGVyX2ZpbGUocGFnZSld Kys7Cj4+ICsKPj4gK8KgwqDCoMKgwqDCoMKgIG5yID0gaTsKPj4gK8KgwqDCoMKgwqDCoMKgIGZv bGlvX3JlZl9hZGQoZm9saW8sIG5yKTsKPiAKPiBZb3UncmUgY2hhbmdpbmcgdGhlIG9yZGVyIG9m IG1hcGNvdW50IHZzLiByZWZjb3VudCBpbmNyZW1lbnQuIERvbid0LiBNYWtlIHN1cmUKPiB5b3Vy IHJlZmNvdW50ID49IG1hcGNvdW50LgoKT3VjaCAtIGdvb2Qgc3BvdC4KCj4gCj4gWW91IGNhbiBk byB0aGF0IGVhc2lseSBieSBkb2luZyB0aGUgZm9saW9fcmVmX2FkZChmb2xpbywgbnIpIGZpcnN0 IGFuZCB0aGVuCj4gZGVjcmVtZW50aW5nIGluIGNhc2Ugb2YgZXJyb3IgYWNjb3JkaW5nbHkuIEVy cm9ycyBkdWUgdG8gcGlubmVkIHBhZ2VzIGFyZSB0aGUKPiBjb3JuZXIgY2FzZS4KClllcCwgcHJv cG9zZSB0aGlzIGZvciB2MzoKCmRpZmYgLS1naXQgYS9tbS9tZW1vcnkuYyBiL21tL21lbW9yeS5j CmluZGV4IGI3YzgyMjg4ODNjZi4uOTgzNzMzNDk4MDZlIDEwMDY0NAotLS0gYS9tbS9tZW1vcnku YworKysgYi9tbS9tZW1vcnkuYwpAQCAtMTAxNCw2ICsxMDE0LDcgQEAgY29weV9wcmVzZW50X3B0 ZXMoc3RydWN0IHZtX2FyZWFfc3RydWN0ICpkc3Rfdm1hLCBzdHJ1Y3QKdm1fYXJlYV9zdHJ1Y3Qg KnNyY192bWEKICAgICAgICAgICAgICAgIGFub24gPSBmb2xpb190ZXN0X2Fub24oZm9saW8pOwog ICAgICAgICAgICAgICAgbnIgPSBmb2xpb19ucl9wYWdlc19jb250X21hcHBlZChmb2xpbywgcGFn ZSwgc3JjX3B0ZSwgYWRkciwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZW5kLCBwdGUsICZhbnlfZGlydHkpOworICAgICAgICAgICAgICAgZm9saW9fcmVm X2FkZChmb2xpbywgbnIpOwoKICAgICAgICAgICAgICAgIGZvciAoaSA9IDA7IGkgPCBucjsgaSsr LCBwYWdlKyspIHsKICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGFub24pIHsKQEAgLTEwMjks NiArMTAzMCw3IEBAIGNvcHlfcHJlc2VudF9wdGVzKHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqZHN0 X3ZtYSwgc3RydWN0CnZtX2FyZWFfc3RydWN0ICpzcmNfdm1hCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpZiAoaSAhPSAwKQogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIC8qIFBhZ2UgbWF5IGJlIHBpbm5lZCwgd2UgaGF2ZSB0byBjb3B5LiAqLwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZm9saW9fcmVmX3N1Yihmb2xp bywgbnIpOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGNv cHlfcHJlc2VudF9wYWdlKAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBkc3Rfdm1hLCBzcmNfdm1hLCBkc3RfcHRlLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBzcmNfcHRlLCBhZGRyLCByc3MsIHByZWFsbG9jLApA QCAtMTA0Miw4ICsxMDQ0LDEwIEBAIGNvcHlfcHJlc2VudF9wdGVzKHN0cnVjdCB2bV9hcmVhX3N0 cnVjdCAqZHN0X3ZtYSwgc3RydWN0CnZtX2FyZWFfc3RydWN0ICpzcmNfdm1hCiAgICAgICAgICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgIH0KCi0gICAgICAgICAgICAgICBuciA9IGk7 Ci0gICAgICAgICAgICAgICBmb2xpb19yZWZfYWRkKGZvbGlvLCBucik7CisgICAgICAgICAgICAg ICBpZiAoaSA8IG5yKSB7CisgICAgICAgICAgICAgICAgICAgICAgIGZvbGlvX3JlZl9zdWIoZm9s aW8sIG5yIC0gaSk7CisgICAgICAgICAgICAgICAgICAgICAgIG5yID0gaTsKKyAgICAgICAgICAg ICAgIH0KICAgICAgICB9Cgo+IAo+IEknbGwgbm90ZSB0aGF0IGl0IHdpbGwgbWFrZSBhIGxvdCBv ZiBzZW5zZSB0byBoYXZlIGJhdGNoIHZhcmlhbnRzIG9mCj4gcGFnZV90cnlfZHVwX2Fub25fcm1h cCgpIGFuZCBwYWdlX2R1cF9maWxlX3JtYXAoKS4KPiAKPiBFc3BlY2lhbGx5LCB0aGUgYmF0Y2gg dmFyaWFudCBvZiBwYWdlX3RyeV9kdXBfYW5vbl9ybWFwKCkgd291bGQgb25seSBjaGVjayBvbmNl Cj4gaWYgdGhlIGZvbGlvIG1heWJlIHBpbm5lZCwgYW5kIGluIHRoYXQgY2FzZSwgeW91IGNhbiBz aW1wbHkgZHJvcCBhbGwgcmVmZXJlbmNlcwo+IGFnYWluLiBTbyB5b3UgZWl0aGVyIGhhdmUgYWxs IG9yIG5vIHB0ZXMgdG8gcHJvY2Vzcywgd2hpY2ggbWFrZXMgdGhhdCBjb2RlIGVhc2llci4KPiAK PiBCdXQgdGhhdCBjYW4gYmUgYWRkZWQgb24gdG9wLCBhbmQgSSdsbCBoYXBwaWx5IGRvIHRoYXQu CgpUaGF0J3MgdmVyeSBraW5kIC0gdGhhbmtzIGZvciB0aGUgb2ZmZXIhIEknbGwgbGVhdmUgaXQg dG8geW91IHRoZW4uCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 588CFC197A0 for ; Thu, 16 Nov 2023 10:26:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9F5F6B044F; Thu, 16 Nov 2023 05:26:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4E156B0451; Thu, 16 Nov 2023 05:26:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B17176B0452; Thu, 16 Nov 2023 05:26:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9E4386B044F for ; Thu, 16 Nov 2023 05:26:45 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 722D1140C2A for ; Thu, 16 Nov 2023 10:26:45 +0000 (UTC) X-FDA: 81463438770.02.999E015 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 77A8D160004 for ; Thu, 16 Nov 2023 10:26:43 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700130403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vT4gt85geZkwMlK2ePX3bGk+fMOV3urHN7s9kVWvPoA=; b=rurvFj6hLuWV0QOMT50WzDRDLgdxPItjPa2BaILjmK7gpWv5jYOABIPSgqjP4Kkh2etPiz Xm2VOvNUKACQp0k1G1BPI6e9mdvcAu3rT+7+i+0jBm3trqzZDmhdU2Fh58Wfd5eT7AEtog NfhmDOoWfhHeWIzFcPR3iRz8iLde++A= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700130403; a=rsa-sha256; cv=none; b=zrkmEWS48GEyTI5dTK8PHwzF1D7KdtsgZuVtdif7lA6QFIN0463pEcVKKDW9ug7vtHWJvT ZmRE0w1OEdglI+Y3nuVFkG4TF78s2F0vHv/FVOSX0K5Ili0psZl5RcaKN79AhQMXmII9oB voqB5Q41HI6O7IItni3XiEJy5uncL14= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6E571595; Thu, 16 Nov 2023 02:27:28 -0800 (PST) Received: from [10.1.35.163] (XHFQ2J9959.cambridge.arm.com [10.1.35.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F0F43F6C4; Thu, 16 Nov 2023 02:26:39 -0800 (PST) Message-ID: Date: Thu, 16 Nov 2023 10:26:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/14] mm: Batch-copy PTE ranges during fork() Content-Language: en-GB To: David Hildenbrand , Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Anshuman Khandual , Matthew Wilcox , Yu Zhao , Mark Rutland , Kefeng Wang , John Hubbard , Zi Yan Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20231115163018.1303287-1-ryan.roberts@arm.com> <20231115163018.1303287-2-ryan.roberts@arm.com> <271f1e98-6217-4b40-bae0-0ac9fe5851cb@redhat.com> From: Ryan Roberts In-Reply-To: <271f1e98-6217-4b40-bae0-0ac9fe5851cb@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 77A8D160004 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: imk9qrxfeus8i8x4co93atdrbrc5qrdm X-HE-Tag: 1700130403-105827 X-HE-Meta: U2FsdGVkX182ewTG9HHB81SQQDiCIsb4Qp9uBIKiC6f8L/KmJJoUZOgeSPfkRMetW6XEQpvRBUPn9O9l+t3wdAeHcJO7aasSAHCpSmjlXrUisCXEBZ03JeebH7Wo2obuEN/e819I61JRnL8NV9GVLXxyRFIqrtxraWxog1c2zM9mSMz6YklK1Ws3rlOTZQfs0KZZZAXKwD2rQ/nn6WMD0t9L7oxSxu44rG0T7UBUK/WOV1Z7BTEKiMd3tC8hTTVFjDvBvk/IyDJDXgH3ijkbaNGKyC264it4aS42pffx+GvZ5ugXUlVQAUgYAiFC6UeZBTUbxGL0SbMzWeZToOs93Oqp258MUZj9+v6LNFfUHDChc88rcWvy5/D0pjm41zCcGvt6K2mYvGhS274LNe1n9+fu0JVuGymeILuV41E8gPHsFg1mRK4pqlia0NgI16l4T0gV6LHgQwt5l/hKPL1taGaBS22uX30hlXbzrIvNv4msZpw7eR7njUoHOfYQqhYEVH6KvOTbEdXFElbsDYTobc3RLQdjGSol7zhfYcSO1p47wOe2/cPrTBAedjn2JUpIaPYDP5WOlaL5n3+Gxdm6faMqXQgS4TE/Jsb+3MAK3rEVDQ1NcV1XFt5T5pyPYiM5coGdU/FOGYtJfVtwFUP7UGbkRZuthZ352G6t5YyU6QjnSAIykGbicJJu/ZSA38YYTAGBP6ZC57gAydYXU4s5rtt7gfuLfUedjC2fIA+jdrwTrL/EPRm9isTnmsYYeA1eQ8TUmB5pt5jEkWdZi9hzborB4Wd9n+YakNqUYoV3cnXh0zVy0Q8HjuqZhLXodsOLEMKqoRSwRXgkoNKjJLPyjjyMOjYCZRTIc0EuBDw+QngcFezbtzt0yh7tz/yeIJuufNhTMrm7bWTWn0fZTmOv73rBbGq/iHm5sj3I53BhHbMjlEkswS1EyH8KOUlQPFBBQ8s6v6t7otk/8ZCWEEX i6vqMySS YZnAeEXTQCF/dJXq717jzjiZqULUdHX71Knz0x1TNLbHp429scfRJiSLK1SCJtE4wLIajKDzPSMZHZYUxKrVdimxeYXJ81by91U+nlsV/dEGTw7RPMB3D9jhpudtRi22CiQIUOV9ChA+ZxYvJThfqbZ6OzDkyymhnWBdigqyuCzmQyEziaIZsWbGl6Ke8u4y1tIsnM8dVOcnU5JTDr59kEM4571f/QjHhHxXFhgok1FER7L6vEOIjMK19RW+J+Ags6WaVg1R5NbaSek6gEf7xaWoQqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16/11/2023 10:03, David Hildenbrand wrote: > On 15.11.23 17:30, Ryan Roberts wrote: >> Convert copy_pte_range() to copy a set of ptes in a batch. A given batch >> maps a physically contiguous block of memory, all belonging to the same >> folio, with the same permissions, and for shared mappings, the same >> dirty state. This will likely improve performance by a tiny amount due >> to batching the folio reference count management and calling set_ptes() >> rather than making individual calls to set_pte_at(). >> >> However, the primary motivation for this change is to reduce the number >> of tlb maintenance operations that the arm64 backend has to perform >> during fork, as it is about to add transparent support for the >> "contiguous bit" in its ptes. By write-protecting the parent using the >> new ptep_set_wrprotects() (note the 's' at the end) function, the >> backend can avoid having to unfold contig ranges of PTEs, which is >> expensive, when all ptes in the range are being write-protected. >> Similarly, by using set_ptes() rather than set_pte_at() to set up ptes >> in the child, the backend does not need to fold a contiguous range once >> they are all populated - they can be initially populated as a contiguous >> range in the first place. >> >> This change addresses the core-mm refactoring only, and introduces >> ptep_set_wrprotects() with a default implementation that calls >> ptep_set_wrprotect() for each pte in the range. A separate change will >> implement ptep_set_wrprotects() in the arm64 backend to realize the >> performance improvement as part of the work to enable contpte mappings. >> >> Signed-off-by: Ryan Roberts >> --- >>   include/linux/pgtable.h |  13 +++ >>   mm/memory.c             | 175 +++++++++++++++++++++++++++++++--------- >>   2 files changed, 150 insertions(+), 38 deletions(-) >> >> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h >> index af7639c3b0a3..1c50f8a0fdde 100644 >> --- a/include/linux/pgtable.h >> +++ b/include/linux/pgtable.h >> @@ -622,6 +622,19 @@ static inline void ptep_set_wrprotect(struct mm_struct >> *mm, unsigned long addres >>   } >>   #endif >>   +#ifndef ptep_set_wrprotects >> +struct mm_struct; >> +static inline void ptep_set_wrprotects(struct mm_struct *mm, >> +                unsigned long address, pte_t *ptep, >> +                unsigned int nr) >> +{ >> +    unsigned int i; >> + >> +    for (i = 0; i < nr; i++, address += PAGE_SIZE, ptep++) >> +        ptep_set_wrprotect(mm, address, ptep); >> +} >> +#endif >> + >>   /* >>    * On some architectures hardware does not set page access bit when accessing >>    * memory page, it is responsibility of software setting this bit. It brings >> diff --git a/mm/memory.c b/mm/memory.c >> index 1f18ed4a5497..b7c8228883cf 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -921,46 +921,129 @@ copy_present_page(struct vm_area_struct *dst_vma, >> struct vm_area_struct *src_vma >>           /* Uffd-wp needs to be delivered to dest pte as well */ >>           pte = pte_mkuffd_wp(pte); >>       set_pte_at(dst_vma->vm_mm, addr, dst_pte, pte); >> -    return 0; >> +    return 1; >> +} >> + >> +static inline unsigned long page_cont_mapped_vaddr(struct page *page, >> +                struct page *anchor, unsigned long anchor_vaddr) >> +{ >> +    unsigned long offset; >> +    unsigned long vaddr; >> + >> +    offset = (page_to_pfn(page) - page_to_pfn(anchor)) << PAGE_SHIFT; >> +    vaddr = anchor_vaddr + offset; >> + >> +    if (anchor > page) { >> +        if (vaddr > anchor_vaddr) >> +            return 0; >> +    } else { >> +        if (vaddr < anchor_vaddr) >> +            return ULONG_MAX; >> +    } >> + >> +    return vaddr; >> +} >> + >> +static int folio_nr_pages_cont_mapped(struct folio *folio, >> +                      struct page *page, pte_t *pte, >> +                      unsigned long addr, unsigned long end, >> +                      pte_t ptent, bool *any_dirty) >> +{ >> +    int floops; >> +    int i; >> +    unsigned long pfn; >> +    pgprot_t prot; >> +    struct page *folio_end; >> + >> +    if (!folio_test_large(folio)) >> +        return 1; >> + >> +    folio_end = &folio->page + folio_nr_pages(folio); >> +    end = min(page_cont_mapped_vaddr(folio_end, page, addr), end); >> +    floops = (end - addr) >> PAGE_SHIFT; >> +    pfn = page_to_pfn(page); >> +    prot = pte_pgprot(pte_mkold(pte_mkclean(ptent))); >> + >> +    *any_dirty = pte_dirty(ptent); >> + >> +    pfn++; >> +    pte++; >> + >> +    for (i = 1; i < floops; i++) { >> +        ptent = ptep_get(pte); >> +        ptent = pte_mkold(pte_mkclean(ptent)); >> + >> +        if (!pte_present(ptent) || pte_pfn(ptent) != pfn || >> +            pgprot_val(pte_pgprot(ptent)) != pgprot_val(prot)) >> +            break; >> + >> +        if (pte_dirty(ptent)) >> +            *any_dirty = true; >> + >> +        pfn++; >> +        pte++; >> +    } >> + >> +    return i; >>   } >>     /* >> - * Copy one pte.  Returns 0 if succeeded, or -EAGAIN if one preallocated page >> - * is required to copy this pte. >> + * Copy set of contiguous ptes.  Returns number of ptes copied if succeeded >> + * (always gte 1), or -EAGAIN if one preallocated page is required to copy the >> + * first pte. >>    */ >>   static inline int >> -copy_present_pte(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, >> -         pte_t *dst_pte, pte_t *src_pte, unsigned long addr, int *rss, >> -         struct folio **prealloc) >> +copy_present_ptes(struct vm_area_struct *dst_vma, struct vm_area_struct >> *src_vma, >> +          pte_t *dst_pte, pte_t *src_pte, >> +          unsigned long addr, unsigned long end, >> +          int *rss, struct folio **prealloc) >>   { >>       struct mm_struct *src_mm = src_vma->vm_mm; >>       unsigned long vm_flags = src_vma->vm_flags; >>       pte_t pte = ptep_get(src_pte); >>       struct page *page; >>       struct folio *folio; >> +    int nr = 1; >> +    bool anon; >> +    bool any_dirty = pte_dirty(pte); >> +    int i; >>         page = vm_normal_page(src_vma, addr, pte); >> -    if (page) >> +    if (page) { >>           folio = page_folio(page); >> -    if (page && folio_test_anon(folio)) { >> -        /* >> -         * If this page may have been pinned by the parent process, >> -         * copy the page immediately for the child so that we'll always >> -         * guarantee the pinned page won't be randomly replaced in the >> -         * future. >> -         */ >> -        folio_get(folio); >> -        if (unlikely(page_try_dup_anon_rmap(page, false, src_vma))) { >> -            /* Page may be pinned, we have to copy. */ >> -            folio_put(folio); >> -            return copy_present_page(dst_vma, src_vma, dst_pte, src_pte, >> -                         addr, rss, prealloc, page); >> +        anon = folio_test_anon(folio); >> +        nr = folio_nr_pages_cont_mapped(folio, page, src_pte, addr, >> +                        end, pte, &any_dirty); >> + >> +        for (i = 0; i < nr; i++, page++) { >> +            if (anon) { >> +                /* >> +                 * If this page may have been pinned by the >> +                 * parent process, copy the page immediately for >> +                 * the child so that we'll always guarantee the >> +                 * pinned page won't be randomly replaced in the >> +                 * future. >> +                 */ >> +                if (unlikely(page_try_dup_anon_rmap( >> +                        page, false, src_vma))) { >> +                    if (i != 0) >> +                        break; >> +                    /* Page may be pinned, we have to copy. */ >> +                    return copy_present_page( >> +                        dst_vma, src_vma, dst_pte, >> +                        src_pte, addr, rss, prealloc, >> +                        page); >> +                } >> +                rss[MM_ANONPAGES]++; >> +                VM_BUG_ON(PageAnonExclusive(page)); >> +            } else { >> +                page_dup_file_rmap(page, false); >> +                rss[mm_counter_file(page)]++; >> +            } >>           } >> -        rss[MM_ANONPAGES]++; >> -    } else if (page) { >> -        folio_get(folio); >> -        page_dup_file_rmap(page, false); >> -        rss[mm_counter_file(page)]++; >> + >> +        nr = i; >> +        folio_ref_add(folio, nr); > > You're changing the order of mapcount vs. refcount increment. Don't. Make sure > your refcount >= mapcount. Ouch - good spot. > > You can do that easily by doing the folio_ref_add(folio, nr) first and then > decrementing in case of error accordingly. Errors due to pinned pages are the > corner case. Yep, propose this for v3: diff --git a/mm/memory.c b/mm/memory.c index b7c8228883cf..98373349806e 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1014,6 +1014,7 @@ copy_present_ptes(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma anon = folio_test_anon(folio); nr = folio_nr_pages_cont_mapped(folio, page, src_pte, addr, end, pte, &any_dirty); + folio_ref_add(folio, nr); for (i = 0; i < nr; i++, page++) { if (anon) { @@ -1029,6 +1030,7 @@ copy_present_ptes(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma if (i != 0) break; /* Page may be pinned, we have to copy. */ + folio_ref_sub(folio, nr); return copy_present_page( dst_vma, src_vma, dst_pte, src_pte, addr, rss, prealloc, @@ -1042,8 +1044,10 @@ copy_present_ptes(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma } } - nr = i; - folio_ref_add(folio, nr); + if (i < nr) { + folio_ref_sub(folio, nr - i); + nr = i; + } } > > I'll note that it will make a lot of sense to have batch variants of > page_try_dup_anon_rmap() and page_dup_file_rmap(). > > Especially, the batch variant of page_try_dup_anon_rmap() would only check once > if the folio maybe pinned, and in that case, you can simply drop all references > again. So you either have all or no ptes to process, which makes that code easier. > > But that can be added on top, and I'll happily do that. That's very kind - thanks for the offer! I'll leave it to you then.