From: "Li, Tianyou" <tianyou.li@intel.com>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>,
Oscar Salvador <osalvador@suse.de>,
Mike Rapoport <rppt@kernel.org>,
Wei Yang <richard.weiyang@gmail.com>
Cc: <linux-mm@kvack.org>, Yong Hu <yong.hu@intel.com>,
Nanhai Zou <nanhai.zou@intel.com>, Yuan Liu <yuan1.liu@intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Yu C Chen <yu.c.chen@intel.com>, Pan Deng <pan.deng@intel.com>,
Chen Zhang <zhangchen.kidd@jd.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] mm/memory hotplug/unplug: Optimize zone->contiguous update when move pfn range
Date: Mon, 1 Dec 2025 20:28:13 +0800 [thread overview]
Message-ID: <e54741dc-2fcf-404a-bb28-4cee6db3bd4c@intel.com> (raw)
In-Reply-To: <123e0d99-ef29-4906-828a-9dfd29dafd29@kernel.org>
Thanks David for your time to review.
On 11/29/2025 12:04 AM, David Hildenbrand (Red Hat) wrote:
>>
>> Instead of a bool value, could the clear_zone_contiguous_for_growing
>> and clear_zone_contiguous_for_shrinking return a enum value to indicate
>> one of the three states: 1. DEFINITELY_CONTIGUOUS;
>> 2. DEFINITELY_NOT_CONTIGUOUS; 3. UNDETERMINED_CONTIGUOUS? The
>> set_zone_contiguous took the state and skip the contiguous check if
>> DEFINITELY_CONTIGUOUS or DEFINITELY_NOT_CONTIGUOUS.
>
> I had the exact same thought while writing my rely, so it's worth
> investigating.
>
> If that helps to come up with even better+descriptive
> variable/function names, even better :)
>
I've created a patch v4 for review in a new thread as previously
suggested, Yuan Liu added the test result for memory plug and unplug.
Welcome for any comments or suggestions. Appreciated.
Regards,
Tianyou
prev parent reply other threads:[~2025-12-01 12:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 3:30 [PATCH] mm/memory hotplug/unplug: Optimize zone->contiguous update when move pfn range Tianyou Li
2025-11-17 2:38 ` Li, Tianyou
2025-11-17 11:57 ` David Hildenbrand (Red Hat)
2025-11-18 9:07 ` Li, Tianyou
2025-11-18 5:13 ` Mike Rapoport
2025-11-18 9:28 ` Li, Tianyou
2025-11-18 9:35 ` Li, Tianyou
2025-11-18 10:31 ` Li, Tianyou
2025-11-19 4:07 ` [PATCH v2] " Tianyou Li
2025-11-19 3:13 ` Li, Tianyou
2025-11-28 11:49 ` David Hildenbrand (Red Hat)
2025-11-28 13:33 ` Li, Tianyou
2025-11-19 11:42 ` Wei Yang
2025-11-19 12:41 ` Li, Tianyou
2025-11-19 12:44 ` Wei Yang
2025-11-19 13:16 ` Li, Tianyou
2025-11-19 14:06 ` [PATCH v3] " Tianyou Li
2025-11-20 12:00 ` Mike Rapoport
2025-11-20 14:21 ` Li, Tianyou
2025-11-28 12:01 ` David Hildenbrand (Red Hat)
2025-11-28 15:17 ` Li, Tianyou
2025-11-28 16:04 ` David Hildenbrand (Red Hat)
2025-12-01 12:28 ` Li, Tianyou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e54741dc-2fcf-404a-bb28-4cee6db3bd4c@intel.com \
--to=tianyou.li@intel.com \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nanhai.zou@intel.com \
--cc=osalvador@suse.de \
--cc=pan.deng@intel.com \
--cc=qiuxu.zhuo@intel.com \
--cc=richard.weiyang@gmail.com \
--cc=rppt@kernel.org \
--cc=tim.c.chen@linux.intel.com \
--cc=yong.hu@intel.com \
--cc=yu.c.chen@intel.com \
--cc=yuan1.liu@intel.com \
--cc=zhangchen.kidd@jd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.