From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1muOfs-0006Kp-EO for mharc-grub-devel@gnu.org; Mon, 06 Dec 2021 19:49:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muOfq-0006Kc-2j for grub-devel@gnu.org; Mon, 06 Dec 2021 19:49:38 -0500 Received: from [2607:f8b0:4864:20::82a] (port=42838 helo=mail-qt1-x82a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1muOfm-0002Z4-4z for grub-devel@gnu.org; Mon, 06 Dec 2021 19:49:37 -0500 Received: by mail-qt1-x82a.google.com with SMTP id z9so12692096qtj.9 for ; Mon, 06 Dec 2021 16:49:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=19FG9muIX1vLHjexQPXYQVhgKnoYyEJh1DlbK5y62eg=; b=PzE1DK6ZS0SJIBXLdny74MK+3LCpoCcgjGtTLCfSoT6gWzqd1lr2gDBRZgzu6iX60Z sBqbEbJ47++hfr3CHi3qDjlZNmYYzbVsUOvPr8x3kKhfllcB7yZyoirlRbD4KaGBN7rP D90Ux9DHN3iuz33rCMSeJYejLtFQVvaISA2YFuh3eV4lspp6CFLLBL2d/EOSW/X3fQbW T7jbqvoH4bjgp4C85de04v5lXx7Rh7O9rIbbHJ3/Tzu+r7LHXG5YX8Qc4zgJ6beWFT2J sj6uljjj3fS8Oj//Pf1AqJOO3Win6mcATo6lKNkDnAk3hp516rMHgRK1UHB6UnSnJqXm hrFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=19FG9muIX1vLHjexQPXYQVhgKnoYyEJh1DlbK5y62eg=; b=28vn21pybvNs7JIln+i11NFCQRfksNlDveZ5V43tHByH8hnV2vUe1LiCXArUQXh9Z3 tBqZuA3Fw+Ph0a8fdkgPrM2sBYkTZ+uCrUiINR4ntNpTzhBFqEsEWhF/RZeUknfHq0Yf Rf+78EX2UapUPv1jLZynIz2Cw5gP1IluB2YHqkeLV+QQWwvWqmBiPSaNfmDQXrkynu8L W/otkk0uTDwWFYTx3VcmWGGLnuVxDbZTN1AEoOw3ha5hkE9vj6jh0vVUWXG0hqgcPdSk IdTMlK9zFklatukzZvb3ANIWgFApi8IWbS26tnPCUJq73W2E1Ik4NLMVD8boKS8FfvCP v8YQ== X-Gm-Message-State: AOAM533NVYMmw45dJCuEv5E7UMedHBPYsM8MetywDDLBruK0tBN6mERp cFR9PMhRO6jSlS8/xL821GVKfyLGvbY= X-Google-Smtp-Source: ABdhPJw9I9VvnMXYTWZQkY2IQyVg3sxNZxc3XOrynRnYo/uW0F88e0mX4Twqlj4DA3WDzr7AsOXSAg== X-Received: by 2002:a05:622a:1043:: with SMTP id f3mr43009696qte.233.1638838171449; Mon, 06 Dec 2021 16:49:31 -0800 (PST) Received: from ?IPv6:2602:ae:136d:6d00:c830:d24c:7ae6:ed8c? ([2602:ae:136d:6d00:c830:d24c:7ae6:ed8c]) by smtp.gmail.com with ESMTPSA id y11sm8636736qta.6.2021.12.06.16.49.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Dec 2021 16:49:31 -0800 (PST) Subject: Re: [PATCH] Add Fedora location of DejaVu SANS font To: grub-devel@gnu.org References: <20211206222542.20068-1-rharwood@redhat.com> From: Nicholas Vinson Message-ID: Date: Mon, 6 Dec 2021 19:49:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211206222542.20068-1-rharwood@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::82a (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::82a; envelope-from=nvinson234@gmail.com; helo=mail-qt1-x82a.google.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, NICE_REPLY_A=-2.076, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2021 00:49:38 -0000 On 12/6/21 17:25, Robbie Harwood wrote: > From: fluteze > > In Fedora 35, and possibly earlier, grub would fail to configure with a > complaint about DejaVu being "not found" even though it was installed. > The DejaVu sans font search path is updated to reflect the > distribution's current install path. > > Signed-off-by: Erik Edwards > [rharwood@redhat.com: slight commit message edits] > Signed-off-by: Robbie Harwood > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 8d1c81a73..5186eab2c 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1725,7 +1725,7 @@ fi > > if test x"$starfield_excuse" = x; then > for ext in pcf pcf.gz bdf bdf.gz ttf ttf.gz; do > - for dir in . /usr/src /usr/share/fonts/X11/misc /usr/share/fonts/truetype/ttf-dejavu /usr/share/fonts/dejavu /usr/share/fonts/truetype; do > + for dir in . /usr/src /usr/share/fonts/X11/misc /usr/share/fonts/truetype/ttf-dejavu /usr/share/fonts/dejavu /usr/share/fonts/truetype /usr/share/fonts/dejavu-sans-fonts; do Wouldn't it be better to modify configure.ac so the location could be passed in instead of having one-off patches for alternate locations? Something like --with-dejavu-font=/usr/share/fonts/dejavu-sans-fonts? > if test -f "$dir/DejaVuSans.$ext"; then > DJVU_FONT_SOURCE="$dir/DejaVuSans.$ext" > break 2 >