All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: shuah@kernel.org, keescook@chromium.org, luto@amacapital.net,
	wad@chromium.org, linux-kselftest@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] testing: kselftest_harness: add filtering and enumerating tests
Date: Thu, 9 Jun 2022 16:35:28 -0600	[thread overview]
Message-ID: <e57e0ac4-ed14-4e8b-be18-e8ebff0f0573@linuxfoundation.org> (raw)
In-Reply-To: <20220609143607.2aec9bb8@kernel.org>

On 6/9/22 3:36 PM, Jakub Kicinski wrote:
> On Thu, 9 Jun 2022 14:59:18 -0600 Shuah Khan wrote:
>> Change this to use getopt() to simplify argument parsing and make
>> it easier to maintain.
> 
> Sure thing! Do the options themselves make sense? I wasn't sure if
> there are some restrictions or standards since the output is TAP
> compatible, AFAIU. Or maybe someone has better ideas.
> 

As for options - please see below:

>>    Usage: ./tools/testing/selftests/net/tls [-h|-l] [-t|-T|-v|-V|-f|-F|-r name]
>>     -h       print help
>>     -l       list all tests
>>
>>     -t name  include test
>>     -T name  exclude test

Can be simplified to not include test name by default - drop -T

>>     -v name  include variant
>>     -V name  exclude variant

Same here - drop -V

>>     -f name  include fixture
>>     -F name  exclude fixture

Same here - drop -F
>>     -r name  run specified test
>>

Other choices look fine to me.

thanks,
-- Shuah

  reply	other threads:[~2022-06-09 22:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 20:24 [PATCH] testing: kselftest_harness: add filtering and enumerating tests Jakub Kicinski
2022-06-09 20:59 ` Shuah Khan
2022-06-09 21:36   ` Jakub Kicinski
2022-06-09 22:35     ` Shuah Khan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-26 22:15 Jakub Kicinski
2023-01-25 23:13 Jakub Kicinski
2023-01-26 23:02 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e57e0ac4-ed14-4e8b-be18-e8ebff0f0573@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=shuah@kernel.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.