From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jOWQ+NVg" Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3CEDF0; Mon, 4 Dec 2023 07:23:29 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-54bfa9b3ffaso5891059a12.1; Mon, 04 Dec 2023 07:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701703408; x=1702308208; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mxYp/TPj2SDljkx7akhBocUojf/1bHbrDV2kmdKcuiw=; b=jOWQ+NVgcA55mkrS1YmqfA6St67vuu1Sci23Ov0LAmtm7JCw3n72rwwNXa1QH8xBu2 6zH+DW9Psuo44vmLIEjCxVl94tGIwYrhUMq4n79IUflTELifgWsckVZ2eVLpiuE/vICK V1jbzkp2UTv6d+KtgxOrqgWKk30LMQs6o2/6L6GyeMh1A88KwMKzLdV9mzh6gBvYWkYN HR+3BUbI/uLUv8SN+qZ847+oaoF81p11naoaaxlwCELmNuwAxfvGoaIfflaEU4d8hbB1 O4hvsywb/8yXENsAEQG1H/pwFp4g10uObgB8qHaXTltCyL2/piFfDW8pxo+EF3yMhKa7 4dlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701703408; x=1702308208; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mxYp/TPj2SDljkx7akhBocUojf/1bHbrDV2kmdKcuiw=; b=gNFTfbx8mZfS3eZM7Hw3RHYQ370c/gBhOlcrBWCKSndsW56mLpY7Pri+02MwatpIAs WNjNu4P118zuS6hzG5bSdeUvzX90wE3Yp9+OAvZokp0XKUUsPf1vGGjpaG7/C1/HKctv xC1iLHTFnzFRt6fivFrcs+o0LHfJkth09yZGF+ZF9bHA2gC2vXjely69C3vHIcm7k4pO bZxPrGcdmk8cfXswaf2wb5TrNqRenNbxoH62kZWeLmyEeSMyufokEGB/xPrkHK4LYjEW mynRkBNKflfaj8X+SrFEzvJ5yz48DGLHrBvbzsRbImBbBOKna9yDEg8w9jIBkQcmyM2Y 1qhA== X-Gm-Message-State: AOJu0YyqhSpimtX6YCV+T8Tkrh27bo0CcdwJ2kUCjHdvTezZ8jEqI/Hv WrrPHigh00mo3VxWuoGTzA== X-Google-Smtp-Source: AGHT+IH6NaMxB0hD8p+w4THyQqPHgLUhFhYRDIhCfbDi49ieB3DqkYaAbCCN/8DRLm52i+pnC1Tesg== X-Received: by 2002:a17:907:2daa:b0:a19:a1ba:8cc2 with SMTP id gt42-20020a1709072daa00b00a19a1ba8cc2mr3994784ejc.96.1701703407956; Mon, 04 Dec 2023 07:23:27 -0800 (PST) Received: from ?IPV6:2a02:810b:f40:4300:55ff:210b:5393:c9d7? ([2a02:810b:f40:4300:55ff:210b:5393:c9d7]) by smtp.gmail.com with ESMTPSA id s7-20020a170906bc4700b00a0f78db91c3sm5416316ejv.95.2023.12.04.07.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Dec 2023 07:23:27 -0800 (PST) Message-ID: Date: Mon, 4 Dec 2023 16:23:26 +0100 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] ARM: dts: rockchip: Add power-controller for RK3128 To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Daniel Vetter , David Airlie , Thomas Zimmermann , Maxime Ripard , Maarten Lankhorst , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org References: <20231202125144.66052-1-knaerzche@gmail.com> <4891026.6YUMPnJmAY@diego> <4dec2316-f840-44ab-a07a-3d7f0e5e6d8f@gmail.com> <9588573.jRhZ6ZUK3Y@diego> Content-Language: en-US From: Alex Bee In-Reply-To: <9588573.jRhZ6ZUK3Y@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Heiko, Am 03.12.23 um 17:42 schrieb Heiko Stübner: > Hi Alex, > > Am Sonntag, 3. Dezember 2023, 17:05:47 CET schrieb Alex Bee: >> Am 02.12.23 um 18:46 schrieb Heiko Stübner: >>> Am Samstag, 2. Dezember 2023, 17:36:15 CET schrieb Alex Bee: >>>> Am 02.12.23 um 16:51 schrieb Heiko Stübner: >>>>> Am Samstag, 2. Dezember 2023, 13:51:41 CET schrieb Alex Bee: >>>>>> Add power controller and qos nodes for RK3128 in order to use >>>>>> them as powerdomains. >>>>> does the power-domain controller work with the incomplete set of >>>>> pm-domains too? >>>> Yes, it does - the missing domains can request idle only and can't be >>>> powered on/off - if no one requests idle they are just up all the time. >>>> >>>>> What I have in mind is >>>>> - adding the power-controller node with the existing set of power-domains >>>>> - the gpu pm-domain is in there >>>>> - adding the gpu parts >>>> My main concern about adding them later was the change of the ABI after >>>> they've been exposed in the SoC DT. If that's not an issue - sure: I can >>>> add them in a separate series. >>> An ABI change would be _changing_ the domain-ids in the rk3128-power.h >>> I think :-) . >> Well, an addition is still a change. >>> Right now the existing domain ids in the header are already exposed to the >>> world, so someone could already use them, but not the new ones. >> I'm fully aware that nothing would ever hard fail anywhere if the new >> domain ids get added later. >> >> Nevertheless we start using here an ABI which is known to be incomplete. >> For no reason, as the patches (which I am now asked to remove from this >> series) for completion are already there (here). >> >> Anyway, if you prefer it this way: I'm pleased to do so. > I was more thinking of accelerating the gpu-part of the series, as that > really is just waiting for the power-domain node that already has driver > support and domain-ids present. > > It looks like you're feeling more strongly about that though, so I'll > definitly not pressure you ;-) . I'm really not insisting on this - I just didn't understand why you would want this. And honestly I haven't considered merging timeline as an argument. So sure: Let's get the low hanging fruits merged for 6.8. Having the power domains in the DT will also help for my upcoming hdmi / vop series. Alex > > But I guess the split into IDs and driver change should still be > done, especially as the dt-binding-header likely will want an Ack > from the DT maintainers. > > And the power-domain change will go through the new pmdomain > subsystem. > > > Heiko > > >>>>> And a second series with >>>>> - patch1 from here >>>>> - a dts patch adding the additional pm-domains to rk3128.dtsi >>>>> - I guess patch1 also should be split into a patch adding the binding-ids >>>>> and a separate patch for the code addition. >>>> Yeah, I noticed this also :) >>>> >>>> Regards, >>>> >>>> Alex >>>> >>>>> Heiko >>>>> >>>>>> Signed-off-by: Alex Bee >>>>>> --- >>>>>> arch/arm/boot/dts/rockchip/rk3128.dtsi | 101 +++++++++++++++++++++++++ >>>>>> 1 file changed, 101 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm/boot/dts/rockchip/rk3128.dtsi b/arch/arm/boot/dts/rockchip/rk3128.dtsi >>>>>> index 4e8b38604ecd..b72905db04f7 100644 >>>>>> --- a/arch/arm/boot/dts/rockchip/rk3128.dtsi >>>>>> +++ b/arch/arm/boot/dts/rockchip/rk3128.dtsi >>>>>> @@ -8,6 +8,7 @@ >>>>>> #include >>>>>> #include >>>>>> #include >>>>>> +#include >>>>>> >>>>>> / { >>>>>> compatible = "rockchip,rk3128"; >>>>>> @@ -133,6 +134,106 @@ smp-sram@0 { >>>>>> pmu: syscon@100a0000 { >>>>>> compatible = "rockchip,rk3128-pmu", "syscon", "simple-mfd"; >>>>>> reg = <0x100a0000 0x1000>; >>>>>> + >>>>>> + power: power-controller { >>>>>> + compatible = "rockchip,rk3128-power-controller"; >>>>>> + #power-domain-cells = <1>; >>>>>> + #address-cells = <1>; >>>>>> + #size-cells = <0>; >>>>>> + >>>>>> + power-domain@RK3128_PD_VIO { >>>>>> + reg = ; >>>>>> + clocks = <&cru ACLK_CIF>, >>>>>> + <&cru HCLK_CIF>, >>>>>> + <&cru DCLK_EBC>, >>>>>> + <&cru HCLK_EBC>, >>>>>> + <&cru ACLK_IEP>, >>>>>> + <&cru HCLK_IEP>, >>>>>> + <&cru ACLK_LCDC0>, >>>>>> + <&cru HCLK_LCDC0>, >>>>>> + <&cru PCLK_MIPI>, >>>>>> + <&cru ACLK_RGA>, >>>>>> + <&cru HCLK_RGA>, >>>>>> + <&cru ACLK_VIO0>, >>>>>> + <&cru ACLK_VIO1>, >>>>>> + <&cru HCLK_VIO>, >>>>>> + <&cru HCLK_VIO_H2P>, >>>>>> + <&cru DCLK_VOP>, >>>>>> + <&cru SCLK_VOP>; >>>>>> + pm_qos = <&qos_ebc>, >>>>>> + <&qos_iep>, >>>>>> + <&qos_lcdc>, >>>>>> + <&qos_rga>, >>>>>> + <&qos_vip>; >>>>>> + #power-domain-cells = <0>; >>>>>> + }; >>>>>> + >>>>>> + power-domain@RK3128_PD_VIDEO { >>>>>> + reg = ; >>>>>> + clocks = <&cru ACLK_VDPU>, >>>>>> + <&cru HCLK_VDPU>, >>>>>> + <&cru ACLK_VEPU>, >>>>>> + <&cru HCLK_VEPU>, >>>>>> + <&cru SCLK_HEVC_CORE>; >>>>>> + pm_qos = <&qos_vpu>; >>>>>> + #power-domain-cells = <0>; >>>>>> + }; >>>>>> + >>>>>> + power-domain@RK3128_PD_GPU { >>>>>> + reg = ; >>>>>> + clocks = <&cru ACLK_GPU>; >>>>>> + pm_qos = <&qos_gpu>; >>>>>> + #power-domain-cells = <0>; >>>>>> + }; >>>>>> + >>>>>> + power-domain@RK3128_PD_CRYPTO { >>>>>> + reg = ; >>>>>> + clocks = <&cru HCLK_CRYPTO>, >>>>>> + <&cru SCLK_CRYPTO>; >>>>>> + pm_qos = <&qos_crypto>; >>>>>> + #power-domain-cells = <0>; >>>>>> + }; >>>>>> + }; >>>>>> + }; >>>>>> + >>>>>> + qos_crypto: qos@10128080 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x10128080 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_gpu: qos@1012d000 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012d000 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_vpu: qos@1012e000 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012e000 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_rga: qos@1012f000 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012f000 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_ebc: qos@1012f080 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012f080 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_iep: qos@1012f100 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012f100 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_lcdc: qos@1012f180 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012f180 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_vip: qos@1012f200 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012f200 0x20>; >>>>>> }; >>>>>> >>>>>> gic: interrupt-controller@10139000 { >>>>>> >>>>> >>> >>> > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6581FC4167B for ; Mon, 4 Dec 2023 15:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1JOuF9D/3LmW8E55+ooL2W+OYvSf0Aw6D3Vjl8K5cq8=; b=sX6p0BB0OWT7my PylwIbrYhsFpPkBIL8X0I/jqQbYvq/bFC37oM0SAOXRFMWYaLXC514izsY5izW2GqPum/fQestay7 SQ/Y+ULJ6SbkefsN04kG3l+XKSld53Al1dRwxqQt+I4vd0PFyQNNdXJddYH/Ve6iOVAxmVqp9Y3tr Iu7DKX8RZdlIutFxlPMrXc6EOTJwet1cXR0b+4FVJA20TC7kHxi9siPlZdf6fASVUzFp1g3TJ3DJw Lz61JCeXfZqBQqg8fupoYQ/qLDQNDcSuLFJM9+z6GpICX8oF2U7HyBdoItBKuJmSZcNolWybMQcQY 9toYU/anDSujdm7W9O1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAAnG-004wWc-04; Mon, 04 Dec 2023 15:23:34 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAAnB-004wV9-2b; Mon, 04 Dec 2023 15:23:31 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-54c7744a93fso2853789a12.2; Mon, 04 Dec 2023 07:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701703408; x=1702308208; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mxYp/TPj2SDljkx7akhBocUojf/1bHbrDV2kmdKcuiw=; b=m3EW2CWQKrJVogtfvgs9BE7tNw8NXJ3iMHX2ncyZ6AhUmlFiLde8wjIQroEnmovyss m2U860sH+LyAVrzeZLLbXJOxMZjG5NuBa4yhY+PqFSq1C9avnR1CUwt0yvnazgKfZDvy e/XOQXFnd0vs58n0X83A2eh5fNtv5CKKtn3+U3yy74qgPAAuejDt+IcpXLyQIncz722G lvpi/5G6TRCXlFob8V5zitlJRuwCOpaMJknvrk9wYshfyT3XDtMgo+Mcv29L5vcoy1FC nUgSevNhCCHi0L+RTLwZd56w5FHTaenDkG9yZxTEJF0tHL6yuakP6uYGZQTpaUz5N0O9 ziEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701703408; x=1702308208; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mxYp/TPj2SDljkx7akhBocUojf/1bHbrDV2kmdKcuiw=; b=NsxkxLMBdqu9Bxa5QIkWXRjq8TGbRFAym9zUM/2AWR9FHQqgqe0bMNAQQuL4nOrlS1 ClPnwEAk2vtsq9AicM2AAyhM0pUyQvLUZ9T6HnuBaHkC/buj0k5+/hbTkA7J7BLxIBv+ 0pfoBpp37fbi0Urb2S0P+9Kp57TJ/8uSdHKpDBEPRVPjXNrG+D2V1vPhZIPM0DLNAk7f n3WXg85c5ZIAzU8M+A4Y6B3w90JG/DVlXOMoTPLCpKqrX+7x1Gsup62RYJg7829kVfWB 74d8om/UqD7E9EyE78dzOQuJ76wUfYLAjKEdNcFG7aTQummWNshVEwA77MRKHQpFW8oS i9Sg== X-Gm-Message-State: AOJu0YxiLxqQAWyQvH4pTRhpLwaFaaiUoVIjnJK7cgcm8O8Y01NvvkSK /+LnSl9ehgsX9F5yRyApDA== X-Google-Smtp-Source: AGHT+IH6NaMxB0hD8p+w4THyQqPHgLUhFhYRDIhCfbDi49ieB3DqkYaAbCCN/8DRLm52i+pnC1Tesg== X-Received: by 2002:a17:907:2daa:b0:a19:a1ba:8cc2 with SMTP id gt42-20020a1709072daa00b00a19a1ba8cc2mr3994784ejc.96.1701703407956; Mon, 04 Dec 2023 07:23:27 -0800 (PST) Received: from ?IPV6:2a02:810b:f40:4300:55ff:210b:5393:c9d7? ([2a02:810b:f40:4300:55ff:210b:5393:c9d7]) by smtp.gmail.com with ESMTPSA id s7-20020a170906bc4700b00a0f78db91c3sm5416316ejv.95.2023.12.04.07.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Dec 2023 07:23:27 -0800 (PST) Message-ID: Date: Mon, 4 Dec 2023 16:23:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] ARM: dts: rockchip: Add power-controller for RK3128 To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Daniel Vetter , David Airlie , Thomas Zimmermann , Maxime Ripard , Maarten Lankhorst , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org References: <20231202125144.66052-1-knaerzche@gmail.com> <4891026.6YUMPnJmAY@diego> <4dec2316-f840-44ab-a07a-3d7f0e5e6d8f@gmail.com> <9588573.jRhZ6ZUK3Y@diego> Content-Language: en-US From: Alex Bee In-Reply-To: <9588573.jRhZ6ZUK3Y@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_072329_947102_72AB3BA5 X-CRM114-Status: GOOD ( 28.56 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgSGVpa28sCgpBbSAwMy4xMi4yMyB1bSAxNzo0MiBzY2hyaWViIEhlaWtvIFN0w7xibmVyOgo+ IEhpIEFsZXgsCj4KPiBBbSBTb25udGFnLCAzLiBEZXplbWJlciAyMDIzLCAxNzowNTo0NyBDRVQg c2NocmllYiBBbGV4IEJlZToKPj4gQW0gMDIuMTIuMjMgdW0gMTg6NDYgc2NocmllYiBIZWlrbyBT dMO8Ym5lcjoKPj4+IEFtIFNhbXN0YWcsIDIuIERlemVtYmVyIDIwMjMsIDE3OjM2OjE1IENFVCBz Y2hyaWViIEFsZXggQmVlOgo+Pj4+IEFtIDAyLjEyLjIzIHVtIDE2OjUxIHNjaHJpZWIgSGVpa28g U3TDvGJuZXI6Cj4+Pj4+IEFtIFNhbXN0YWcsIDIuIERlemVtYmVyIDIwMjMsIDEzOjUxOjQxIENF VCBzY2hyaWViIEFsZXggQmVlOgo+Pj4+Pj4gQWRkIHBvd2VyIGNvbnRyb2xsZXIgYW5kIHFvcyBu b2RlcyBmb3IgUkszMTI4IGluIG9yZGVyIHRvIHVzZQo+Pj4+Pj4gdGhlbSBhcyBwb3dlcmRvbWFp bnMuCj4+Pj4+IGRvZXMgdGhlIHBvd2VyLWRvbWFpbiBjb250cm9sbGVyIHdvcmsgd2l0aCB0aGUg aW5jb21wbGV0ZSBzZXQgb2YKPj4+Pj4gcG0tZG9tYWlucyB0b28/Cj4+Pj4gWWVzLCBpdCBkb2Vz IC0gdGhlIG1pc3NpbmcgZG9tYWlucyBjYW4gcmVxdWVzdCBpZGxlIG9ubHkgYW5kIGNhbid0IGJl Cj4+Pj4gcG93ZXJlZCBvbi9vZmYgLSBpZiBubyBvbmUgcmVxdWVzdHMgaWRsZSB0aGV5IGFyZSBq dXN0IHVwIGFsbCB0aGUgdGltZS4KPj4+Pgo+Pj4+PiBXaGF0IEkgaGF2ZSBpbiBtaW5kIGlzCj4+ Pj4+IC0gYWRkaW5nIHRoZSBwb3dlci1jb250cm9sbGVyIG5vZGUgd2l0aCB0aGUgZXhpc3Rpbmcg c2V0IG9mIHBvd2VyLWRvbWFpbnMKPj4+Pj4gLSB0aGUgZ3B1IHBtLWRvbWFpbiBpcyBpbiB0aGVy ZQo+Pj4+PiAtIGFkZGluZyB0aGUgZ3B1IHBhcnRzCj4+Pj4gTXkgbWFpbiBjb25jZXJuIGFib3V0 IGFkZGluZyB0aGVtIGxhdGVyIHdhcyB0aGUgY2hhbmdlIG9mIHRoZSBBQkkgYWZ0ZXIKPj4+PiB0 aGV5J3ZlIGJlZW4gZXhwb3NlZCBpbiB0aGUgU29DIERULiBJZiB0aGF0J3Mgbm90IGFuIGlzc3Vl IC0gc3VyZTogSSBjYW4KPj4+PiBhZGQgdGhlbSBpbiBhIHNlcGFyYXRlIHNlcmllcy4KPj4+IEFu IEFCSSBjaGFuZ2Ugd291bGQgYmUgX2NoYW5naW5nXyB0aGUgZG9tYWluLWlkcyBpbiB0aGUgcmsz MTI4LXBvd2VyLmgKPj4+IEkgdGhpbmsgOi0pIC4KPj4gV2VsbCwgYW4gYWRkaXRpb24gaXMgc3Rp bGwgYSBjaGFuZ2UuCj4+PiBSaWdodCBub3cgdGhlIGV4aXN0aW5nIGRvbWFpbiBpZHMgaW4gdGhl IGhlYWRlciBhcmUgYWxyZWFkeSBleHBvc2VkIHRvIHRoZQo+Pj4gd29ybGQsIHNvIHNvbWVvbmUg Y291bGQgYWxyZWFkeSB1c2UgdGhlbSwgYnV0IG5vdCB0aGUgbmV3IG9uZXMuCj4+IEknbSBmdWxs eSBhd2FyZSB0aGF0IG5vdGhpbmcgd291bGQgZXZlciBoYXJkIGZhaWwgYW55d2hlcmUgaWYgdGhl IG5ldwo+PiBkb21haW4gaWRzIGdldCBhZGRlZCBsYXRlci4KPj4KPj4gTmV2ZXJ0aGVsZXNzIHdl IHN0YXJ0IHVzaW5nIGhlcmUgYW4gQUJJIHdoaWNoIGlzIGtub3duIHRvIGJlIGluY29tcGxldGUu Cj4+IEZvciBubyByZWFzb24sIGFzIHRoZSBwYXRjaGVzICh3aGljaCBJIGFtIG5vdyBhc2tlZCB0 byByZW1vdmUgZnJvbSB0aGlzCj4+IHNlcmllcykgZm9yIGNvbXBsZXRpb24gYXJlIGFscmVhZHkg dGhlcmUgKGhlcmUpLgo+Pgo+PiBBbnl3YXksIGlmIHlvdSBwcmVmZXIgaXQgdGhpcyB3YXk6IEkn bSBwbGVhc2VkIHRvIGRvIHNvLgo+IEkgd2FzIG1vcmUgdGhpbmtpbmcgb2YgYWNjZWxlcmF0aW5n IHRoZSBncHUtcGFydCBvZiB0aGUgc2VyaWVzLCBhcyB0aGF0Cj4gcmVhbGx5IGlzIGp1c3Qgd2Fp dGluZyBmb3IgdGhlIHBvd2VyLWRvbWFpbiBub2RlIHRoYXQgYWxyZWFkeSBoYXMgZHJpdmVyCj4g c3VwcG9ydCBhbmQgZG9tYWluLWlkcyBwcmVzZW50Lgo+Cj4gSXQgbG9va3MgbGlrZSB5b3UncmUg ZmVlbGluZyBtb3JlIHN0cm9uZ2x5IGFib3V0IHRoYXQgdGhvdWdoLCBzbyBJJ2xsCj4gZGVmaW5p dGx5IG5vdCBwcmVzc3VyZSB5b3UgOy0pIC4KCkknbSByZWFsbHkgbm90IGluc2lzdGluZyBvbiB0 aGlzIC0gSSBqdXN0IGRpZG4ndCB1bmRlcnN0YW5kIHdoeSB5b3UgCndvdWxkIHdhbnQgdGhpcy4g QW5kIGhvbmVzdGx5IEkgaGF2ZW4ndCBjb25zaWRlcmVkIG1lcmdpbmcgdGltZWxpbmUgYXMgCmFu IGFyZ3VtZW50LgoKU28gc3VyZTogTGV0J3MgZ2V0IHRoZSBsb3cgaGFuZ2luZyBmcnVpdHMgbWVy Z2VkIGZvciA2LjguIEhhdmluZyB0aGUgCnBvd2VyIGRvbWFpbnMgaW4gdGhlIERUIHdpbGwgYWxz byBoZWxwIGZvciBteSB1cGNvbWluZyBoZG1pIC8gdm9wIHNlcmllcy4KCkFsZXgKCj4KPiBCdXQg SSBndWVzcyB0aGUgc3BsaXQgaW50byBJRHMgYW5kIGRyaXZlciBjaGFuZ2Ugc2hvdWxkIHN0aWxs IGJlCj4gZG9uZSwgZXNwZWNpYWxseSBhcyB0aGUgZHQtYmluZGluZy1oZWFkZXIgbGlrZWx5IHdp bGwgd2FudCBhbiBBY2sKPiBmcm9tIHRoZSBEVCBtYWludGFpbmVycy4KPgo+IEFuZCB0aGUgcG93 ZXItZG9tYWluIGNoYW5nZSB3aWxsIGdvIHRocm91Z2ggdGhlIG5ldyBwbWRvbWFpbgo+IHN1YnN5 c3RlbS4KPgo+Cj4gSGVpa28KPgo+Cj4+Pj4+IEFuZCBhIHNlY29uZCBzZXJpZXMgd2l0aAo+Pj4+ PiAtIHBhdGNoMSBmcm9tIGhlcmUKPj4+Pj4gLSBhIGR0cyBwYXRjaCBhZGRpbmcgdGhlIGFkZGl0 aW9uYWwgcG0tZG9tYWlucyB0byByazMxMjguZHRzaQo+Pj4+PiAtIEkgZ3Vlc3MgcGF0Y2gxIGFs c28gc2hvdWxkIGJlIHNwbGl0IGludG8gYSBwYXRjaCBhZGRpbmcgdGhlIGJpbmRpbmctaWRzCj4+ Pj4+ICAgICAgYW5kIGEgc2VwYXJhdGUgcGF0Y2ggZm9yIHRoZSBjb2RlIGFkZGl0aW9uLgo+Pj4+ IFllYWgsIEkgbm90aWNlZCB0aGlzIGFsc28gOikKPj4+Pgo+Pj4+IFJlZ2FyZHMsCj4+Pj4KPj4+ PiBBbGV4Cj4+Pj4KPj4+Pj4gSGVpa28KPj4+Pj4KPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEFsZXgg QmVlIDxrbmFlcnpjaGVAZ21haWwuY29tPgo+Pj4+Pj4gLS0tCj4+Pj4+PiAgICAgYXJjaC9hcm0v Ym9vdC9kdHMvcm9ja2NoaXAvcmszMTI4LmR0c2kgfCAxMDEgKysrKysrKysrKysrKysrKysrKysr KysrKwo+Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCAxMDEgaW5zZXJ0aW9ucygrKQo+Pj4+Pj4K Pj4+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9yb2NrY2hpcC9yazMxMjguZHRz aSBiL2FyY2gvYXJtL2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzEyOC5kdHNpCj4+Pj4+PiBpbmRleCA0 ZThiMzg2MDRlY2QuLmI3MjkwNWRiMDRmNyAxMDA2NDQKPj4+Pj4+IC0tLSBhL2FyY2gvYXJtL2Jv b3QvZHRzL3JvY2tjaGlwL3JrMzEyOC5kdHNpCj4+Pj4+PiArKysgYi9hcmNoL2FybS9ib290L2R0 cy9yb2NrY2hpcC9yazMxMjguZHRzaQo+Pj4+Pj4gQEAgLTgsNiArOCw3IEBACj4+Pj4+PiAgICAg I2luY2x1ZGUgPGR0LWJpbmRpbmdzL2ludGVycnVwdC1jb250cm9sbGVyL2FybS1naWMuaD4KPj4+ Pj4+ICAgICAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvaXJxLmg+ Cj4+Pj4+PiAgICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL3BpbmN0cmwvcm9ja2NoaXAuaD4KPj4+ Pj4+ICsjaW5jbHVkZSA8ZHQtYmluZGluZ3MvcG93ZXIvcmszMTI4LXBvd2VyLmg+Cj4+Pj4+PiAg ICAgCj4+Pj4+PiAgICAgLyB7Cj4+Pj4+PiAgICAgCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmsz MTI4IjsKPj4+Pj4+IEBAIC0xMzMsNiArMTM0LDEwNiBAQCBzbXAtc3JhbUAwIHsKPj4+Pj4+ICAg ICAJcG11OiBzeXNjb25AMTAwYTAwMDAgewo+Pj4+Pj4gICAgIAkJY29tcGF0aWJsZSA9ICJyb2Nr Y2hpcCxyazMxMjgtcG11IiwgInN5c2NvbiIsICJzaW1wbGUtbWZkIjsKPj4+Pj4+ICAgICAJCXJl ZyA9IDwweDEwMGEwMDAwIDB4MTAwMD47Cj4+Pj4+PiArCj4+Pj4+PiArCQlwb3dlcjogcG93ZXIt Y29udHJvbGxlciB7Cj4+Pj4+PiArCQkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMxMjgtcG93 ZXItY29udHJvbGxlciI7Cj4+Pj4+PiArCQkJI3Bvd2VyLWRvbWFpbi1jZWxscyA9IDwxPjsKPj4+ Pj4+ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPj4+Pj4+ICsJCQkjc2l6ZS1jZWxscyA9IDww PjsKPj4+Pj4+ICsKPj4+Pj4+ICsJCQlwb3dlci1kb21haW5AUkszMTI4X1BEX1ZJTyB7Cj4+Pj4+ PiArCQkJCXJlZyA9IDxSSzMxMjhfUERfVklPPjsKPj4+Pj4+ICsJCQkJY2xvY2tzID0gPCZjcnUg QUNMS19DSUY+LAo+Pj4+Pj4gKwkJCQkJIDwmY3J1IEhDTEtfQ0lGPiwKPj4+Pj4+ICsJCQkJCSA8 JmNydSBEQ0xLX0VCQz4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgSENMS19FQkM+LAo+Pj4+Pj4gKwkJ CQkJIDwmY3J1IEFDTEtfSUVQPiwKPj4+Pj4+ICsJCQkJCSA8JmNydSBIQ0xLX0lFUD4sCj4+Pj4+ PiArCQkJCQkgPCZjcnUgQUNMS19MQ0RDMD4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgSENMS19MQ0RD MD4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgUENMS19NSVBJPiwKPj4+Pj4+ICsJCQkJCSA8JmNydSBB Q0xLX1JHQT4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgSENMS19SR0E+LAo+Pj4+Pj4gKwkJCQkJIDwm Y3J1IEFDTEtfVklPMD4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgQUNMS19WSU8xPiwKPj4+Pj4+ICsJ CQkJCSA8JmNydSBIQ0xLX1ZJTz4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgSENMS19WSU9fSDJQPiwK Pj4+Pj4+ICsJCQkJCSA8JmNydSBEQ0xLX1ZPUD4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgU0NMS19W T1A+Owo+Pj4+Pj4gKwkJCQlwbV9xb3MgPSA8JnFvc19lYmM+LAo+Pj4+Pj4gKwkJCQkJIDwmcW9z X2llcD4sCj4+Pj4+PiArCQkJCQkgPCZxb3NfbGNkYz4sCj4+Pj4+PiArCQkJCQkgPCZxb3Nfcmdh PiwKPj4+Pj4+ICsJCQkJCSA8JnFvc192aXA+Owo+Pj4+Pj4gKwkJCQkjcG93ZXItZG9tYWluLWNl bGxzID0gPDA+Owo+Pj4+Pj4gKwkJCX07Cj4+Pj4+PiArCj4+Pj4+PiArCQkJcG93ZXItZG9tYWlu QFJLMzEyOF9QRF9WSURFTyB7Cj4+Pj4+PiArCQkJCXJlZyA9IDxSSzMxMjhfUERfVklERU8+Owo+ Pj4+Pj4gKwkJCQljbG9ja3MgPSA8JmNydSBBQ0xLX1ZEUFU+LAo+Pj4+Pj4gKwkJCQkJIDwmY3J1 IEhDTEtfVkRQVT4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgQUNMS19WRVBVPiwKPj4+Pj4+ICsJCQkJ CSA8JmNydSBIQ0xLX1ZFUFU+LAo+Pj4+Pj4gKwkJCQkJIDwmY3J1IFNDTEtfSEVWQ19DT1JFPjsK Pj4+Pj4+ICsJCQkJcG1fcW9zID0gPCZxb3NfdnB1PjsKPj4+Pj4+ICsJCQkJI3Bvd2VyLWRvbWFp bi1jZWxscyA9IDwwPjsKPj4+Pj4+ICsJCQl9Owo+Pj4+Pj4gKwo+Pj4+Pj4gKwkJCXBvd2VyLWRv bWFpbkBSSzMxMjhfUERfR1BVIHsKPj4+Pj4+ICsJCQkJcmVnID0gPFJLMzEyOF9QRF9HUFU+Owo+ Pj4+Pj4gKwkJCQljbG9ja3MgPSA8JmNydSBBQ0xLX0dQVT47Cj4+Pj4+PiArCQkJCXBtX3FvcyA9 IDwmcW9zX2dwdT47Cj4+Pj4+PiArCQkJCSNwb3dlci1kb21haW4tY2VsbHMgPSA8MD47Cj4+Pj4+ PiArCQkJfTsKPj4+Pj4+ICsKPj4+Pj4+ICsJCQlwb3dlci1kb21haW5AUkszMTI4X1BEX0NSWVBU TyB7Cj4+Pj4+PiArCQkJCXJlZyA9IDxSSzMxMjhfUERfQ1JZUFRPPjsKPj4+Pj4+ICsJCQkJY2xv Y2tzID0gPCZjcnUgSENMS19DUllQVE8+LAo+Pj4+Pj4gKwkJCQkJIDwmY3J1IFNDTEtfQ1JZUFRP PjsKPj4+Pj4+ICsJCQkJcG1fcW9zID0gPCZxb3NfY3J5cHRvPjsKPj4+Pj4+ICsJCQkJI3Bvd2Vy LWRvbWFpbi1jZWxscyA9IDwwPjsKPj4+Pj4+ICsJCQl9Owo+Pj4+Pj4gKwkJfTsKPj4+Pj4+ICsJ fTsKPj4+Pj4+ICsKPj4+Pj4+ICsJcW9zX2NyeXB0bzogcW9zQDEwMTI4MDgwIHsKPj4+Pj4+ICsJ CWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMTI4LXFvcyIsICJzeXNjb24iOwo+Pj4+Pj4gKwkJ cmVnID0gPDB4MTAxMjgwODAgMHgyMD47Cj4+Pj4+PiArCX07Cj4+Pj4+PiArCj4+Pj4+PiArCXFv c19ncHU6IHFvc0AxMDEyZDAwMCB7Cj4+Pj4+PiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJr MzEyOC1xb3MiLCAic3lzY29uIjsKPj4+Pj4+ICsJCXJlZyA9IDwweDEwMTJkMDAwIDB4MjA+Owo+ Pj4+Pj4gKwl9Owo+Pj4+Pj4gKwo+Pj4+Pj4gKwlxb3NfdnB1OiBxb3NAMTAxMmUwMDAgewo+Pj4+ Pj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMxMjgtcW9zIiwgInN5c2NvbiI7Cj4+Pj4+ PiArCQlyZWcgPSA8MHgxMDEyZTAwMCAweDIwPjsKPj4+Pj4+ICsJfTsKPj4+Pj4+ICsKPj4+Pj4+ ICsJcW9zX3JnYTogcW9zQDEwMTJmMDAwIHsKPj4+Pj4+ICsJCWNvbXBhdGlibGUgPSAicm9ja2No aXAscmszMTI4LXFvcyIsICJzeXNjb24iOwo+Pj4+Pj4gKwkJcmVnID0gPDB4MTAxMmYwMDAgMHgy MD47Cj4+Pj4+PiArCX07Cj4+Pj4+PiArCj4+Pj4+PiArCXFvc19lYmM6IHFvc0AxMDEyZjA4MCB7 Cj4+Pj4+PiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzEyOC1xb3MiLCAic3lzY29uIjsK Pj4+Pj4+ICsJCXJlZyA9IDwweDEwMTJmMDgwIDB4MjA+Owo+Pj4+Pj4gKwl9Owo+Pj4+Pj4gKwo+ Pj4+Pj4gKwlxb3NfaWVwOiBxb3NAMTAxMmYxMDAgewo+Pj4+Pj4gKwkJY29tcGF0aWJsZSA9ICJy b2NrY2hpcCxyazMxMjgtcW9zIiwgInN5c2NvbiI7Cj4+Pj4+PiArCQlyZWcgPSA8MHgxMDEyZjEw MCAweDIwPjsKPj4+Pj4+ICsJfTsKPj4+Pj4+ICsKPj4+Pj4+ICsJcW9zX2xjZGM6IHFvc0AxMDEy ZjE4MCB7Cj4+Pj4+PiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzEyOC1xb3MiLCAic3lz Y29uIjsKPj4+Pj4+ICsJCXJlZyA9IDwweDEwMTJmMTgwIDB4MjA+Owo+Pj4+Pj4gKwl9Owo+Pj4+ Pj4gKwo+Pj4+Pj4gKwlxb3NfdmlwOiBxb3NAMTAxMmYyMDAgewo+Pj4+Pj4gKwkJY29tcGF0aWJs ZSA9ICJyb2NrY2hpcCxyazMxMjgtcW9zIiwgInN5c2NvbiI7Cj4+Pj4+PiArCQlyZWcgPSA8MHgx MDEyZjIwMCAweDIwPjsKPj4+Pj4+ICAgICAJfTsKPj4+Pj4+ICAgICAKPj4+Pj4+ICAgICAJZ2lj OiBpbnRlcnJ1cHQtY29udHJvbGxlckAxMDEzOTAwMCB7Cj4+Pj4+Pgo+Pj4+Pgo+Pj4KPj4+Cj4K Pgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tj aGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E07BC4167B for ; Mon, 4 Dec 2023 15:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7CWoi51+rQ+D2xlK0OMp/x/SBtQh9Tgm12pw/OKoiYY=; b=m955R7BpqM5See FvFR0e0LE8/SZB9XznwLa8d4uIWjoe+F9ZwpWozYRuu6p1o5KIvBwL+/kLMIrsgrFNoAsQEYmWmKK OQYd7jsfjjD8028032K7ugcqA7EUMGTIXiFpTLgx5bQFVP99XG321jtda4SwrEttBJyzLsNgu6lYp I3ZVp1wz1EKYyn55py67ahJc0o1YdqTrxSKwBovmZgUny2Rzh9nFUg/FmWSgoS4F3213hFdYJFAPa yXXnhxH+IpKCE6zfs4bJYp7ukli9CaTERwnth0IpdQBKirh4/H+e4cFl9ftiz8APdJkv7ohrmcZCG NVlz0V5dAvriaN12645w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAAnF-004wWR-0K; Mon, 04 Dec 2023 15:23:33 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAAnB-004wV9-2b; Mon, 04 Dec 2023 15:23:31 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-54c7744a93fso2853789a12.2; Mon, 04 Dec 2023 07:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701703408; x=1702308208; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mxYp/TPj2SDljkx7akhBocUojf/1bHbrDV2kmdKcuiw=; b=m3EW2CWQKrJVogtfvgs9BE7tNw8NXJ3iMHX2ncyZ6AhUmlFiLde8wjIQroEnmovyss m2U860sH+LyAVrzeZLLbXJOxMZjG5NuBa4yhY+PqFSq1C9avnR1CUwt0yvnazgKfZDvy e/XOQXFnd0vs58n0X83A2eh5fNtv5CKKtn3+U3yy74qgPAAuejDt+IcpXLyQIncz722G lvpi/5G6TRCXlFob8V5zitlJRuwCOpaMJknvrk9wYshfyT3XDtMgo+Mcv29L5vcoy1FC nUgSevNhCCHi0L+RTLwZd56w5FHTaenDkG9yZxTEJF0tHL6yuakP6uYGZQTpaUz5N0O9 ziEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701703408; x=1702308208; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mxYp/TPj2SDljkx7akhBocUojf/1bHbrDV2kmdKcuiw=; b=NsxkxLMBdqu9Bxa5QIkWXRjq8TGbRFAym9zUM/2AWR9FHQqgqe0bMNAQQuL4nOrlS1 ClPnwEAk2vtsq9AicM2AAyhM0pUyQvLUZ9T6HnuBaHkC/buj0k5+/hbTkA7J7BLxIBv+ 0pfoBpp37fbi0Urb2S0P+9Kp57TJ/8uSdHKpDBEPRVPjXNrG+D2V1vPhZIPM0DLNAk7f n3WXg85c5ZIAzU8M+A4Y6B3w90JG/DVlXOMoTPLCpKqrX+7x1Gsup62RYJg7829kVfWB 74d8om/UqD7E9EyE78dzOQuJ76wUfYLAjKEdNcFG7aTQummWNshVEwA77MRKHQpFW8oS i9Sg== X-Gm-Message-State: AOJu0YxiLxqQAWyQvH4pTRhpLwaFaaiUoVIjnJK7cgcm8O8Y01NvvkSK /+LnSl9ehgsX9F5yRyApDA== X-Google-Smtp-Source: AGHT+IH6NaMxB0hD8p+w4THyQqPHgLUhFhYRDIhCfbDi49ieB3DqkYaAbCCN/8DRLm52i+pnC1Tesg== X-Received: by 2002:a17:907:2daa:b0:a19:a1ba:8cc2 with SMTP id gt42-20020a1709072daa00b00a19a1ba8cc2mr3994784ejc.96.1701703407956; Mon, 04 Dec 2023 07:23:27 -0800 (PST) Received: from ?IPV6:2a02:810b:f40:4300:55ff:210b:5393:c9d7? ([2a02:810b:f40:4300:55ff:210b:5393:c9d7]) by smtp.gmail.com with ESMTPSA id s7-20020a170906bc4700b00a0f78db91c3sm5416316ejv.95.2023.12.04.07.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Dec 2023 07:23:27 -0800 (PST) Message-ID: Date: Mon, 4 Dec 2023 16:23:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] ARM: dts: rockchip: Add power-controller for RK3128 To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Daniel Vetter , David Airlie , Thomas Zimmermann , Maxime Ripard , Maarten Lankhorst , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org References: <20231202125144.66052-1-knaerzche@gmail.com> <4891026.6YUMPnJmAY@diego> <4dec2316-f840-44ab-a07a-3d7f0e5e6d8f@gmail.com> <9588573.jRhZ6ZUK3Y@diego> Content-Language: en-US From: Alex Bee In-Reply-To: <9588573.jRhZ6ZUK3Y@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_072329_947102_72AB3BA5 X-CRM114-Status: GOOD ( 28.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSGVpa28sCgpBbSAwMy4xMi4yMyB1bSAxNzo0MiBzY2hyaWViIEhlaWtvIFN0w7xibmVyOgo+ IEhpIEFsZXgsCj4KPiBBbSBTb25udGFnLCAzLiBEZXplbWJlciAyMDIzLCAxNzowNTo0NyBDRVQg c2NocmllYiBBbGV4IEJlZToKPj4gQW0gMDIuMTIuMjMgdW0gMTg6NDYgc2NocmllYiBIZWlrbyBT dMO8Ym5lcjoKPj4+IEFtIFNhbXN0YWcsIDIuIERlemVtYmVyIDIwMjMsIDE3OjM2OjE1IENFVCBz Y2hyaWViIEFsZXggQmVlOgo+Pj4+IEFtIDAyLjEyLjIzIHVtIDE2OjUxIHNjaHJpZWIgSGVpa28g U3TDvGJuZXI6Cj4+Pj4+IEFtIFNhbXN0YWcsIDIuIERlemVtYmVyIDIwMjMsIDEzOjUxOjQxIENF VCBzY2hyaWViIEFsZXggQmVlOgo+Pj4+Pj4gQWRkIHBvd2VyIGNvbnRyb2xsZXIgYW5kIHFvcyBu b2RlcyBmb3IgUkszMTI4IGluIG9yZGVyIHRvIHVzZQo+Pj4+Pj4gdGhlbSBhcyBwb3dlcmRvbWFp bnMuCj4+Pj4+IGRvZXMgdGhlIHBvd2VyLWRvbWFpbiBjb250cm9sbGVyIHdvcmsgd2l0aCB0aGUg aW5jb21wbGV0ZSBzZXQgb2YKPj4+Pj4gcG0tZG9tYWlucyB0b28/Cj4+Pj4gWWVzLCBpdCBkb2Vz IC0gdGhlIG1pc3NpbmcgZG9tYWlucyBjYW4gcmVxdWVzdCBpZGxlIG9ubHkgYW5kIGNhbid0IGJl Cj4+Pj4gcG93ZXJlZCBvbi9vZmYgLSBpZiBubyBvbmUgcmVxdWVzdHMgaWRsZSB0aGV5IGFyZSBq dXN0IHVwIGFsbCB0aGUgdGltZS4KPj4+Pgo+Pj4+PiBXaGF0IEkgaGF2ZSBpbiBtaW5kIGlzCj4+ Pj4+IC0gYWRkaW5nIHRoZSBwb3dlci1jb250cm9sbGVyIG5vZGUgd2l0aCB0aGUgZXhpc3Rpbmcg c2V0IG9mIHBvd2VyLWRvbWFpbnMKPj4+Pj4gLSB0aGUgZ3B1IHBtLWRvbWFpbiBpcyBpbiB0aGVy ZQo+Pj4+PiAtIGFkZGluZyB0aGUgZ3B1IHBhcnRzCj4+Pj4gTXkgbWFpbiBjb25jZXJuIGFib3V0 IGFkZGluZyB0aGVtIGxhdGVyIHdhcyB0aGUgY2hhbmdlIG9mIHRoZSBBQkkgYWZ0ZXIKPj4+PiB0 aGV5J3ZlIGJlZW4gZXhwb3NlZCBpbiB0aGUgU29DIERULiBJZiB0aGF0J3Mgbm90IGFuIGlzc3Vl IC0gc3VyZTogSSBjYW4KPj4+PiBhZGQgdGhlbSBpbiBhIHNlcGFyYXRlIHNlcmllcy4KPj4+IEFu IEFCSSBjaGFuZ2Ugd291bGQgYmUgX2NoYW5naW5nXyB0aGUgZG9tYWluLWlkcyBpbiB0aGUgcmsz MTI4LXBvd2VyLmgKPj4+IEkgdGhpbmsgOi0pIC4KPj4gV2VsbCwgYW4gYWRkaXRpb24gaXMgc3Rp bGwgYSBjaGFuZ2UuCj4+PiBSaWdodCBub3cgdGhlIGV4aXN0aW5nIGRvbWFpbiBpZHMgaW4gdGhl IGhlYWRlciBhcmUgYWxyZWFkeSBleHBvc2VkIHRvIHRoZQo+Pj4gd29ybGQsIHNvIHNvbWVvbmUg Y291bGQgYWxyZWFkeSB1c2UgdGhlbSwgYnV0IG5vdCB0aGUgbmV3IG9uZXMuCj4+IEknbSBmdWxs eSBhd2FyZSB0aGF0IG5vdGhpbmcgd291bGQgZXZlciBoYXJkIGZhaWwgYW55d2hlcmUgaWYgdGhl IG5ldwo+PiBkb21haW4gaWRzIGdldCBhZGRlZCBsYXRlci4KPj4KPj4gTmV2ZXJ0aGVsZXNzIHdl IHN0YXJ0IHVzaW5nIGhlcmUgYW4gQUJJIHdoaWNoIGlzIGtub3duIHRvIGJlIGluY29tcGxldGUu Cj4+IEZvciBubyByZWFzb24sIGFzIHRoZSBwYXRjaGVzICh3aGljaCBJIGFtIG5vdyBhc2tlZCB0 byByZW1vdmUgZnJvbSB0aGlzCj4+IHNlcmllcykgZm9yIGNvbXBsZXRpb24gYXJlIGFscmVhZHkg dGhlcmUgKGhlcmUpLgo+Pgo+PiBBbnl3YXksIGlmIHlvdSBwcmVmZXIgaXQgdGhpcyB3YXk6IEkn bSBwbGVhc2VkIHRvIGRvIHNvLgo+IEkgd2FzIG1vcmUgdGhpbmtpbmcgb2YgYWNjZWxlcmF0aW5n IHRoZSBncHUtcGFydCBvZiB0aGUgc2VyaWVzLCBhcyB0aGF0Cj4gcmVhbGx5IGlzIGp1c3Qgd2Fp dGluZyBmb3IgdGhlIHBvd2VyLWRvbWFpbiBub2RlIHRoYXQgYWxyZWFkeSBoYXMgZHJpdmVyCj4g c3VwcG9ydCBhbmQgZG9tYWluLWlkcyBwcmVzZW50Lgo+Cj4gSXQgbG9va3MgbGlrZSB5b3UncmUg ZmVlbGluZyBtb3JlIHN0cm9uZ2x5IGFib3V0IHRoYXQgdGhvdWdoLCBzbyBJJ2xsCj4gZGVmaW5p dGx5IG5vdCBwcmVzc3VyZSB5b3UgOy0pIC4KCkknbSByZWFsbHkgbm90IGluc2lzdGluZyBvbiB0 aGlzIC0gSSBqdXN0IGRpZG4ndCB1bmRlcnN0YW5kIHdoeSB5b3UgCndvdWxkIHdhbnQgdGhpcy4g QW5kIGhvbmVzdGx5IEkgaGF2ZW4ndCBjb25zaWRlcmVkIG1lcmdpbmcgdGltZWxpbmUgYXMgCmFu IGFyZ3VtZW50LgoKU28gc3VyZTogTGV0J3MgZ2V0IHRoZSBsb3cgaGFuZ2luZyBmcnVpdHMgbWVy Z2VkIGZvciA2LjguIEhhdmluZyB0aGUgCnBvd2VyIGRvbWFpbnMgaW4gdGhlIERUIHdpbGwgYWxz byBoZWxwIGZvciBteSB1cGNvbWluZyBoZG1pIC8gdm9wIHNlcmllcy4KCkFsZXgKCj4KPiBCdXQg SSBndWVzcyB0aGUgc3BsaXQgaW50byBJRHMgYW5kIGRyaXZlciBjaGFuZ2Ugc2hvdWxkIHN0aWxs IGJlCj4gZG9uZSwgZXNwZWNpYWxseSBhcyB0aGUgZHQtYmluZGluZy1oZWFkZXIgbGlrZWx5IHdp bGwgd2FudCBhbiBBY2sKPiBmcm9tIHRoZSBEVCBtYWludGFpbmVycy4KPgo+IEFuZCB0aGUgcG93 ZXItZG9tYWluIGNoYW5nZSB3aWxsIGdvIHRocm91Z2ggdGhlIG5ldyBwbWRvbWFpbgo+IHN1YnN5 c3RlbS4KPgo+Cj4gSGVpa28KPgo+Cj4+Pj4+IEFuZCBhIHNlY29uZCBzZXJpZXMgd2l0aAo+Pj4+ PiAtIHBhdGNoMSBmcm9tIGhlcmUKPj4+Pj4gLSBhIGR0cyBwYXRjaCBhZGRpbmcgdGhlIGFkZGl0 aW9uYWwgcG0tZG9tYWlucyB0byByazMxMjguZHRzaQo+Pj4+PiAtIEkgZ3Vlc3MgcGF0Y2gxIGFs c28gc2hvdWxkIGJlIHNwbGl0IGludG8gYSBwYXRjaCBhZGRpbmcgdGhlIGJpbmRpbmctaWRzCj4+ Pj4+ICAgICAgYW5kIGEgc2VwYXJhdGUgcGF0Y2ggZm9yIHRoZSBjb2RlIGFkZGl0aW9uLgo+Pj4+ IFllYWgsIEkgbm90aWNlZCB0aGlzIGFsc28gOikKPj4+Pgo+Pj4+IFJlZ2FyZHMsCj4+Pj4KPj4+ PiBBbGV4Cj4+Pj4KPj4+Pj4gSGVpa28KPj4+Pj4KPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEFsZXgg QmVlIDxrbmFlcnpjaGVAZ21haWwuY29tPgo+Pj4+Pj4gLS0tCj4+Pj4+PiAgICAgYXJjaC9hcm0v Ym9vdC9kdHMvcm9ja2NoaXAvcmszMTI4LmR0c2kgfCAxMDEgKysrKysrKysrKysrKysrKysrKysr KysrKwo+Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCAxMDEgaW5zZXJ0aW9ucygrKQo+Pj4+Pj4K Pj4+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9yb2NrY2hpcC9yazMxMjguZHRz aSBiL2FyY2gvYXJtL2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzEyOC5kdHNpCj4+Pj4+PiBpbmRleCA0 ZThiMzg2MDRlY2QuLmI3MjkwNWRiMDRmNyAxMDA2NDQKPj4+Pj4+IC0tLSBhL2FyY2gvYXJtL2Jv b3QvZHRzL3JvY2tjaGlwL3JrMzEyOC5kdHNpCj4+Pj4+PiArKysgYi9hcmNoL2FybS9ib290L2R0 cy9yb2NrY2hpcC9yazMxMjguZHRzaQo+Pj4+Pj4gQEAgLTgsNiArOCw3IEBACj4+Pj4+PiAgICAg I2luY2x1ZGUgPGR0LWJpbmRpbmdzL2ludGVycnVwdC1jb250cm9sbGVyL2FybS1naWMuaD4KPj4+ Pj4+ICAgICAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvaXJxLmg+ Cj4+Pj4+PiAgICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL3BpbmN0cmwvcm9ja2NoaXAuaD4KPj4+ Pj4+ICsjaW5jbHVkZSA8ZHQtYmluZGluZ3MvcG93ZXIvcmszMTI4LXBvd2VyLmg+Cj4+Pj4+PiAg ICAgCj4+Pj4+PiAgICAgLyB7Cj4+Pj4+PiAgICAgCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmsz MTI4IjsKPj4+Pj4+IEBAIC0xMzMsNiArMTM0LDEwNiBAQCBzbXAtc3JhbUAwIHsKPj4+Pj4+ICAg ICAJcG11OiBzeXNjb25AMTAwYTAwMDAgewo+Pj4+Pj4gICAgIAkJY29tcGF0aWJsZSA9ICJyb2Nr Y2hpcCxyazMxMjgtcG11IiwgInN5c2NvbiIsICJzaW1wbGUtbWZkIjsKPj4+Pj4+ICAgICAJCXJl ZyA9IDwweDEwMGEwMDAwIDB4MTAwMD47Cj4+Pj4+PiArCj4+Pj4+PiArCQlwb3dlcjogcG93ZXIt Y29udHJvbGxlciB7Cj4+Pj4+PiArCQkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMxMjgtcG93 ZXItY29udHJvbGxlciI7Cj4+Pj4+PiArCQkJI3Bvd2VyLWRvbWFpbi1jZWxscyA9IDwxPjsKPj4+ Pj4+ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPj4+Pj4+ICsJCQkjc2l6ZS1jZWxscyA9IDww PjsKPj4+Pj4+ICsKPj4+Pj4+ICsJCQlwb3dlci1kb21haW5AUkszMTI4X1BEX1ZJTyB7Cj4+Pj4+ PiArCQkJCXJlZyA9IDxSSzMxMjhfUERfVklPPjsKPj4+Pj4+ICsJCQkJY2xvY2tzID0gPCZjcnUg QUNMS19DSUY+LAo+Pj4+Pj4gKwkJCQkJIDwmY3J1IEhDTEtfQ0lGPiwKPj4+Pj4+ICsJCQkJCSA8 JmNydSBEQ0xLX0VCQz4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgSENMS19FQkM+LAo+Pj4+Pj4gKwkJ CQkJIDwmY3J1IEFDTEtfSUVQPiwKPj4+Pj4+ICsJCQkJCSA8JmNydSBIQ0xLX0lFUD4sCj4+Pj4+ PiArCQkJCQkgPCZjcnUgQUNMS19MQ0RDMD4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgSENMS19MQ0RD MD4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgUENMS19NSVBJPiwKPj4+Pj4+ICsJCQkJCSA8JmNydSBB Q0xLX1JHQT4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgSENMS19SR0E+LAo+Pj4+Pj4gKwkJCQkJIDwm Y3J1IEFDTEtfVklPMD4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgQUNMS19WSU8xPiwKPj4+Pj4+ICsJ CQkJCSA8JmNydSBIQ0xLX1ZJTz4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgSENMS19WSU9fSDJQPiwK Pj4+Pj4+ICsJCQkJCSA8JmNydSBEQ0xLX1ZPUD4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgU0NMS19W T1A+Owo+Pj4+Pj4gKwkJCQlwbV9xb3MgPSA8JnFvc19lYmM+LAo+Pj4+Pj4gKwkJCQkJIDwmcW9z X2llcD4sCj4+Pj4+PiArCQkJCQkgPCZxb3NfbGNkYz4sCj4+Pj4+PiArCQkJCQkgPCZxb3Nfcmdh PiwKPj4+Pj4+ICsJCQkJCSA8JnFvc192aXA+Owo+Pj4+Pj4gKwkJCQkjcG93ZXItZG9tYWluLWNl bGxzID0gPDA+Owo+Pj4+Pj4gKwkJCX07Cj4+Pj4+PiArCj4+Pj4+PiArCQkJcG93ZXItZG9tYWlu QFJLMzEyOF9QRF9WSURFTyB7Cj4+Pj4+PiArCQkJCXJlZyA9IDxSSzMxMjhfUERfVklERU8+Owo+ Pj4+Pj4gKwkJCQljbG9ja3MgPSA8JmNydSBBQ0xLX1ZEUFU+LAo+Pj4+Pj4gKwkJCQkJIDwmY3J1 IEhDTEtfVkRQVT4sCj4+Pj4+PiArCQkJCQkgPCZjcnUgQUNMS19WRVBVPiwKPj4+Pj4+ICsJCQkJ CSA8JmNydSBIQ0xLX1ZFUFU+LAo+Pj4+Pj4gKwkJCQkJIDwmY3J1IFNDTEtfSEVWQ19DT1JFPjsK Pj4+Pj4+ICsJCQkJcG1fcW9zID0gPCZxb3NfdnB1PjsKPj4+Pj4+ICsJCQkJI3Bvd2VyLWRvbWFp bi1jZWxscyA9IDwwPjsKPj4+Pj4+ICsJCQl9Owo+Pj4+Pj4gKwo+Pj4+Pj4gKwkJCXBvd2VyLWRv bWFpbkBSSzMxMjhfUERfR1BVIHsKPj4+Pj4+ICsJCQkJcmVnID0gPFJLMzEyOF9QRF9HUFU+Owo+ Pj4+Pj4gKwkJCQljbG9ja3MgPSA8JmNydSBBQ0xLX0dQVT47Cj4+Pj4+PiArCQkJCXBtX3FvcyA9 IDwmcW9zX2dwdT47Cj4+Pj4+PiArCQkJCSNwb3dlci1kb21haW4tY2VsbHMgPSA8MD47Cj4+Pj4+ PiArCQkJfTsKPj4+Pj4+ICsKPj4+Pj4+ICsJCQlwb3dlci1kb21haW5AUkszMTI4X1BEX0NSWVBU TyB7Cj4+Pj4+PiArCQkJCXJlZyA9IDxSSzMxMjhfUERfQ1JZUFRPPjsKPj4+Pj4+ICsJCQkJY2xv Y2tzID0gPCZjcnUgSENMS19DUllQVE8+LAo+Pj4+Pj4gKwkJCQkJIDwmY3J1IFNDTEtfQ1JZUFRP PjsKPj4+Pj4+ICsJCQkJcG1fcW9zID0gPCZxb3NfY3J5cHRvPjsKPj4+Pj4+ICsJCQkJI3Bvd2Vy LWRvbWFpbi1jZWxscyA9IDwwPjsKPj4+Pj4+ICsJCQl9Owo+Pj4+Pj4gKwkJfTsKPj4+Pj4+ICsJ fTsKPj4+Pj4+ICsKPj4+Pj4+ICsJcW9zX2NyeXB0bzogcW9zQDEwMTI4MDgwIHsKPj4+Pj4+ICsJ CWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMTI4LXFvcyIsICJzeXNjb24iOwo+Pj4+Pj4gKwkJ cmVnID0gPDB4MTAxMjgwODAgMHgyMD47Cj4+Pj4+PiArCX07Cj4+Pj4+PiArCj4+Pj4+PiArCXFv c19ncHU6IHFvc0AxMDEyZDAwMCB7Cj4+Pj4+PiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJr MzEyOC1xb3MiLCAic3lzY29uIjsKPj4+Pj4+ICsJCXJlZyA9IDwweDEwMTJkMDAwIDB4MjA+Owo+ Pj4+Pj4gKwl9Owo+Pj4+Pj4gKwo+Pj4+Pj4gKwlxb3NfdnB1OiBxb3NAMTAxMmUwMDAgewo+Pj4+ Pj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMxMjgtcW9zIiwgInN5c2NvbiI7Cj4+Pj4+ PiArCQlyZWcgPSA8MHgxMDEyZTAwMCAweDIwPjsKPj4+Pj4+ICsJfTsKPj4+Pj4+ICsKPj4+Pj4+ ICsJcW9zX3JnYTogcW9zQDEwMTJmMDAwIHsKPj4+Pj4+ICsJCWNvbXBhdGlibGUgPSAicm9ja2No aXAscmszMTI4LXFvcyIsICJzeXNjb24iOwo+Pj4+Pj4gKwkJcmVnID0gPDB4MTAxMmYwMDAgMHgy MD47Cj4+Pj4+PiArCX07Cj4+Pj4+PiArCj4+Pj4+PiArCXFvc19lYmM6IHFvc0AxMDEyZjA4MCB7 Cj4+Pj4+PiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzEyOC1xb3MiLCAic3lzY29uIjsK Pj4+Pj4+ICsJCXJlZyA9IDwweDEwMTJmMDgwIDB4MjA+Owo+Pj4+Pj4gKwl9Owo+Pj4+Pj4gKwo+ Pj4+Pj4gKwlxb3NfaWVwOiBxb3NAMTAxMmYxMDAgewo+Pj4+Pj4gKwkJY29tcGF0aWJsZSA9ICJy b2NrY2hpcCxyazMxMjgtcW9zIiwgInN5c2NvbiI7Cj4+Pj4+PiArCQlyZWcgPSA8MHgxMDEyZjEw MCAweDIwPjsKPj4+Pj4+ICsJfTsKPj4+Pj4+ICsKPj4+Pj4+ICsJcW9zX2xjZGM6IHFvc0AxMDEy ZjE4MCB7Cj4+Pj4+PiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzEyOC1xb3MiLCAic3lz Y29uIjsKPj4+Pj4+ICsJCXJlZyA9IDwweDEwMTJmMTgwIDB4MjA+Owo+Pj4+Pj4gKwl9Owo+Pj4+ Pj4gKwo+Pj4+Pj4gKwlxb3NfdmlwOiBxb3NAMTAxMmYyMDAgewo+Pj4+Pj4gKwkJY29tcGF0aWJs ZSA9ICJyb2NrY2hpcCxyazMxMjgtcW9zIiwgInN5c2NvbiI7Cj4+Pj4+PiArCQlyZWcgPSA8MHgx MDEyZjIwMCAweDIwPjsKPj4+Pj4+ICAgICAJfTsKPj4+Pj4+ICAgICAKPj4+Pj4+ICAgICAJZ2lj OiBpbnRlcnJ1cHQtY29udHJvbGxlckAxMDEzOTAwMCB7Cj4+Pj4+Pgo+Pj4+Pgo+Pj4KPj4+Cj4K Pgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EEC8C4167B for ; Mon, 4 Dec 2023 15:23:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71C6210E0AD; Mon, 4 Dec 2023 15:23:48 +0000 (UTC) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by gabe.freedesktop.org (Postfix) with ESMTPS id E212A10E0AD for ; Mon, 4 Dec 2023 15:23:29 +0000 (UTC) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-54bf9a54fe3so5877591a12.3 for ; Mon, 04 Dec 2023 07:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701703408; x=1702308208; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mxYp/TPj2SDljkx7akhBocUojf/1bHbrDV2kmdKcuiw=; b=XGTLD10VlecrHtKK5uKHrXMwkJ2mFrulWv8KqQocOCkeZGxSy2wGZnqd7hrfB6fLGQ Utfihq3ZF7TOe0UdX6YEu2vSUvFgQXScouy2Jc+s0H6K+/pGPHJgNwrio1HIEWKAzL4H 1fK9RpJqQm3ilC+bvQDpZ5XU3ZMQ6io/zK20qBN5In23TGj0vRE3aIhUkdQr9URTwP0z HEVfjeBUc5kG0qRXK6r1c3ljJd7pklhDMFNt8Y4LlbOW+qJTuvgavdX2L18JmItnFBSv EAH9dzRvUJb70TDtOv3+mSjG1R0GFYDm7wb275L6UWx7i0zrwn6y1cX+YwcaWp3sbmV+ Uadg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701703408; x=1702308208; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mxYp/TPj2SDljkx7akhBocUojf/1bHbrDV2kmdKcuiw=; b=prF02oprXrxC7xABOGjRaN/POGKztdRcqBVIJmetZ7gbe9HFblIy4ZQgoJZCclTE6R h3+HFCBHbJtU5Wzo4+RuHMGihgruJDUp7tlCZxHIIKSqvkt+XFFji6UBHtoLwIcXNy9g OiTk4RvH9fXz74Xdu3YfVwooh58FLCx6Kaagj7b69EPPigcDQ9EeI5Ygri0F2Avrdvs1 o7A/m79X0pLr1x+cjjnSRa09OKS7vlk/SOLMszk9J10WjTFdJAjOYk8hyiIYon/hln81 OBLfuODHQNvt08aQijdRqSoo73jErWr1V1NiPUEhegYvAtEFKoljQnF+r69et/P1nWaQ JfQA== X-Gm-Message-State: AOJu0YyLILFe/bQYmwEVS4i3VR+g6APWiiJ6p7c59CtbhhAgU4B4f7+h 1YlTclYN7nLT1J/1olplWw== X-Google-Smtp-Source: AGHT+IH6NaMxB0hD8p+w4THyQqPHgLUhFhYRDIhCfbDi49ieB3DqkYaAbCCN/8DRLm52i+pnC1Tesg== X-Received: by 2002:a17:907:2daa:b0:a19:a1ba:8cc2 with SMTP id gt42-20020a1709072daa00b00a19a1ba8cc2mr3994784ejc.96.1701703407956; Mon, 04 Dec 2023 07:23:27 -0800 (PST) Received: from ?IPV6:2a02:810b:f40:4300:55ff:210b:5393:c9d7? ([2a02:810b:f40:4300:55ff:210b:5393:c9d7]) by smtp.gmail.com with ESMTPSA id s7-20020a170906bc4700b00a0f78db91c3sm5416316ejv.95.2023.12.04.07.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Dec 2023 07:23:27 -0800 (PST) Message-ID: Date: Mon, 4 Dec 2023 16:23:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] ARM: dts: rockchip: Add power-controller for RK3128 To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Conor Dooley , Krzysztof Kozlowski , Rob Herring References: <20231202125144.66052-1-knaerzche@gmail.com> <4891026.6YUMPnJmAY@diego> <4dec2316-f840-44ab-a07a-3d7f0e5e6d8f@gmail.com> <9588573.jRhZ6ZUK3Y@diego> Content-Language: en-US From: Alex Bee In-Reply-To: <9588573.jRhZ6ZUK3Y@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Heiko, Am 03.12.23 um 17:42 schrieb Heiko Stübner: > Hi Alex, > > Am Sonntag, 3. Dezember 2023, 17:05:47 CET schrieb Alex Bee: >> Am 02.12.23 um 18:46 schrieb Heiko Stübner: >>> Am Samstag, 2. Dezember 2023, 17:36:15 CET schrieb Alex Bee: >>>> Am 02.12.23 um 16:51 schrieb Heiko Stübner: >>>>> Am Samstag, 2. Dezember 2023, 13:51:41 CET schrieb Alex Bee: >>>>>> Add power controller and qos nodes for RK3128 in order to use >>>>>> them as powerdomains. >>>>> does the power-domain controller work with the incomplete set of >>>>> pm-domains too? >>>> Yes, it does - the missing domains can request idle only and can't be >>>> powered on/off - if no one requests idle they are just up all the time. >>>> >>>>> What I have in mind is >>>>> - adding the power-controller node with the existing set of power-domains >>>>> - the gpu pm-domain is in there >>>>> - adding the gpu parts >>>> My main concern about adding them later was the change of the ABI after >>>> they've been exposed in the SoC DT. If that's not an issue - sure: I can >>>> add them in a separate series. >>> An ABI change would be _changing_ the domain-ids in the rk3128-power.h >>> I think :-) . >> Well, an addition is still a change. >>> Right now the existing domain ids in the header are already exposed to the >>> world, so someone could already use them, but not the new ones. >> I'm fully aware that nothing would ever hard fail anywhere if the new >> domain ids get added later. >> >> Nevertheless we start using here an ABI which is known to be incomplete. >> For no reason, as the patches (which I am now asked to remove from this >> series) for completion are already there (here). >> >> Anyway, if you prefer it this way: I'm pleased to do so. > I was more thinking of accelerating the gpu-part of the series, as that > really is just waiting for the power-domain node that already has driver > support and domain-ids present. > > It looks like you're feeling more strongly about that though, so I'll > definitly not pressure you ;-) . I'm really not insisting on this - I just didn't understand why you would want this. And honestly I haven't considered merging timeline as an argument. So sure: Let's get the low hanging fruits merged for 6.8. Having the power domains in the DT will also help for my upcoming hdmi / vop series. Alex > > But I guess the split into IDs and driver change should still be > done, especially as the dt-binding-header likely will want an Ack > from the DT maintainers. > > And the power-domain change will go through the new pmdomain > subsystem. > > > Heiko > > >>>>> And a second series with >>>>> - patch1 from here >>>>> - a dts patch adding the additional pm-domains to rk3128.dtsi >>>>> - I guess patch1 also should be split into a patch adding the binding-ids >>>>> and a separate patch for the code addition. >>>> Yeah, I noticed this also :) >>>> >>>> Regards, >>>> >>>> Alex >>>> >>>>> Heiko >>>>> >>>>>> Signed-off-by: Alex Bee >>>>>> --- >>>>>> arch/arm/boot/dts/rockchip/rk3128.dtsi | 101 +++++++++++++++++++++++++ >>>>>> 1 file changed, 101 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm/boot/dts/rockchip/rk3128.dtsi b/arch/arm/boot/dts/rockchip/rk3128.dtsi >>>>>> index 4e8b38604ecd..b72905db04f7 100644 >>>>>> --- a/arch/arm/boot/dts/rockchip/rk3128.dtsi >>>>>> +++ b/arch/arm/boot/dts/rockchip/rk3128.dtsi >>>>>> @@ -8,6 +8,7 @@ >>>>>> #include >>>>>> #include >>>>>> #include >>>>>> +#include >>>>>> >>>>>> / { >>>>>> compatible = "rockchip,rk3128"; >>>>>> @@ -133,6 +134,106 @@ smp-sram@0 { >>>>>> pmu: syscon@100a0000 { >>>>>> compatible = "rockchip,rk3128-pmu", "syscon", "simple-mfd"; >>>>>> reg = <0x100a0000 0x1000>; >>>>>> + >>>>>> + power: power-controller { >>>>>> + compatible = "rockchip,rk3128-power-controller"; >>>>>> + #power-domain-cells = <1>; >>>>>> + #address-cells = <1>; >>>>>> + #size-cells = <0>; >>>>>> + >>>>>> + power-domain@RK3128_PD_VIO { >>>>>> + reg = ; >>>>>> + clocks = <&cru ACLK_CIF>, >>>>>> + <&cru HCLK_CIF>, >>>>>> + <&cru DCLK_EBC>, >>>>>> + <&cru HCLK_EBC>, >>>>>> + <&cru ACLK_IEP>, >>>>>> + <&cru HCLK_IEP>, >>>>>> + <&cru ACLK_LCDC0>, >>>>>> + <&cru HCLK_LCDC0>, >>>>>> + <&cru PCLK_MIPI>, >>>>>> + <&cru ACLK_RGA>, >>>>>> + <&cru HCLK_RGA>, >>>>>> + <&cru ACLK_VIO0>, >>>>>> + <&cru ACLK_VIO1>, >>>>>> + <&cru HCLK_VIO>, >>>>>> + <&cru HCLK_VIO_H2P>, >>>>>> + <&cru DCLK_VOP>, >>>>>> + <&cru SCLK_VOP>; >>>>>> + pm_qos = <&qos_ebc>, >>>>>> + <&qos_iep>, >>>>>> + <&qos_lcdc>, >>>>>> + <&qos_rga>, >>>>>> + <&qos_vip>; >>>>>> + #power-domain-cells = <0>; >>>>>> + }; >>>>>> + >>>>>> + power-domain@RK3128_PD_VIDEO { >>>>>> + reg = ; >>>>>> + clocks = <&cru ACLK_VDPU>, >>>>>> + <&cru HCLK_VDPU>, >>>>>> + <&cru ACLK_VEPU>, >>>>>> + <&cru HCLK_VEPU>, >>>>>> + <&cru SCLK_HEVC_CORE>; >>>>>> + pm_qos = <&qos_vpu>; >>>>>> + #power-domain-cells = <0>; >>>>>> + }; >>>>>> + >>>>>> + power-domain@RK3128_PD_GPU { >>>>>> + reg = ; >>>>>> + clocks = <&cru ACLK_GPU>; >>>>>> + pm_qos = <&qos_gpu>; >>>>>> + #power-domain-cells = <0>; >>>>>> + }; >>>>>> + >>>>>> + power-domain@RK3128_PD_CRYPTO { >>>>>> + reg = ; >>>>>> + clocks = <&cru HCLK_CRYPTO>, >>>>>> + <&cru SCLK_CRYPTO>; >>>>>> + pm_qos = <&qos_crypto>; >>>>>> + #power-domain-cells = <0>; >>>>>> + }; >>>>>> + }; >>>>>> + }; >>>>>> + >>>>>> + qos_crypto: qos@10128080 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x10128080 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_gpu: qos@1012d000 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012d000 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_vpu: qos@1012e000 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012e000 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_rga: qos@1012f000 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012f000 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_ebc: qos@1012f080 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012f080 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_iep: qos@1012f100 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012f100 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_lcdc: qos@1012f180 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012f180 0x20>; >>>>>> + }; >>>>>> + >>>>>> + qos_vip: qos@1012f200 { >>>>>> + compatible = "rockchip,rk3128-qos", "syscon"; >>>>>> + reg = <0x1012f200 0x20>; >>>>>> }; >>>>>> >>>>>> gic: interrupt-controller@10139000 { >>>>>> >>>>> >>> >>> > > >