All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory Rose <gvrose8192@gmail.com>
To: Netdev <netdev@vger.kernel.org>
Subject: net: Initialize return value in gro_cells_receive
Date: Tue, 6 Oct 2020 11:53:15 -0700	[thread overview]
Message-ID: <e595fd44-cf8a-ce14-8cc8-e3ecd4e8922a@gmail.com> (raw)

The 'res' return value is uninitalized and may be returned with
some random value.  Initialize to NET_RX_DROP as the default
return value.

Signed-off-by: Greg Rose <gvrose8192@gmail.com>

diff --git a/net/core/gro_cells.c b/net/core/gro_cells.c
index e095fb871d91..4e835960db07 100644
--- a/net/core/gro_cells.c
+++ b/net/core/gro_cells.c
@@ -13,7 +13,7 @@ int gro_cells_receive(struct gro_cells *gcells, struct 
sk_buff *skb)
  {
         struct net_device *dev = skb->dev;
         struct gro_cell *cell;
-       int res;
+       int res = NET_RX_DROP;

         rcu_read_lock();
         if (unlikely(!(dev->flags & IFF_UP)))

             reply	other threads:[~2020-10-06 18:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 18:53 Gregory Rose [this message]
2020-10-07  8:21 ` net: Initialize return value in gro_cells_receive Eric Dumazet
2020-10-07 15:50   ` Gregory Rose
2020-10-07 16:37     ` Eric Dumazet
2020-10-07 18:39       ` Gregory Rose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e595fd44-cf8a-ce14-8cc8-e3ecd4e8922a@gmail.com \
    --to=gvrose8192@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.