Re: [PATCHv3 for-next 0/4] RDMA/irdma: Refactor irdma_reg_user_mr function

[Zhu Yanjun <yanjun.zhu@linux.dev>]

在 2023/1/17 3:34, Zhu Yanjun 写道:
> V2->V3: 1) Use netdev reverse Christmas tree rule;
> 	2) Return 0 instead of err;
> 	3) Remove unnecessary brackets;
> 	4) Add an error label in error handler;
> 	5) Initialize the structured variables;

Hi, Leon

Follow your advice, I made this patches.
Please check it.

Zhu Yanjun

>   
> V1->V2: Thanks Saleem, Shiraz.
>          1) Remove the unnecessary variable initializations;
>          2) Get iwdev by to_iwdev;
> 	3) Use the label free_pble to handle errors;
> 	4) Validate the page size before rdma_umem_for_each_dma_block
> 
> Split the shared source codes into several new functions for future use.
> No bug fix and new feature in this commit series.
> 
> The new functions are as below:
> 
> irdma_reg_user_mr_type_mem
> irdma_alloc_iwmr
> irdma_free_iwmr
> irdma_reg_user_mr_type_qp
> irdma_reg_user_mr_type_cq
> 
> These functions will be used in the dmabuf feature.
> 
> Zhu Yanjun (4):
>    RDMA/irdma: Split MEM handler into irdma_reg_user_mr_type_mem
>    RDMA/irdma: Split mr alloc and free into new functions
>    RDMA/irdma: Split QP handler into irdma_reg_user_mr_type_qp
>    RDMA/irdma: Split CQ handler into irdma_reg_user_mr_type_cq
> 
>   drivers/infiniband/hw/irdma/verbs.c | 270 +++++++++++++++++-----------
>   1 file changed, 168 insertions(+), 102 deletions(-)
>