All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Abdul Wasey <w453y.me@gmail.com>
Cc: mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
	Geliang Tang <geliang@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	"Mohit P. Tahiliani" <tahiliani@nitk.edu.in>
Subject: Re: [PATCH mptcp-net v8 0/2] mptcp: pm: in-kernel: fullmesh: re-add of the initial subflow endp
Date: Wed, 18 Nov 2026 11:21:26 +0100	[thread overview]
Message-ID: <e5b05d4e-a3e0-4e77-a608-b58d0b89e87a@kernel.org> (raw)
In-Reply-To: <20261114082210.3439645-1-w453y.me@gmail.com>

Hi Abdul,

On 14/11/2026 09:22, Abdul Wasey wrote:
> On Sat, 24 Oct 2026 11:18:40 +0000, Abdul Wasey wrote:
>> With fullmesh endpoints, removing and re-adding the endpoint used by the
>> initial subflow never creates a new subflow from it: the closed initial
>> subflow stays in the conn_list, and makes the PM think the remote ID 0
>> is already used, or picks its reset remote address. If the initial
>> subflow was the only one, no address is left for the remote ID 0 at all.
>>
>> Patch 1 fixes that, patch 2 adds tests for it.
> 
> A gentle ping on this one, in case it got lost. The MPTCP CI and both
> Sashiko reviews of v8 were clean.

Thank you for your reminder, and for your patience.

> I saw patches 21 and 22 of your misc fixes series touch the same part of
> pm_kernel.c and the same "delete and re-add" test. I checked that they
> and this series apply on today's export-net, in either order, without
> conflicts.
> 
> If something in it should change, I can send a v9.

Thank you for having checked that. On my side, my plan is to finish all
the series I have in progress, especially the fixes ones (and the v2 of
this series you mentioned is getting huge...), but I will try to do some
reviews in between.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


      reply	other threads:[~2026-11-18 10:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 11:18 [PATCH mptcp-net v8 0/2] mptcp: pm: in-kernel: fullmesh: re-add of the initial subflow endp Abdul Wasey
2026-10-24 11:18 ` [PATCH mptcp-net v8 1/2] mptcp: pm: in-kernel: fullmesh: skip closed subflows Abdul Wasey
2026-10-24 11:18 ` [PATCH mptcp-net v8 2/2] selftests: mptcp: join: re-add the initial subflow endp with fullmesh Abdul Wasey
2026-10-24 12:39 ` [PATCH mptcp-net v8 0/2] mptcp: pm: in-kernel: fullmesh: re-add of the initial subflow endp MPTCP CI
2026-11-14  8:22 ` Abdul Wasey
2026-11-18 10:21   ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5b05d4e-a3e0-4e77-a608-b58d0b89e87a@kernel.org \
    --to=matttbe@kernel.org \
    --cc=geliang@kernel.org \
    --cc=martineau@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=tahiliani@nitk.edu.in \
    --cc=w453y.me@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.