From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51BF8C6FD1F for ; Thu, 16 Mar 2023 09:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=USr1mcavu183aIUMW2zaakLobziUEqGaltzaDkGJe7k=; b=pcq6e6EE10EBzP7PwoFAIA9Jka vaVV97595wpn02ruIj1cez1qgQVIC3ONz9sfnjO8qvGb8tMZFqPWoOQ8A+jdIKoq6WX7H6YpPZ+U1 YEIklacsMN0wfvBEtmGMvRTKTWaIigSfuuEk7AdkU7/lD6RlWUHGk7Z+182eVW44K3dRtNTG8euTS IuQIwupaeSmiqGZmP1IYVMwgnmwJfNBR9YAuTzdg2QevOwiK0qrM6nQO4Cdlg7xF3pyUawUdQF89w 0xNUqUvnG2cjZO4QF1qw629uZyZvUuopIxDj5pZmwz1qUL/bIkM5uo7G8X6R09RDJd2W/j4nazHJT Glu0ltOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pckJ5-00Fw8g-2x; Thu, 16 Mar 2023 09:53:59 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pckIz-00Fw4E-35; Thu, 16 Mar 2023 09:53:56 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id AE59F660309E; Thu, 16 Mar 2023 09:53:48 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678960429; bh=U016GfVVdnxsip9oeySV3RsjrHt+GbtN8I0vEam86cw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=D1ZYug/Rc7GC9oaJibLCGVC1ot6HrZSJaaD6dBId+/IevQCU8BtC3krYiV1jYB1vG QntG3e3/vTGxkEjKz92r3TfeVbI0b974DjcPXf4GI2j705nXTtC9lwiOAd2/AnY/F6 z0CXJd7cBrVcF76ENARf0NTaYVTa7yGwdM/0MVCXo3vZlYh0D5bvxoNXrF0aymJ3Zb F8uYdm9tAIDz6DQWBRSVg36L9plmJGvA5FyZrNRsHMRHMDyI3PxKybudbJIEiuNwVP V/QFPGh4hL2xHjhAFEFAKBm5yn+8gIYX9WiQd8Y0uE7XWaJ+xmz5ux83Th4WlKzPyS T+JmIMMYGK3Ig== Message-ID: Date: Thu, 16 Mar 2023 10:53:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195 Content-Language: en-US To: Krzysztof Kozlowski , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "p.zabel@pengutronix.de" , "matthias.bgg@gmail.com" , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , "nathan@kernel.org" , "devicetree@vger.kernel.org" , "daniel@ffwll.ch" , =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "dri-devel@lists.freedesktop.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "clang-built-linux@googlegroups.com" , "ndesaulniers@google.com" References: <20221227081011.6426-1-nancy.lin@mediatek.com> <20221227081011.6426-2-nancy.lin@mediatek.com> <4aff6a7a3b606f26ec793192d9c75774276935e0.camel@mediatek.com> <2700bd6c-f00d-fa99-b730-2fcdf89089fa@linaro.org> <1d65e8b2de708db18b5f7a0faaa53834e1002d9f.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_025354_255509_8A99F7AE X-CRM114-Status: GOOD ( 15.58 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 16/03/23 07:31, Krzysztof Kozlowski ha scritto: > On 16/03/2023 07:19, Nancy Lin (林欣螢) wrote: >> On Wed, 2023-03-15 at 08:16 +0100, Krzysztof Kozlowski wrote: >>> On 15/03/2023 04:45, Nancy Lin (林欣螢) wrote: >>> ..snip.. >>>> >>>> >>>> [1]. >>>> Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.e >>>> xamp >>>> le.dtb >>>> /proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devi >>>> cetr >>>> ee/bindings/display/mediatek/mediatek,ethdr.example.dtb: >>>> hdr-engine@1c114000: mediatek,gce-client-reg:0: [4294967295, 7, >>>> 16384, >>>> 4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096, >>>> 4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295, >>>> 7, >>>> 45056, 4096, 4294967295, 7, 49152, 4096] is too long >>>> From schema: >>> >>> This looks like known issue with phandles with variable number of >>> arguments. Either we add it to the exceptions or just define it in >>> reduced way like in other cases - only maxItems: 1 without describing >>> items. >>> ... >> >> But I have several items for this vendor property in the binding >> example. > > Do you? I thought you have one phandle? > >> Can I remove maxItems? Change the mediatek,gce-client-reg as [1]. >> >> [1] >> mediatek,gce-client-reg: >> $ref: /schemas/types.yaml#/definitions/phandle-array >> description: The register of display function block to be set by >> gce. >> There are 4 arguments in this property, gce node, subsys id, >> offset and >> register size. The subsys id is defined in the gce header of each >> chips >> include/dt-bindings/gce/-gce.h, mapping to the register of >> display >> function block. > > No, this needs some constraints. Hello Krzysztof, Nancy, Since this series has reached v29, can we please reach an agreement on the bindings to use here, so that we can get this finally upstreamed? I will put some examples to try to get this issue resolved. ### Example 1: Constrain the number of GCE entries to *seven* array elements (7x4!) mediatek,gce-client-reg: $ref: /schemas/types.yaml#/definitions/phandle-array maxItems: 1 description: The register of display function block to be set by gce. There are 4 arguments in this property, gce node, subsys id, offset and register size. The subsys id is defined in the gce header of each chips include/dt-bindings/gce/-gce.h, mapping to the register of display function block. items: minItems: 28 maxItems: 28 items: <----- this block doesn't seem to get checked :\ - description: phandle of GCE - description: GCE subsys id - description: register offset - description: register size ### Example 2: Don't care about constraining the number of arguments mediatek,gce-client-reg: $ref: /schemas/types.yaml#/definitions/phandle-array maxItems: 1 description: The register of display function block to be set by gce. There are 4 arguments in this property, gce node, subsys id, offset and register size. The subsys id is defined in the gce header of each chips include/dt-bindings/gce/-gce.h, mapping to the register of display function block. Regards, Angelo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 049A8C6FD19 for ; Thu, 16 Mar 2023 09:54:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MXJbebzCAt2YVixUtY3almhHIEC0B+0eCPOQPi970+8=; b=tzOxr/EkKb+La2 J39c7L4993VD4t64VCnMBh16tjQilwoa6FXOZnODwm99LCJeFh06J5A1itPjDvZXjJssq4Nq+wwKn fPKtov6DmzyLGTUlK2QcKL9+JRIujNhRsVW3O6OlI++/15+GDqzXZtPtzBi46RYpQbXctyW6SjiRR fD/7Xj8WH5DG5Of75c9CRZ4NPZTm6gsJSox/bykYo9cSIdSqkWcliJySxiUJyOaMQGLK8bQ22vQlm O0kKeQHuVGJRxlWyT0i7Z+2ZkNrohPPemC85wycaD8H8PKdxPRaUfzDh1+SjRlOVUUMmGsdO9MGhN XjbVE3mNFaQdpFT/UzGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pckJ4-00Fw7p-31; Thu, 16 Mar 2023 09:53:58 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pckIz-00Fw4E-35; Thu, 16 Mar 2023 09:53:56 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id AE59F660309E; Thu, 16 Mar 2023 09:53:48 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678960429; bh=U016GfVVdnxsip9oeySV3RsjrHt+GbtN8I0vEam86cw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=D1ZYug/Rc7GC9oaJibLCGVC1ot6HrZSJaaD6dBId+/IevQCU8BtC3krYiV1jYB1vG QntG3e3/vTGxkEjKz92r3TfeVbI0b974DjcPXf4GI2j705nXTtC9lwiOAd2/AnY/F6 z0CXJd7cBrVcF76ENARf0NTaYVTa7yGwdM/0MVCXo3vZlYh0D5bvxoNXrF0aymJ3Zb F8uYdm9tAIDz6DQWBRSVg36L9plmJGvA5FyZrNRsHMRHMDyI3PxKybudbJIEiuNwVP V/QFPGh4hL2xHjhAFEFAKBm5yn+8gIYX9WiQd8Y0uE7XWaJ+xmz5ux83Th4WlKzPyS T+JmIMMYGK3Ig== Message-ID: Date: Thu, 16 Mar 2023 10:53:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195 Content-Language: en-US To: Krzysztof Kozlowski , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "p.zabel@pengutronix.de" , "matthias.bgg@gmail.com" , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , "nathan@kernel.org" , "devicetree@vger.kernel.org" , "daniel@ffwll.ch" , =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "dri-devel@lists.freedesktop.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "clang-built-linux@googlegroups.com" , "ndesaulniers@google.com" References: <20221227081011.6426-1-nancy.lin@mediatek.com> <20221227081011.6426-2-nancy.lin@mediatek.com> <4aff6a7a3b606f26ec793192d9c75774276935e0.camel@mediatek.com> <2700bd6c-f00d-fa99-b730-2fcdf89089fa@linaro.org> <1d65e8b2de708db18b5f7a0faaa53834e1002d9f.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_025354_255509_8A99F7AE X-CRM114-Status: GOOD ( 15.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMTYvMDMvMjMgMDc6MzEsIEtyenlzenRvZiBLb3psb3dza2kgaGEgc2NyaXR0bzoKPiBPbiAx Ni8wMy8yMDIzIDA3OjE5LCBOYW5jeSBMaW4gKOael+aso+ieoikgd3JvdGU6Cj4+IE9uIFdlZCwg MjAyMy0wMy0xNSBhdCAwODoxNiArMDEwMCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPj4+ IE9uIDE1LzAzLzIwMjMgMDQ6NDUsIE5hbmN5IExpbiAo5p6X5qyj6J6iKSB3cm90ZToKPj4+Cgou LnNuaXAuLgoKPj4+Pgo+Pj4+Cj4+Pj4gWzFdLgo+Pj4+IERvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L21lZGlhdGVrL21lZGlhdGVrLGV0aGRyLmUKPj4+PiB4YW1wCj4+ Pj4gbGUuZHRiCj4+Pj4gL3Byb2ovbXRrMTkzNDcvY3Jvcy9zcmMvdGhpcmRfcGFydHkva2VybmVs L3Y1LjEwL0RvY3VtZW50YXRpb24vZGV2aQo+Pj4+IGNldHIKPj4+PiBlZS9iaW5kaW5ncy9kaXNw bGF5L21lZGlhdGVrL21lZGlhdGVrLGV0aGRyLmV4YW1wbGUuZHRiOgo+Pj4+IGhkci1lbmdpbmVA MWMxMTQwMDA6IG1lZGlhdGVrLGdjZS1jbGllbnQtcmVnOjA6IFs0Mjk0OTY3Mjk1LCA3LAo+Pj4+ IDE2Mzg0LAo+Pj4+IDQwOTYsIDQyOTQ5NjcyOTUsIDcsIDIwNDgwLCA0MDk2LCA0Mjk0OTY3Mjk1 LCA3LCAyODY3MiwgNDA5NiwKPj4+PiA0Mjk0OTY3Mjk1LCA3LCAzNjg2NCwgNDA5NiwgNDI5NDk2 NzI5NSwgNywgNDA5NjAsIDQwOTYsIDQyOTQ5NjcyOTUsCj4+Pj4gNywKPj4+PiA0NTA1NiwgNDA5 NiwgNDI5NDk2NzI5NSwgNywgNDkxNTIsIDQwOTZdIGlzIHRvbyBsb25nCj4+Pj4gICAgICAgICAg RnJvbSBzY2hlbWE6Cj4+Pgo+Pj4gVGhpcyBsb29rcyBsaWtlIGtub3duIGlzc3VlIHdpdGggcGhh bmRsZXMgd2l0aCB2YXJpYWJsZSBudW1iZXIgb2YKPj4+IGFyZ3VtZW50cy4gRWl0aGVyIHdlIGFk ZCBpdCB0byB0aGUgZXhjZXB0aW9ucyBvciBqdXN0IGRlZmluZSBpdCBpbgo+Pj4gcmVkdWNlZCB3 YXkgbGlrZSBpbiBvdGhlciBjYXNlcyAtIG9ubHkgbWF4SXRlbXM6IDEgd2l0aG91dCBkZXNjcmli aW5nCj4+PiBpdGVtcy4KPj4+CgouLi4KCj4+Cj4+IEJ1dCBJIGhhdmUgc2V2ZXJhbCBpdGVtcyBm b3IgdGhpcyB2ZW5kb3IgcHJvcGVydHkgaW4gdGhlIGJpbmRpbmcKPj4gZXhhbXBsZS4KPiAKPiBE byB5b3U/IEkgdGhvdWdodCB5b3UgaGF2ZSBvbmUgcGhhbmRsZT8KPiAKPj4gQ2FuIEkgcmVtb3Zl IG1heEl0ZW1zPyBDaGFuZ2UgdGhlIG1lZGlhdGVrLGdjZS1jbGllbnQtcmVnIGFzIFsxXS4KPj4K Pj4gWzFdCj4+ICAgIG1lZGlhdGVrLGdjZS1jbGllbnQtcmVnOgo+PiAgICAgICRyZWY6IC9zY2hl bWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3BoYW5kbGUtYXJyYXkKPj4gICAgICBkZXNjcmlw dGlvbjogVGhlIHJlZ2lzdGVyIG9mIGRpc3BsYXkgZnVuY3Rpb24gYmxvY2sgdG8gYmUgc2V0IGJ5 Cj4+IGdjZS4KPj4gICAgICAgIFRoZXJlIGFyZSA0IGFyZ3VtZW50cyBpbiB0aGlzIHByb3BlcnR5 LCBnY2Ugbm9kZSwgc3Vic3lzIGlkLAo+PiBvZmZzZXQgYW5kCj4+ICAgICAgICByZWdpc3RlciBz aXplLiBUaGUgc3Vic3lzIGlkIGlzIGRlZmluZWQgaW4gdGhlIGdjZSBoZWFkZXIgb2YgZWFjaAo+ PiBjaGlwcwo+PiAgICAgICAgaW5jbHVkZS9kdC1iaW5kaW5ncy9nY2UvPGNoaXA+LWdjZS5oLCBt YXBwaW5nIHRvIHRoZSByZWdpc3RlciBvZgo+PiBkaXNwbGF5Cj4+ICAgICAgICBmdW5jdGlvbiBi bG9jay4KPiAKPiBObywgdGhpcyBuZWVkcyBzb21lIGNvbnN0cmFpbnRzLgoKSGVsbG8gS3J6eXN6 dG9mLCBOYW5jeSwKClNpbmNlIHRoaXMgc2VyaWVzIGhhcyByZWFjaGVkIHYyOSwgY2FuIHdlIHBs ZWFzZSByZWFjaCBhbiBhZ3JlZW1lbnQgb24gdGhlIGJpbmRpbmdzCnRvIHVzZSBoZXJlLCBzbyB0 aGF0IHdlIGNhbiBnZXQgdGhpcyBmaW5hbGx5IHVwc3RyZWFtZWQ/CgpJIHdpbGwgcHV0IHNvbWUg ZXhhbXBsZXMgdG8gdHJ5IHRvIGdldCB0aGlzIGlzc3VlIHJlc29sdmVkLgoKIyMjIEV4YW1wbGUg MTogQ29uc3RyYWluIHRoZSBudW1iZXIgb2YgR0NFIGVudHJpZXMgdG8gKnNldmVuKiBhcnJheSBl bGVtZW50cyAoN3g0ISkKCiAgIG1lZGlhdGVrLGdjZS1jbGllbnQtcmVnOgogICAgICRyZWY6IC9z Y2hlbWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3BoYW5kbGUtYXJyYXkKICAgICBtYXhJdGVt czogMQogICAgIGRlc2NyaXB0aW9uOiBUaGUgcmVnaXN0ZXIgb2YgZGlzcGxheSBmdW5jdGlvbiBi bG9jayB0byBiZSBzZXQgYnkgZ2NlLgogICAgICAgVGhlcmUgYXJlIDQgYXJndW1lbnRzIGluIHRo aXMgcHJvcGVydHksIGdjZSBub2RlLCBzdWJzeXMgaWQsIG9mZnNldCBhbmQKICAgICAgIHJlZ2lz dGVyIHNpemUuIFRoZSBzdWJzeXMgaWQgaXMgZGVmaW5lZCBpbiB0aGUgZ2NlIGhlYWRlciBvZiBl YWNoIGNoaXBzCiAgICAgICBpbmNsdWRlL2R0LWJpbmRpbmdzL2djZS88Y2hpcD4tZ2NlLmgsIG1h cHBpbmcgdG8gdGhlIHJlZ2lzdGVyIG9mIGRpc3BsYXkKICAgICAgIGZ1bmN0aW9uIGJsb2NrLgog ICAgIGl0ZW1zOgogICAgICAgbWluSXRlbXM6IDI4CiAgICAgICBtYXhJdGVtczogMjgKICAgICAg IGl0ZW1zOiAgICAgICAgICAgICAgICAgICAgIDwtLS0tLSB0aGlzIGJsb2NrIGRvZXNuJ3Qgc2Vl bSB0byBnZXQgY2hlY2tlZCA6XAogICAgICAgICAtIGRlc2NyaXB0aW9uOiBwaGFuZGxlIG9mIEdD RQogICAgICAgICAtIGRlc2NyaXB0aW9uOiBHQ0Ugc3Vic3lzIGlkCiAgICAgICAgIC0gZGVzY3Jp cHRpb246IHJlZ2lzdGVyIG9mZnNldAogICAgICAgICAtIGRlc2NyaXB0aW9uOiByZWdpc3RlciBz aXplCgoKIyMjIEV4YW1wbGUgMjogRG9uJ3QgY2FyZSBhYm91dCBjb25zdHJhaW5pbmcgdGhlIG51 bWJlciBvZiBhcmd1bWVudHMKCiAgIG1lZGlhdGVrLGdjZS1jbGllbnQtcmVnOgogICAgICRyZWY6 IC9zY2hlbWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3BoYW5kbGUtYXJyYXkKICAgICBtYXhJ dGVtczogMQogICAgIGRlc2NyaXB0aW9uOiBUaGUgcmVnaXN0ZXIgb2YgZGlzcGxheSBmdW5jdGlv biBibG9jayB0byBiZSBzZXQgYnkgZ2NlLgogICAgICAgVGhlcmUgYXJlIDQgYXJndW1lbnRzIGlu IHRoaXMgcHJvcGVydHksIGdjZSBub2RlLCBzdWJzeXMgaWQsIG9mZnNldCBhbmQKICAgICAgIHJl Z2lzdGVyIHNpemUuIFRoZSBzdWJzeXMgaWQgaXMgZGVmaW5lZCBpbiB0aGUgZ2NlIGhlYWRlciBv ZiBlYWNoIGNoaXBzCiAgICAgICBpbmNsdWRlL2R0LWJpbmRpbmdzL2djZS88Y2hpcD4tZ2NlLmgs IG1hcHBpbmcgdG8gdGhlIHJlZ2lzdGVyIG9mIGRpc3BsYXkKICAgICAgIGZ1bmN0aW9uIGJsb2Nr LgoKClJlZ2FyZHMsCkFuZ2VsbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9D62C6FD19 for ; Thu, 16 Mar 2023 09:53:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1234210EC37; Thu, 16 Mar 2023 09:53:53 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 389F610EC37 for ; Thu, 16 Mar 2023 09:53:51 +0000 (UTC) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id AE59F660309E; Thu, 16 Mar 2023 09:53:48 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678960429; bh=U016GfVVdnxsip9oeySV3RsjrHt+GbtN8I0vEam86cw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=D1ZYug/Rc7GC9oaJibLCGVC1ot6HrZSJaaD6dBId+/IevQCU8BtC3krYiV1jYB1vG QntG3e3/vTGxkEjKz92r3TfeVbI0b974DjcPXf4GI2j705nXTtC9lwiOAd2/AnY/F6 z0CXJd7cBrVcF76ENARf0NTaYVTa7yGwdM/0MVCXo3vZlYh0D5bvxoNXrF0aymJ3Zb F8uYdm9tAIDz6DQWBRSVg36L9plmJGvA5FyZrNRsHMRHMDyI3PxKybudbJIEiuNwVP V/QFPGh4hL2xHjhAFEFAKBm5yn+8gIYX9WiQd8Y0uE7XWaJ+xmz5ux83Th4WlKzPyS T+JmIMMYGK3Ig== Message-ID: Date: Thu, 16 Mar 2023 10:53:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195 Content-Language: en-US To: Krzysztof Kozlowski , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "p.zabel@pengutronix.de" , "matthias.bgg@gmail.com" , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" References: <20221227081011.6426-1-nancy.lin@mediatek.com> <20221227081011.6426-2-nancy.lin@mediatek.com> <4aff6a7a3b606f26ec793192d9c75774276935e0.camel@mediatek.com> <2700bd6c-f00d-fa99-b730-2fcdf89089fa@linaro.org> <1d65e8b2de708db18b5f7a0faaa53834e1002d9f.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , "ndesaulniers@google.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "nathan@kernel.org" , "clang-built-linux@googlegroups.com" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 16/03/23 07:31, Krzysztof Kozlowski ha scritto: > On 16/03/2023 07:19, Nancy Lin (林欣螢) wrote: >> On Wed, 2023-03-15 at 08:16 +0100, Krzysztof Kozlowski wrote: >>> On 15/03/2023 04:45, Nancy Lin (林欣螢) wrote: >>> ..snip.. >>>> >>>> >>>> [1]. >>>> Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.e >>>> xamp >>>> le.dtb >>>> /proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devi >>>> cetr >>>> ee/bindings/display/mediatek/mediatek,ethdr.example.dtb: >>>> hdr-engine@1c114000: mediatek,gce-client-reg:0: [4294967295, 7, >>>> 16384, >>>> 4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096, >>>> 4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295, >>>> 7, >>>> 45056, 4096, 4294967295, 7, 49152, 4096] is too long >>>> From schema: >>> >>> This looks like known issue with phandles with variable number of >>> arguments. Either we add it to the exceptions or just define it in >>> reduced way like in other cases - only maxItems: 1 without describing >>> items. >>> ... >> >> But I have several items for this vendor property in the binding >> example. > > Do you? I thought you have one phandle? > >> Can I remove maxItems? Change the mediatek,gce-client-reg as [1]. >> >> [1] >> mediatek,gce-client-reg: >> $ref: /schemas/types.yaml#/definitions/phandle-array >> description: The register of display function block to be set by >> gce. >> There are 4 arguments in this property, gce node, subsys id, >> offset and >> register size. The subsys id is defined in the gce header of each >> chips >> include/dt-bindings/gce/-gce.h, mapping to the register of >> display >> function block. > > No, this needs some constraints. Hello Krzysztof, Nancy, Since this series has reached v29, can we please reach an agreement on the bindings to use here, so that we can get this finally upstreamed? I will put some examples to try to get this issue resolved. ### Example 1: Constrain the number of GCE entries to *seven* array elements (7x4!) mediatek,gce-client-reg: $ref: /schemas/types.yaml#/definitions/phandle-array maxItems: 1 description: The register of display function block to be set by gce. There are 4 arguments in this property, gce node, subsys id, offset and register size. The subsys id is defined in the gce header of each chips include/dt-bindings/gce/-gce.h, mapping to the register of display function block. items: minItems: 28 maxItems: 28 items: <----- this block doesn't seem to get checked :\ - description: phandle of GCE - description: GCE subsys id - description: register offset - description: register size ### Example 2: Don't care about constraining the number of arguments mediatek,gce-client-reg: $ref: /schemas/types.yaml#/definitions/phandle-array maxItems: 1 description: The register of display function block to be set by gce. There are 4 arguments in this property, gce node, subsys id, offset and register size. The subsys id is defined in the gce header of each chips include/dt-bindings/gce/-gce.h, mapping to the register of display function block. Regards, Angelo