From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C6FC26C3B6 for ; Thu, 25 Sep 2025 21:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758834133; cv=none; b=tYWXKe6KT23tFAscVleijM5jJ99OOqujuTH2NbfRhqgDqOyQeV7227L3TZpxhjDIDv6AlzMne6l6QBV5HzN5w96vTTmKaZ4PKtB0HyyXFA9J24vAwfuLLIVCwPpmohoDS6dIDQoLclbkvuDqCXSs1KGDkusjf17JVG1jEAXGqyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758834133; c=relaxed/simple; bh=NP087fGQxBLpbj+8sgJEXj+QviU9eybSjhcQDIYO2VA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=R2sFfb8u19rmXOccX5IxXkhZxgNzmQjqLbLGjtYCcXAmcRpjY8LTyoFssL774JXSbs0qsUB/sPxhYxqRp2r7mO8omdTElsK37K1DiJFfC7J/Uqi7iGe57fbme0c3oYRqlJb8JPxpXQnVgBX7tMBA+obOqYIYat8fsqQIrkO/SjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W4WtbUlG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W4WtbUlG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B206AC4CEF0; Thu, 25 Sep 2025 21:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758834133; bh=NP087fGQxBLpbj+8sgJEXj+QviU9eybSjhcQDIYO2VA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=W4WtbUlGQbMjpjALNn3QVSqc9dNXGbyTruu+IP6/AtH4U/IT9yOs5mm9BTFLRJeqJ APwAr8oaFiIyaAl1rLjWgrJoPac//dL2z7zwUzndUtGTbSbBd8MCUZpwPsTyegzuxJ 75KVo6XcewyuWYaU30PNUzAZl/8zlQw/MpPN4FSmKgPYQgDf826vwyI3IVB5KU6MaR hLSkXIOONme/T6omLFV7ZAKgJVXc4vu1tl59bL7VQOt6Rm6UAc1jlgiKqcHX9rtpyd boC7OWb3fOS0O29X3U4lFoiJx1E5N6M3Hi/FOa/zRhiJee+uKzQ2r0fzpm4UIXWh8C x9M03HbaDBeog== Message-ID: Subject: Re: [PATCH v3 00/38] vfs, nfsd: implement directory delegations From: Jeff Layton To: Anna Schumaker , Anna Schumaker Cc: linux-nfs@vger.kernel.org Date: Thu, 25 Sep 2025 17:02:11 -0400 In-Reply-To: <414c0a7b-e767-4061-acd6-bfe8dbff39a1@oracle.com> References: <20250924-dir-deleg-v3-0-9f3af8bc5c40@kernel.org> <414c0a7b-e767-4061-acd6-bfe8dbff39a1@oracle.com> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2025-09-25 at 16:45 -0400, Anna Schumaker wrote: > Hi Jeff, >=20 > (I trimmed off most of the extra people CC-ed, since this appears to most= ly be an > NFS issue) >=20 > I hit this crash while stepping through my client side code and fixing it= up against > your latest branch. I'm at a point where the client only requests the del= egation, but > without any requested notifications, if that helps: > >=20 > [ 643.888646] BUG: kernel NULL pointer dereference, address: 00000000000= 00168 > [ 643.889045] #PF: supervisor read access in kernel mode > [ 643.889314] #PF: error_code(0x0000) - not-present page > [ 643.889591] PGD 0 P4D 0=20 > [ 643.889733] Oops: Oops: 0000 [#1] SMP NOPTI > [ 643.889960] CPU: 3 UID: 0 PID: 1003 Comm: nfsd Not tainted 6.17.0-rc7-= 00095-gf6fa32f97c33 #47188 PREEMPT(full) b859994234adae648e07409684697d13c= 51d22ee > [ 643.890665] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS u= nknown 02/02/2022 > [ 643.891076] RIP: 0010:nfsd_handle_dir_event+0x49/0x2c0 [nfsd] > [ 643.891490] Code: 24 04 83 f9 01 74 11 83 f9 04 74 19 83 f9 02 75 11 4= d 8b 64 24 08 eb 0d 49 8b 04 24 4c 8b 60 08 eb 03 45 31 e4 0f 1f 44 00 00 <= 4c> 8b b6 68 01 00 00 4d 85 f6 0f 84 dc 01 00 00 49 8d 5e 28 49 8b > [ 643.892432] RSP: 0018:ffffd0d202333a80 EFLAGS: 00010246 > [ 643.892711] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 000000000= 0000004 > [ 643.893076] RDX: ffff8e3b55ad4480 RSI: 0000000000000000 RDI: 000000004= 0000004 > [ 643.893441] RBP: 0000000040000004 R08: 0000000000000000 R09: 000000000= 0000000 > [ 643.893816] R10: fffffffffffffffb R11: ffffffffc0a80500 R12: ffff8e3b5= 5ad4480 > [ 643.894183] R13: 0000000000000000 R14: 0000000000000004 R15: 000000000= 0000004 > [ 643.894554] FS: 0000000000000000(0000) GS:ffff8e3f10206000(0000) knlG= S:0000000000000000 > [ 643.894961] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 643.895258] CR2: 0000000000000168 CR3: 0000000112571002 CR4: 000000000= 0772ef0 > [ 643.895644] PKRU: 55555554 > [ 643.895792] Call Trace: > [ 643.895931] > [ 643.896050] fsnotify+0x69a/0x9a0 > [ 643.896233] fsnotify_change+0xad/0xc0 > [ 643.896431] notify_change+0x34f/0x380 > [ 643.896633] nfsd_setattr+0x314/0x6f0 [nfsd 0b3fc8b3981bb65e36d518f9ed= ccb6d9f216a09a] > [ 643.897073] ? nfsd_setuser_and_check_port+0xdd/0x120 [nfsd 0b3fc8b398= 1bb65e36d518f9edccb6d9f216a09a] > [ 643.897576] nfsd4_setattr+0x254/0x370 [nfsd 0b3fc8b3981bb65e36d518f9e= dccb6d9f216a09a] > [ 643.898014] ? nfsd4_encode_operation+0x207/0x2b0 [nfsd 0b3fc8b3981bb6= 5e36d518f9edccb6d9f216a09a] > [ 643.898502] nfsd4_proc_compound+0x337/0x600 [nfsd 0b3fc8b3981bb65e36d= 518f9edccb6d9f216a09a] > [ 643.898964] nfsd_dispatch+0xc1/0x210 [nfsd 0b3fc8b3981bb65e36d518f9ed= ccb6d9f216a09a] > [ 643.899390] svc_process_common+0x567/0x6a0 [sunrpc c8ffd8e151f2f4e7c4= 5ca22edc099dc57603df52] > [ 643.899881] ? __pfx_nfsd_dispatch+0x10/0x10 [nfsd 0b3fc8b3981bb65e36d= 518f9edccb6d9f216a09a] > [ 643.900341] svc_process+0x117/0x200 [sunrpc c8ffd8e151f2f4e7c45ca22ed= c099dc57603df52] > [ 643.900790] svc_recv+0xa7d/0xbc0 [sunrpc c8ffd8e151f2f4e7c45ca22edc09= 9dc57603df52] > [ 643.901208] nfsd+0xb6/0xf0 [nfsd 0b3fc8b3981bb65e36d518f9edccb6d9f216= a09a] > [ 643.901598] ? __pfx_nfsd+0x10/0x10 [nfsd 0b3fc8b3981bb65e36d518f9edcc= b6d9f216a09a] > [ 643.902024] kthread+0x215/0x250 > [ 643.902201] ? __pfx_kthread+0x10/0x10 > [ 643.902394] ret_from_fork+0x106/0x1d0 > [ 643.902606] ? __pfx_kthread+0x10/0x10 > [ 643.902800] ret_from_fork_asm+0x1a/0x30 > [ 643.903013] > [ 643.903133] Modules linked in: rpcsec_gss_krb5 rpcrdma rdma_cm ib_cm i= w_cm ib_core cfg80211 rfkill 8021q mrp garp stp llc ext4 mbcache crc16 jbd2= vfat fat intel_rapl_msr intel_rapl_common intel_uncore_frequency_common in= tel_pmc_core intel_pmc_ssram_telemetry pmt_telemetry snd_hda_codec_generic = pmt_discovery pmt_class intel_vsec snd_hda_intel snd_intel_dspcfg kvm_intel= snd_hda_codec snd_hwdep kvm snd_hda_core irqbypass snd_pcm polyval_clmulni= iTCO_wdt ghash_clmulni_intel intel_pmc_bxt iTCO_vendor_support aesni_intel= snd_timer psmouse rapl i2c_i801 pcspkr snd lpc_ich i2c_smbus soundcore joy= dev mousedev mac_hid btrfs raid6_pq xor nfsd nfs_acl lockd grace nfs_locali= o auth_rpcgss usbip_host usbip_core dm_mod loop sunrpc nfnetlink vsock_loop= back vmw_vsock_virtio_transport_common vmw_vsock_vmci_transport vsock vmw_v= mci qemu_fw_cfg xfs serio_raw virtio_gpu virtio_dma_buf virtio_rng virtio_s= csi virtio_balloon virtio_net intel_agp net_failover failover intel_gtt > [ 643.909087] CR2: 0000000000000168 > [ 643.909503] ---[ end trace 0000000000000000 ]--- >=20 >=20 > Any guesses for what could be causing this? > Anna >=20 Yes. It happened in a SETATTR and I forgot to handle that case in nfsd_handle_dir_event(). Will fix. I suspect that we probably just want to just recall the delegation in this case. Another option would be to send a DIR_ATTRS update to the client, but it's possible that the dir_delegation isn't set up to send the attrs that changed, and trying to sort that out sounds like a mess. --=20 Jeff Layton